Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store log of archives in rollup contract #7615

Closed
Tracked by #7614
just-mitch opened this issue Jul 25, 2024 · 0 comments · Fixed by #7635
Closed
Tracked by #7614

feat: store log of archives in rollup contract #7615

just-mitch opened this issue Jul 25, 2024 · 0 comments · Fixed by #7635
Assignees

Comments

@just-mitch
Copy link
Contributor

just-mitch commented Jul 25, 2024

This will allow us to keep track of the current tips of the "proven" and "pending" chains/logs.

As part of this issue we will store references into the list that get updated when we process pending blocks and their respective proofs.

We will also need to handle non-sequential proofs. see more

@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 25, 2024
@LHerskind LHerskind self-assigned this Jul 25, 2024
LHerskind added a commit that referenced this issue Jul 31, 2024
Fixes #7615.

Adds a list of "BlockLog"s what we have within the 🐢 team talked about
just as log for more generic consensus notation, and then have two
values to address whereto the pending and the proven is accounted for.

Add extra requirements to the `submitProof` function to ensure that
proofs are actually linked to the blocks that are in the pending log. If
all constraints are passed, will mark the block as proven (but not
instantly move the tip forward).

Introduce a `progressState` function which we execute at every proof
submission that will try to progress the proven tip as far as possible
(as long as the next block is proven we continue).

This allow us to deal with non-sequential proving. 

- Also renames the fixtures to be block 1 and 2 instead of 0, 1 as it
makes it much easier to reason about when the genesis block is actually
already in the chain.
- Changed a few wrongly ordered error messages.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants