feat: Add log of blocks proposed and split pending/proven

[LHerskind]

Fixes #7615.

Adds a list of "BlockLog"s what we have within the 🐢 team talked about just as log for more generic consensus notation, and then have two values to address whereto the pending and the proven is accounted for.

Add extra requirements to the submitProof function to ensure that proofs are actually linked to the blocks that are in the pending log. If all constraints are passed, will mark the block as proven (but not instantly move the tip forward).

Introduce a progressState function which we execute at every proof submission that will try to progress the proven tip as far as possible (as long as the next block is proven we continue).

This allow us to deal with non-sequential proving.

• Also renames the fixtures to be block 1 and 2 instead of 0, 1 as it makes it much easier to reason about when the genesis block is actually already in the chain.
• Changed a few wrongly ordered error messages.

[LHerskind]

• feat: Plumbing for slot numbers #7663
• feat: swap-or-not shuffle #7646
• feat: Add log of blocks proposed and split pending/proven #7635 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_poseidon_hash_30_ms (1): 1,947 (+28%)
• avm_simulation_time_ms (Token:transfer_public): 41.7 (+86%)
• protocol_circuit_proving_time_in_ms (base-parity): 1,388 (-32%)
• node_history_sync_time_in_ms (5): 12,788 (+29%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,709	1,538	702 (-1%)	759 (+3%)	760 (-1%)
proof_construction_time_sha256_30_ms	11,837 (+1%)	3,163	1,422	1,449	1,470
proof_construction_time_sha256_100_ms	45,056 (+3%)	12,262 (-2%)	5,746 (-1%)	5,608	5,751 (+4%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0 (-3%)	60.0 (+3%)	88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	⚠️ 1,947 (+28%)	418 (+1%)	200	223 (-3%)	269
proof_construction_time_poseidon_hash_100_ms	5,595	1,508	670 (-1%)	727 (-2%)	744

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	708	708	708
l1_rollup_calldata_gas	6,588	6,588	6,600
l1_rollup_execution_gas	611,430 (+5%)	611,581 (+5%)	611,744 (+5%)
l2_block_processing_time_in_ms	762 (+1%)	1,421 (+1%)	2,696
l2_block_building_time_in_ms	10,658	21,509 (+4%)	41,360 (+1%)
l2_block_rollup_simulation_time_in_ms	10,658	21,508 (+4%)	41,360 (+1%)
l2_block_public_tx_process_time_in_ms	8,911	19,492 (+4%)	39,302 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,030 (-1%)	⚠️ 12,788 (+29%)
node_database_size_in_bytes	12,709,968	16,937,040
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	96.9 (-1%)	403 (-3%)	21,798	53,090	N/A	N/A	N/A	N/A
private-kernel-inner	174	697 (-3%)	80,891	53,266	N/A	N/A	N/A	N/A
private-kernel-tail	427	898 (+3%)	61,159	57,447	N/A	N/A	N/A	N/A
base-parity	6.44	648 (-3%)	160	96.0	⚠️ 1,388 (-32%)	13,188	19.0	131,072
root-parity	112	120 (-5%)	69,084	96.0	30,266 (-4%)	13,188	19.0	4,194,304
base-rollup	3,475 (+4%)	4,877 (-1%)	182,192	632	43,821 (-3%)	13,988	44.0	4,194,304
root-rollup	161 (+3%)	123 (-1%)	54,461	684	29,067 (-4%)	13,956	43.0	4,194,304
public-kernel-setup	97.9	2,672 (-3%)	112,985	80,246	18,077	141,444	4,027	2,097,152
public-kernel-app-logic	116 (+3%)	3,936 (-5%)	112,985	80,246	11,289	141,444	4,027	1,048,576
public-kernel-tail	643 (+2%)	26,972 (-4%)	410,726	10,814	66,041 (-5%)	26,372	431	8,388,608
private-kernel-reset-tiny	229	870 (-3%)	76,585	52,961	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	4,457 (-14%)	1,520 (-4%)	888,733	1,697	N/A	N/A	N/A	N/A
public-kernel-teardown	92.4 (+1%)	4,034 (-1%)	112,985	80,246	19,315 (-2%)	141,444	4,027	2,097,152
merge-rollup	61.9 (+2%)	N/A	35,678	632	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	156,375 (-3%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,312	11,699	341 (-1%)	N/A	N/A
ContractInstanceDeployer:deploy	1,376	11,699	27.2 (-1%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	11,699	600	N/A	N/A
GasToken:deploy	1,344	11,699	432 (-2%)	N/A	N/A
SchnorrAccount:constructor	1,280	11,699	425 (-1%)	N/A	N/A
SchnorrAccount:entrypoint	2,272	11,699	836 (+2%)	N/A	N/A
Token:privately_mint_private_note	1,248	11,699	501	N/A	N/A
FPC:fee_entrypoint_public	1,312	11,699	85.3 (-2%)	N/A	N/A
Token:transfer	1,280	11,699	1,300 (-1%)	N/A	N/A
AuthRegistry:set_authorized (avm)	18,427	N/A	N/A	102,048	2,012 (+1%)
FPC:prepare_fee (avm)	22,894	N/A	N/A	102,112	2,151 (-3%)
Token:transfer_public (avm)	46,817	N/A	N/A	102,112	6,280 (-3%)
AuthRegistry:consume (avm)	26,670	N/A	N/A	102,080	2,543
FPC:pay_refund (avm)	26,163	N/A	N/A	102,080	3,539 (+1%)
Benchmarking:create_note	1,312	11,699	439 (+5%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	11,699	48.1 (+10%)	N/A	N/A
Token:unshield	1,344	11,699	1,130 (+1%)	N/A	N/A
FPC:fee_entrypoint_private	1,344	11,699	1,395 (-1%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	93.4 (-3%)	8,139
GasToken:set_portal	13.7 (-9%)	2,362
Token:constructor	120 (-2%)	16,400
FPC:constructor	90.6 (-1%)	9,304
GasToken:mint_public	83.7	6,150
Token:mint_public	98.4 (-5%)	11,720
Token:assert_minter_and_mint	58.6 (+22%)	8,028
AuthRegistry:set_authorized	44.0	4,537
FPC:prepare_fee	236 (+2%)	8,812
Token:transfer_public	⚠️ 41.7 (+86%)	32,641
FPC:pay_refund	82.6 (+21%)	12,114
Benchmarking:increment_balance	1,061 (+2%)	7,450
Token:_increase_public_balance	13.5 (-24%)	8,960
FPC:pay_refund_with_shielded_rebate	126 (-5%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.154

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.3 (+9%)	17.6 (+5%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.655 (+9%)	0.541 (+5%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.5 (+1%)	95.1 (+26%)	131	244	467
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.496 (+1%)	0.586 (+26%)	0.450	0.443	0.437
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.7 (+1%)	135 (+22%)	183	351	690
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.505 (+1%)	0.609 (+22%)	0.485	0.476	0.476
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	74.5 (+2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.534 (+3%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,017	666,910

Transaction size based on fee payment method

| Metric | |
| - | |

[just-mitch]

Could we decode the header, set the block num, then re-encode it?

[LHerskind]

It is not really decoded here, we are providing a json that have both the raw bytes and a decoded version. The thing we are testing is partially that all of the decoding is working as expected and matching the typescript, so I would prefer not to rely on an extra implementation for the correctness.

[just-mitch]

Broken comment

[just-mitch]

You're saying in the event the pending chain grows too far beyond the proven chain? Wouldn't a timeliness requirement effectively bound this?

[LHerskind]

Even with a timeliness, it "could" grow very large if blocks are coming in at max speed, and you could even have that it is past the timeliness but you just keep on extending and then at before someone is actually pruning it you would execute this. Sure, it is very unlikely, but you don't want to end up with a frozen system anyway.