chore: Less noisy AVM failures in proving #8227

spalladino · 2024-08-27T18:34:26Z

If AVM fails to prove and AVM_PROVING_STRICT is not set, do not log an error.

spalladino · 2024-08-27T18:35:28Z

Current state of logs around AVM is:

@timestamp	@message	@logstream	@log
2024-08-27 18:12:51.418	2024-08-27T18:12:51.417Z aztec:bb-prover [INFO] Generated witness circuitName=root-parity duration=52.088863134384155 inputSize=121668 outputSize=96 eventName=circuit-witness-generation	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.260	2024-08-27T18:12:51.260Z aztec:prover-client:prover-pool:queue [ERROR] Job id=d7c02e64 type=PUBLIC_VM failed with error: (JSON-RPC PROPAGATED) Attempted to read beyond buffer length. Start index: 96, Num bytes to read: 32, Buffer length: 116	ecs/provernet-aztec-prover-node-1/8b486eb193e143afa83f0ae50be4abb1	278380418400:/fargate/service/provernet/aztec-prover-node-1
2024-08-27 18:12:51.260	2024-08-27T18:12:51.260Z aztec:prover:proving-orchestrator [WARN] Error thrown when proving AVM circuit: (JSON-RPC PROPAGATED) Attempted to read beyond buffer length. Start index: 96, Num bytes to read: 32, Buffer length: 116	ecs/provernet-aztec-prover-node-1/8b486eb193e143afa83f0ae50be4abb1	278380418400:/fargate/service/provernet/aztec-prover-node-1
2024-08-27 18:12:51.260	2024-08-27T18:12:51.260Z aztec:prover:proving-orchestrator [WARN] AVM_PROVING_STRICT is off, faking AVM proof and carrying on...	ecs/provernet-aztec-prover-node-1/8b486eb193e143afa83f0ae50be4abb1	278380418400:/fargate/service/provernet/aztec-prover-node-1
2024-08-27 18:12:51.259	2024-08-27T18:12:51.259Z aztec:prover-client:prover-agent [ERROR] Error processing proving job id=d7c02e64 type=PUBLIC_VM: Error: (JSON-RPC PROPAGATED) Attempted to read beyond buffer length. Start index: 96, Num bytes to read: 32, Buffer length: 116	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at defaultFetch (file:///usr/src/yarn-project/foundation/dest/json-rpc/client/json_rpc_client.js:47:19)	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at process.processTicksAndRejections (node:internal/process/task_queues:95:5)	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at async retry (file:///usr/src/yarn-project/foundation/dest/retry/index.js:47:20)	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at async file:///usr/src/yarn-project/foundation/dest/json-rpc/client/json_rpc_client.js:64:16	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at async request (file:///usr/src/yarn-project/foundation/dest/json-rpc/client/json_rpc_client.js:88:21)	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at async ProverAgent.work (file:///usr/src/yarn-project/prover-client/dest/prover-agent/prover-agent.js:97:17): NoRetryError: (JSON-RPC PROPAGATED) Attempted to read beyond buffer length. Start index: 96, Num bytes to read: 32, Buffer length: 116	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at defaultFetch (file:///usr/src/yarn-project/foundation/dest/json-rpc/client/json_rpc_client.js:47:19)	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at process.processTicksAndRejections (node:internal/process/task_queues:95:5)	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at async retry (file:///usr/src/yarn-project/foundation/dest/retry/index.js:47:20)	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at async file:///usr/src/yarn-project/foundation/dest/json-rpc/client/json_rpc_client.js:64:16	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at async request (file:///usr/src/yarn-project/foundation/dest/json-rpc/client/json_rpc_client.js:88:21)	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1
2024-08-27 18:12:51.259	at async ProverAgent.work (file:///usr/src/yarn-project/prover-client/dest/prover-agent/prover-agent.js:97:17)	ecs/provernet-aztec-proving-agent-group-1/d0bd020bcd9244d4ab9692f706c8ffbd	278380418400:/fargate/service/provernet/aztec-proving-agent-group-1

AztecBot · 2024-08-27T18:51:54Z

Benchmark results

Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 665 (-52%)
avm_simulation_time_ms (Token:mint_public): 70.0 (+56%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 41.0 (-39%)
avm_simulation_time_ms (Token:transfer_public): 40.3 (+44%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,742	1,562	709 (-1%)	745 (-3%)	772
proof_construction_time_sha256_30_ms	11,464	3,078 (-1%)	1,378 (-2%)	1,427 (-1%)	1,452 (-2%)
proof_construction_time_sha256_100_ms	44,025	11,834	5,475	5,453 (-4%)	5,690 (-3%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	59.0 (-2%)	88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,529	422	201	231	268
proof_construction_time_poseidon_hash_100_ms	5,642	1,512	672 (-1%)	728 (-2%)	747

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,268	93,010	178,060
l1_rollup_execution_gas	842,928	1,576,566	3,361,672
l2_block_processing_time_in_ms	254 (+4%)	444 (-4%)	794 (-4%)
l2_block_building_time_in_ms	11,293 (-1%)	22,135 (-1%)	43,970 (-2%)
l2_block_rollup_simulation_time_in_ms	11,292 (-1%)	22,135 (-1%)	43,970 (-2%)
l2_block_public_tx_process_time_in_ms	9,607 (-1%)	20,324 (-1%)	42,147 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,996 (-1%)	3,826 (-4%)
node_database_size_in_bytes	12,619,856	16,703,568
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	90.8 (-1%)	397	21,735	44,860	N/A
private-kernel-inner	176 (-6%)	699	72,544	45,007	N/A
private-kernel-reset-tiny	312 (+1%)	709 (-1%)	65,593	44,846	N/A
private-kernel-tail	166	135 (-1%)	50,644	52,257	N/A
base-parity	5.57 (-1%)	N/A	160	96.0	N/A
root-parity	35.3 (-2%)	N/A	73,948	96.0	N/A
base-rollup	3,416 (-2%)	N/A	189,136	664	N/A
block-root-rollup	41.3 (-1%)	N/A	58,205	2,448	N/A
public-kernel-setup	84.6 (-1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	96.1 (-1%)	N/A	104,911	71,222	N/A
public-kernel-tail	854 (-1%)	N/A	390,582	16,414	N/A
private-kernel-reset-small	312	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	⚠️ 665 (-52%)	612	455,400	1,825	N/A
public-kernel-teardown	83.5 (-2%)	N/A	105,349	71,222	N/A
merge-rollup	20.1 (-1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	77,511 (-1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	340 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.1 (-1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	403 (-1%)
FeeJuice:deploy	1,376	11,731	386 (-1%)
SchnorrAccount:constructor	1,312	11,731	73.6
SchnorrAccount:entrypoint	2,304	11,731	393 (-1%)
Token:privately_mint_private_note	1,280	11,731	102 (-6%)
FPC:fee_entrypoint_public	1,344	11,731	29.1 (+7%)
Token:transfer	1,312	11,731	229 (+2%)
Benchmarking:create_note	1,344	11,731	85.1 (-3%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.8
Token:unshield	1,376	11,731	523
FPC:fee_entrypoint_private	1,376	11,731	698 (-2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	56.0 (-10%)	7,101
FeeJuice:set_portal	12.4 (+20%)	2,128
Token:constructor	82.2 (-3%)	25,285
FPC:constructor	54.3 (-2%)	17,853
FeeJuice:mint_public	39.4 (-7%)	5,415
Token:mint_public	⚠️ 70.0 (+56%)	10,101
Token:assert_minter_and_mint	⚠️ 41.0 (-39%)	6,844
AuthRegistry:set_authorized	37.2 (-20%)	3,969
FPC:prepare_fee	241 (+3%)	6,747
Token:transfer_public	⚠️ 40.3 (+44%)	38,126
FPC:pay_refund	51.1 (-5%)	9,398
Benchmarking:increment_balance	1,190 (-1%)	6,179
Token:_increase_public_balance	38.7 (-2%)	7,705
FPC:pay_refund_with_shielded_rebate	62.4 (-1%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.159

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.16 (-3%)	3.95 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (-2%)	0.112 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.2 (-2%)	17.7 (-3%)	30.6 (-2%)	59.6	112 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108 (-2%)	0.103 (-3%)	0.0996 (-2%)	0.103	0.100 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.2 (-1%)	25.2 (-3%)	43.3 (-1%)	82.5	159 (-3%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108 (-1%)	0.102 (-2%)	0.105 (-1%)	0.102	0.100 (-2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

alexghr · 2024-08-27T18:57:52Z

yarn-project/prover-client/src/prover-agent/memory-proving-queue.ts

+          ? this.log.warn
+          : this.log.error;


💡 great idea!

If AVM fails to prove and AVM_PROVING_STRICT is not set, do not log an error.

* master: (207 commits) refactor: disallow prune in devnet + add onlyOwners (#8134) refactor: add partial note support for value note (#8141) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg Update external-ci-approved.yml fix: Fixes for the nightly test run against Sepolia (#8229) fix: Docker containers healthchecks (#8228) chore: Create external-ci-approved.yml (#8235) refactor: rework balances map (#8127) feat: Add CLI command for gathering proving metrics (#8221) chore: Less noisy AVM failures in proving (#8227) chore: open an issue if publishing bb fails (#8223) feat: spartan token transfer (#8163) fix: Attempt to fix nightly test (#8222) feat: initial validator set (#8133) chore: Configure interval mining for anvil (#8211) fix: remove devnet ARM builds for now (#8202) fix: Export brillig names in contract functions (#8212) ...

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.51.1</summary> ## [0.51.1](aztec-package-v0.51.0...aztec-package-v0.51.1) (2024-08-29) ### Features * Add status check to prover agent ([#8248](#8248)) ([7b3006a](7b3006a)) * Faster L1 deployment ([#8234](#8234)) ([51d6699](51d6699)) * Spartan token transfer ([#8163](#8163)) ([38f0157](38f0157)) </details> <details><summary>barretenberg.js: 0.51.1</summary> ## [0.51.1](barretenberg.js-v0.51.0...barretenberg.js-v0.51.1) (2024-08-29) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.51.1</summary> ## [0.51.1](aztec-packages-v0.51.0...aztec-packages-v0.51.1) (2024-08-29) ### Features * Add CLI command for gathering proving metrics ([#8221](#8221)) ([5929a42](5929a42)) * Add status check to prover agent ([#8248](#8248)) ([7b3006a](7b3006a)) * **avm:** 1-slot sload/sstore (nr, ts) ([#8264](#8264)) ([bdd9b06](bdd9b06)) * **avm:** Range check gadget ([#7967](#7967)) ([0dd954e](0dd954e)) * **docs:** Add partial notes doc ([#8192](#8192)) ([4299bbd](4299bbd)) * Faster L1 deployment ([#8234](#8234)) ([51d6699](51d6699)) * Initial validator set ([#8133](#8133)) ([6d31ad2](6d31ad2)) * L1-publisher cleanup ([#8148](#8148)) ([6ae2535](6ae2535)) * Proof surgery class ([#8236](#8236)) ([10d7edd](10d7edd)) * Request specific transactions through the p2p layer ([#8185](#8185)) ([54e1cc7](54e1cc7)) * Slot duration flexibility ([#8122](#8122)) ([708e4e5](708e4e5)) * Spartan token transfer ([#8163](#8163)) ([38f0157](38f0157)) ### Bug Fixes * Attempt to fix nightly test ([#8222](#8222)) ([477eec5](477eec5)) * **avm-simulator:** Await avm bytecode check ([#8268](#8268)) ([4410eb3](4410eb3)) * **bb-prover:** Create structure for AVM vk ([#8233](#8233)) ([55b6ba2](55b6ba2)) * **bb:** Mac build ([#8255](#8255)) ([ac54f5c](ac54f5c)) * **ci:** Spot-runner-action was not built ([#8274](#8274)) ([c1509c1](c1509c1)) * **ci:** Try fix brotli edge-case ([#8256](#8256)) ([e03ea0b](e03ea0b)) * Docker containers healthchecks ([#8228](#8228)) ([19edbbb](19edbbb)) * **docs:** Update entrypoint details on accounts page ([#8184](#8184)) ([8453ec7](8453ec7)) * Export brillig names in contract functions ([#8212](#8212)) ([4745741](4745741)) * Fixes for the nightly test run against Sepolia ([#8229](#8229)) ([cfc65c6](cfc65c6)) * Handle constant output for sha256 ([#8251](#8251)) ([0653ba5](0653ba5)) * Log public vm errors as warn in prover-agent ([#8247](#8247)) ([9f4ea9f](9f4ea9f)) * Remove devnet ARM builds for now ([#8202](#8202)) ([81ef715](81ef715)) * Remove fundFpc step from bootstrap ([#8245](#8245)) ([a742531](a742531)) * Ts codegen ([#8267](#8267)) ([cb58800](cb58800)) ### Miscellaneous * Add check to just release images to devnet-deploys ([#8242](#8242)) ([aa6791d](aa6791d)) * Add partial note support for value note ([#8141](#8141)) ([daa57cc](daa57cc)) * Always run `build-check` step in `publish-bb.yml` ([#8240](#8240)) ([5e9749f](5e9749f)) * **avm:** Replace range and cmp with gadgets ([#8164](#8164)) ([cc12558](cc12558)) * Basic network matrix ([#8257](#8257)) ([2a76b1a](2a76b1a)), closes [#8001](#8001) * **bb:** Use std::span in pippenger for scalars ([#8269](#8269)) ([2323cd5](2323cd5)) * Configure interval mining for anvil ([#8211](#8211)) ([eba57b4](eba57b4)) * Create external-ci-approved.yml ([#8235](#8235)) ([24b059b](24b059b)) * Disallow prune in devnet + add onlyOwners ([#8134](#8134)) ([c736f96](c736f96)) * Fix various warnings in noir code ([#8258](#8258)) ([1c6b478](1c6b478)) * Less noisy AVM failures in proving ([#8227](#8227)) ([03bcd62](03bcd62)) * Open an issue if publishing bb fails ([#8223](#8223)) ([2d7a775](2d7a775)) * Reinstate l1-contracts package ([#8250](#8250)) ([263a912](263a912)) * Remove unused generic parameters ([#8249](#8249)) ([00ed045](00ed045)) * Replace relative paths to noir-protocol-circuits ([1783c80](1783c80)) * Replace relative paths to noir-protocol-circuits ([ffe1f35](ffe1f35)) * Report prover metrics ([#8155](#8155)) ([dc7bcdf](dc7bcdf)), closes [#7675](#7675) * Rework balances map ([#8127](#8127)) ([1cac3dd](1cac3dd)), closes [#8104](#8104) * Run CI after merges to provernet ([#8244](#8244)) ([97e5e25](97e5e25)) ### Documentation * Minor fixes ([#8273](#8273)) ([2b8af9e](2b8af9e)) </details> <details><summary>barretenberg: 0.51.1</summary> ## [0.51.1](barretenberg-v0.51.0...barretenberg-v0.51.1) (2024-08-29) ### Features * **avm:** 1-slot sload/sstore (nr, ts) ([#8264](#8264)) ([bdd9b06](bdd9b06)) * **avm:** Range check gadget ([#7967](#7967)) ([0dd954e](0dd954e)) * Proof surgery class ([#8236](#8236)) ([10d7edd](10d7edd)) ### Bug Fixes * **bb-prover:** Create structure for AVM vk ([#8233](#8233)) ([55b6ba2](55b6ba2)) * **bb:** Mac build ([#8255](#8255)) ([ac54f5c](ac54f5c)) * Handle constant output for sha256 ([#8251](#8251)) ([0653ba5](0653ba5)) ### Miscellaneous * **avm:** Replace range and cmp with gadgets ([#8164](#8164)) ([cc12558](cc12558)) * **bb:** Use std::span in pippenger for scalars ([#8269](#8269)) ([2323cd5](2323cd5)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.51.1</summary> ## [0.51.1](AztecProtocol/aztec-packages@aztec-package-v0.51.0...aztec-package-v0.51.1) (2024-08-29) ### Features * Add status check to prover agent ([#8248](AztecProtocol/aztec-packages#8248)) ([7b3006a](AztecProtocol/aztec-packages@7b3006a)) * Faster L1 deployment ([#8234](AztecProtocol/aztec-packages#8234)) ([51d6699](AztecProtocol/aztec-packages@51d6699)) * Spartan token transfer ([#8163](AztecProtocol/aztec-packages#8163)) ([38f0157](AztecProtocol/aztec-packages@38f0157)) </details> <details><summary>barretenberg.js: 0.51.1</summary> ## [0.51.1](AztecProtocol/aztec-packages@barretenberg.js-v0.51.0...barretenberg.js-v0.51.1) (2024-08-29) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.51.1</summary> ## [0.51.1](AztecProtocol/aztec-packages@aztec-packages-v0.51.0...aztec-packages-v0.51.1) (2024-08-29) ### Features * Add CLI command for gathering proving metrics ([#8221](AztecProtocol/aztec-packages#8221)) ([5929a42](AztecProtocol/aztec-packages@5929a42)) * Add status check to prover agent ([#8248](AztecProtocol/aztec-packages#8248)) ([7b3006a](AztecProtocol/aztec-packages@7b3006a)) * **avm:** 1-slot sload/sstore (nr, ts) ([#8264](AztecProtocol/aztec-packages#8264)) ([bdd9b06](AztecProtocol/aztec-packages@bdd9b06)) * **avm:** Range check gadget ([#7967](AztecProtocol/aztec-packages#7967)) ([0dd954e](AztecProtocol/aztec-packages@0dd954e)) * **docs:** Add partial notes doc ([#8192](AztecProtocol/aztec-packages#8192)) ([4299bbd](AztecProtocol/aztec-packages@4299bbd)) * Faster L1 deployment ([#8234](AztecProtocol/aztec-packages#8234)) ([51d6699](AztecProtocol/aztec-packages@51d6699)) * Initial validator set ([#8133](AztecProtocol/aztec-packages#8133)) ([6d31ad2](AztecProtocol/aztec-packages@6d31ad2)) * L1-publisher cleanup ([#8148](AztecProtocol/aztec-packages#8148)) ([6ae2535](AztecProtocol/aztec-packages@6ae2535)) * Proof surgery class ([#8236](AztecProtocol/aztec-packages#8236)) ([10d7edd](AztecProtocol/aztec-packages@10d7edd)) * Request specific transactions through the p2p layer ([#8185](AztecProtocol/aztec-packages#8185)) ([54e1cc7](AztecProtocol/aztec-packages@54e1cc7)) * Slot duration flexibility ([#8122](AztecProtocol/aztec-packages#8122)) ([708e4e5](AztecProtocol/aztec-packages@708e4e5)) * Spartan token transfer ([#8163](AztecProtocol/aztec-packages#8163)) ([38f0157](AztecProtocol/aztec-packages@38f0157)) ### Bug Fixes * Attempt to fix nightly test ([#8222](AztecProtocol/aztec-packages#8222)) ([477eec5](AztecProtocol/aztec-packages@477eec5)) * **avm-simulator:** Await avm bytecode check ([#8268](AztecProtocol/aztec-packages#8268)) ([4410eb3](AztecProtocol/aztec-packages@4410eb3)) * **bb-prover:** Create structure for AVM vk ([#8233](AztecProtocol/aztec-packages#8233)) ([55b6ba2](AztecProtocol/aztec-packages@55b6ba2)) * **bb:** Mac build ([#8255](AztecProtocol/aztec-packages#8255)) ([ac54f5c](AztecProtocol/aztec-packages@ac54f5c)) * **ci:** Spot-runner-action was not built ([#8274](AztecProtocol/aztec-packages#8274)) ([c1509c1](AztecProtocol/aztec-packages@c1509c1)) * **ci:** Try fix brotli edge-case ([#8256](AztecProtocol/aztec-packages#8256)) ([e03ea0b](AztecProtocol/aztec-packages@e03ea0b)) * Docker containers healthchecks ([#8228](AztecProtocol/aztec-packages#8228)) ([19edbbb](AztecProtocol/aztec-packages@19edbbb)) * **docs:** Update entrypoint details on accounts page ([#8184](AztecProtocol/aztec-packages#8184)) ([8453ec7](AztecProtocol/aztec-packages@8453ec7)) * Export brillig names in contract functions ([#8212](AztecProtocol/aztec-packages#8212)) ([4745741](AztecProtocol/aztec-packages@4745741)) * Fixes for the nightly test run against Sepolia ([#8229](AztecProtocol/aztec-packages#8229)) ([cfc65c6](AztecProtocol/aztec-packages@cfc65c6)) * Handle constant output for sha256 ([#8251](AztecProtocol/aztec-packages#8251)) ([0653ba5](AztecProtocol/aztec-packages@0653ba5)) * Log public vm errors as warn in prover-agent ([#8247](AztecProtocol/aztec-packages#8247)) ([9f4ea9f](AztecProtocol/aztec-packages@9f4ea9f)) * Remove devnet ARM builds for now ([#8202](AztecProtocol/aztec-packages#8202)) ([81ef715](AztecProtocol/aztec-packages@81ef715)) * Remove fundFpc step from bootstrap ([#8245](AztecProtocol/aztec-packages#8245)) ([a742531](AztecProtocol/aztec-packages@a742531)) * Ts codegen ([#8267](AztecProtocol/aztec-packages#8267)) ([cb58800](AztecProtocol/aztec-packages@cb58800)) ### Miscellaneous * Add check to just release images to devnet-deploys ([#8242](AztecProtocol/aztec-packages#8242)) ([aa6791d](AztecProtocol/aztec-packages@aa6791d)) * Add partial note support for value note ([#8141](AztecProtocol/aztec-packages#8141)) ([daa57cc](AztecProtocol/aztec-packages@daa57cc)) * Always run `build-check` step in `publish-bb.yml` ([#8240](AztecProtocol/aztec-packages#8240)) ([5e9749f](AztecProtocol/aztec-packages@5e9749f)) * **avm:** Replace range and cmp with gadgets ([#8164](AztecProtocol/aztec-packages#8164)) ([cc12558](AztecProtocol/aztec-packages@cc12558)) * Basic network matrix ([#8257](AztecProtocol/aztec-packages#8257)) ([2a76b1a](AztecProtocol/aztec-packages@2a76b1a)), closes [#8001](AztecProtocol/aztec-packages#8001) * **bb:** Use std::span in pippenger for scalars ([#8269](AztecProtocol/aztec-packages#8269)) ([2323cd5](AztecProtocol/aztec-packages@2323cd5)) * Configure interval mining for anvil ([#8211](AztecProtocol/aztec-packages#8211)) ([eba57b4](AztecProtocol/aztec-packages@eba57b4)) * Create external-ci-approved.yml ([#8235](AztecProtocol/aztec-packages#8235)) ([24b059b](AztecProtocol/aztec-packages@24b059b)) * Disallow prune in devnet + add onlyOwners ([#8134](AztecProtocol/aztec-packages#8134)) ([c736f96](AztecProtocol/aztec-packages@c736f96)) * Fix various warnings in noir code ([#8258](AztecProtocol/aztec-packages#8258)) ([1c6b478](AztecProtocol/aztec-packages@1c6b478)) * Less noisy AVM failures in proving ([#8227](AztecProtocol/aztec-packages#8227)) ([03bcd62](AztecProtocol/aztec-packages@03bcd62)) * Open an issue if publishing bb fails ([#8223](AztecProtocol/aztec-packages#8223)) ([2d7a775](AztecProtocol/aztec-packages@2d7a775)) * Reinstate l1-contracts package ([#8250](AztecProtocol/aztec-packages#8250)) ([263a912](AztecProtocol/aztec-packages@263a912)) * Remove unused generic parameters ([#8249](AztecProtocol/aztec-packages#8249)) ([00ed045](AztecProtocol/aztec-packages@00ed045)) * Replace relative paths to noir-protocol-circuits ([1783c80](AztecProtocol/aztec-packages@1783c80)) * Replace relative paths to noir-protocol-circuits ([ffe1f35](AztecProtocol/aztec-packages@ffe1f35)) * Report prover metrics ([#8155](AztecProtocol/aztec-packages#8155)) ([dc7bcdf](AztecProtocol/aztec-packages@dc7bcdf)), closes [#7675](AztecProtocol/aztec-packages#7675) * Rework balances map ([#8127](AztecProtocol/aztec-packages#8127)) ([1cac3dd](AztecProtocol/aztec-packages@1cac3dd)), closes [#8104](AztecProtocol/aztec-packages#8104) * Run CI after merges to provernet ([#8244](AztecProtocol/aztec-packages#8244)) ([97e5e25](AztecProtocol/aztec-packages@97e5e25)) ### Documentation * Minor fixes ([#8273](AztecProtocol/aztec-packages#8273)) ([2b8af9e](AztecProtocol/aztec-packages@2b8af9e)) </details> <details><summary>barretenberg: 0.51.1</summary> ## [0.51.1](AztecProtocol/aztec-packages@barretenberg-v0.51.0...barretenberg-v0.51.1) (2024-08-29) ### Features * **avm:** 1-slot sload/sstore (nr, ts) ([#8264](AztecProtocol/aztec-packages#8264)) ([bdd9b06](AztecProtocol/aztec-packages@bdd9b06)) * **avm:** Range check gadget ([#7967](AztecProtocol/aztec-packages#7967)) ([0dd954e](AztecProtocol/aztec-packages@0dd954e)) * Proof surgery class ([#8236](AztecProtocol/aztec-packages#8236)) ([10d7edd](AztecProtocol/aztec-packages@10d7edd)) ### Bug Fixes * **bb-prover:** Create structure for AVM vk ([#8233](AztecProtocol/aztec-packages#8233)) ([55b6ba2](AztecProtocol/aztec-packages@55b6ba2)) * **bb:** Mac build ([#8255](AztecProtocol/aztec-packages#8255)) ([ac54f5c](AztecProtocol/aztec-packages@ac54f5c)) * Handle constant output for sha256 ([#8251](AztecProtocol/aztec-packages#8251)) ([0653ba5](AztecProtocol/aztec-packages@0653ba5)) ### Miscellaneous * **avm:** Replace range and cmp with gadgets ([#8164](AztecProtocol/aztec-packages#8164)) ([cc12558](AztecProtocol/aztec-packages@cc12558)) * **bb:** Use std::span in pippenger for scalars ([#8269](AztecProtocol/aztec-packages#8269)) ([2323cd5](AztecProtocol/aztec-packages@2323cd5)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

chore: Less noisy AVM failures in proving

efaa4b7

If AVM fails to prove and AVM_PROVING_STRICT is not set, do not log an error.

PhilWindle approved these changes Aug 27, 2024

View reviewed changes

spalladino enabled auto-merge (squash) August 27, 2024 18:52

spalladino merged commit 03bcd62 into master Aug 27, 2024
98 checks passed

spalladino deleted the palla/less-noisy-avm branch August 27, 2024 18:57

alexghr approved these changes Aug 27, 2024

View reviewed changes

AztecBot mentioned this pull request Aug 27, 2024

chore(master): Release 0.51.1 #8218

Merged

spalladino added a commit that referenced this pull request Aug 27, 2024

chore: Less noisy AVM failures in proving (#8227)

8c0306d

If AVM fails to prove and AVM_PROVING_STRICT is not set, do not log an error.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Less noisy AVM failures in proving #8227

chore: Less noisy AVM failures in proving #8227

spalladino commented Aug 27, 2024

spalladino commented Aug 27, 2024

AztecBot commented Aug 27, 2024

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

alexghr Aug 27, 2024

chore: Less noisy AVM failures in proving #8227

chore: Less noisy AVM failures in proving #8227

Conversation

spalladino commented Aug 27, 2024

spalladino commented Aug 27, 2024

AztecBot commented Aug 27, 2024

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

alexghr Aug 27, 2024

Choose a reason for hiding this comment