feat(avm): range check gadget #7967

IlyasRidhuan · 2024-08-14T11:03:51Z

This doesnt replace the existing range check - this just sets up the initial work for a range check gadget

IlyasRidhuan · 2024-08-14T11:04:05Z

feat(avm): integrate new range and cmp gadgets #8165
refactor(avm): replace range and cmp with gadgets #8164
feat(avm): range check gadget #7967 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @IlyasRidhuan and the rest of your teammates on Graphite

AztecBot · 2024-08-14T11:41:25Z

Benchmark results

Metrics with a significant change:

avm_simulation_time_ms (Token:mint_public): 68.5 (+52%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 40.2 (-39%)
avm_simulation_time_ms (Token:transfer_public): 31.2 (+53%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,764	1,564	714	783 (+3%)	781 (+1%)
proof_construction_time_sha256_30_ms	11,499	3,093	1,381	1,433 (+2%)	1,454
proof_construction_time_sha256_100_ms	44,283	11,790	5,442	5,629 (+2%)	5,748 (+1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	58.0 (-3%)	88.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,529	422	202 (-1%)	223 (+1%)	279 (+4%)
proof_construction_time_poseidon_hash_100_ms	5,641	1,507	676 (-2%)	725	750 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,148	93,018	178,228
l1_rollup_execution_gas	842,808	1,576,574	3,361,840
l2_block_processing_time_in_ms	252 (-4%)	454	827 (-1%)
l2_block_building_time_in_ms	11,362	22,212	44,538
l2_block_rollup_simulation_time_in_ms	11,362	22,212	44,537
l2_block_public_tx_process_time_in_ms	9,616 (-1%)	20,409	42,697

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,028 (-2%)	3,991 (+2%)
node_database_size_in_bytes	12,619,856	16,728,144
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	96.5 (+6%)	388 (-2%)	21,735	44,860	N/A
private-kernel-inner	176 (+3%)	683 (-2%)	72,544	45,007	N/A
private-kernel-reset-tiny	308	693 (-3%)	65,593	44,846	N/A
private-kernel-tail	167 (+1%)	132 (-5%)	50,644	52,257	N/A
base-parity	5.55 (-1%)	N/A	160	96.0	N/A
root-parity	35.4	N/A	73,948	96.0	N/A
base-rollup	3,449	N/A	189,136	664	N/A
block-root-rollup	41.1 (-1%)	N/A	58,205	2,448	N/A
public-kernel-setup	85.4 (+1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	97.2 (+1%)	N/A	104,911	71,222	N/A
public-kernel-tail	856	N/A	390,582	16,414	N/A
private-kernel-reset-small	309 (-1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	1,370	598 (-3%)	455,400	1,825	N/A
public-kernel-teardown	83.6 (-1%)	N/A	105,349	71,222	N/A
merge-rollup	20.3 (+1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	84,193 (+7%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	340 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.0 (-2%)
MultiCallEntrypoint:entrypoint	1,920	11,731	401 (-1%)
FeeJuice:deploy	1,376	11,731	384 (-2%)
SchnorrAccount:constructor	1,312	11,731	72.9 (-1%)
SchnorrAccount:entrypoint	2,304	11,731	392 (-1%)
Token:privately_mint_private_note	1,280	11,731	110 (+8%)
FPC:fee_entrypoint_public	1,344	11,731	26.6 (-11%)
Token:transfer	1,312	11,731	221 (-3%)
Benchmarking:create_note	1,344	11,731	85.7
SchnorrAccount:verify_private_authwit	1,280	11,731	27.7
Token:unshield	1,376	11,731	521 (-1%)
FPC:fee_entrypoint_private	1,376	11,731	697 (-2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	59.5 (-9%)	7,101
FeeJuice:set_portal	11.9 (+19%)	2,128
Token:constructor	80.8	25,285
FPC:constructor	54.7	17,853
FeeJuice:mint_public	41.9 (+5%)	5,415
Token:mint_public	⚠️ 68.5 (+52%)	10,101
Token:assert_minter_and_mint	⚠️ 40.2 (-39%)	6,844
AuthRegistry:set_authorized	47.1 (+15%)	3,969
FPC:prepare_fee	228 (-2%)	6,747
Token:transfer_public	⚠️ 31.2 (+53%)	38,126
FPC:pay_refund	49.5	9,398
Benchmarking:increment_balance	1,197	6,179
Token:_increase_public_balance	42.4 (+6%)	7,705
FPC:pay_refund_with_shielded_rebate	62.2 (-3%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.161 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.16 (-2%)	3.91 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.112 (-2%)	0.111 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.1 (-3%)	17.6 (-3%)	31.5 (-2%)	58.8 (-1%)	114 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.107 (-3%)	0.103 (-2%)	0.102 (-2%)	0.101 (-1%)	0.102 (-2%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.1 (-2%)	25.6 (-2%)	44.5 (-1%)	82.5 (-1%)	162 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.107 (-2%)	0.103 (-1%)	0.108 (-1%)	0.102	0.103 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (-2%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

IlyasRidhuan · 2024-08-14T13:24:53Z

barretenberg/cpp/src/barretenberg/vm/avm/trace/gadgets/range_check.hpp

+#include "barretenberg/vm/avm/trace/common.hpp"
+#include <cstdint>
+
+enum class EventEmitter {


Not using this right now, but when i start integrating, we will need this info to set selectors for inter-trace comms

IlyasRidhuan · 2024-08-14T13:25:20Z

barretenberg/cpp/pil/avm/gadgets/range_check.pil

+    sel_lookup_5 - (is_lte_u112 + is_lte_u128) = 0;
+    sel_lookup_6 - is_lte_u128 = 0;
+
+    #[LOOKUP_RNG_CHK_0]


I'll replace all of these with the ones in main when integration happens

jeanmon

Good overall. Please look at the comments and iron out a proof to ensure that the relations are fully constrained.

barretenberg/cpp/pil/avm/gadgets/range_check.pil

barretenberg/cpp/src/barretenberg/vm/avm/trace/gadgets/range_check.hpp

fcarreiro · 2024-08-15T12:44:59Z

barretenberg/cpp/src/barretenberg/vm/avm/trace/gadgets/range_check.hpp

+        std::array<uint16_t, 7> fixed_slice_registers;
+        uint16_t dynamic_slice_register;
+        // The number of bits that need to be dynamically checked
+        uint16_t dyn_bits;
+        // The difference between
+        uint16_t dyn_diff;
+        // Bit string representing which of the is_lte_x flags are on
+        // From LSB to MSB:
+        // [is_lte_u16, is_lte_u32, is_lte_u48, is_lte_u64, is_lte_u80, is_lte_u96, is_lte_u112, is_lte_u128]
+        uint8_t bit_range_flag;


Do you need all this or can you have less and syntehsize the rest in finalize()? (see my binary/etc prs)

fcarreiro · 2024-08-15T12:46:45Z

barretenberg/cpp/src/barretenberg/vm/avm/trace/gadgets/range_check.hpp

+                // The most significant 16-bits have to be placed in the dynamic slice register
+                if (event.num_bits <= 16) {
+                    entry.dynamic_slice_register = uint16_t(value_u256);
+                    u16_range_chk_counters[7][entry.dynamic_slice_register]++;


We discussed about separating finalize and counters, it might be needed.

Also, consider using the "new" pattern I'm establishing of having finalize take the main trace and return nothing (I had to do it because some trace was using shifts -- gas -- and I needed to set something on the current and next row).

fcarreiro · 2024-08-15T12:47:35Z

barretenberg/cpp/src/barretenberg/vm/avm/trace/gadgets/range_check.hpp

Please do move everything you can to a cpp file. Should be possible to move everything except for the merge_into; or everything if you take std::vector<AvmFullRow<FF>> in finalize.

barretenberg/cpp/src/barretenberg/vm/avm/tests/range_check.test.cpp

fcarreiro · 2024-08-15T12:50:39Z

barretenberg/cpp/src/barretenberg/vm/avm/tests/range_check.test.cpp

+        .beta = beta,
+        .gamma = gamma,
+    };
+    bb::constexpr_for<0, std::tuple_size_v<AllLookupRelations>, 1>([&]<size_t i>() {


This is ok for now, at some point I'll just create helpers to do this for us.

Definitely if we want proper unit tests per trace we need to code generate checks pertaining to a trace. I prefer not have such code introduced like this.

jeanmon · 2024-08-22T08:18:00Z

barretenberg/cpp/pil/avm/gadgets/range_check.pil

+    pol commit rng_chk_bits;
+
+    // Bit Size Columns
+    // It is enforced (further down) that the selected column is the lowest multiple of 16 that is greater than rng_chk_bits 


@IlyasRidhuan " ... the lowest multiple of 16 that is greater than rng_chk_bits " I think you meant "greater or equal".
A 128-bit range check is allowed and in this case is_lte_u128 would be 1.

jeanmon · 2024-08-22T08:21:03Z

barretenberg/cpp/pil/avm/gadgets/range_check.pil

+    // This register has a (more expensive) set of constraint that enables dynamic range check of bit values between 0 and 16 bits
+    pol commit u16_r7;
+
+    // In each of these relations, the u16_r7 register contains the most significant 16 bits of value.


@IlyasRidhuan "the most significant 16 bits of value." You meant after zero padding on the higher bits to express value with a number of bits which is defined by is_lte_XXX

barretenberg/cpp/src/barretenberg/vm/avm/trace/gadgets/range_check.hpp

IlyasRidhuan · 2024-08-29T17:34:00Z

Merge activity

Aug 29, 1:34 PM EDT: @IlyasRidhuan started a stack merge that includes this pull request via Graphite.
Aug 29, 1:34 PM EDT: @IlyasRidhuan merged this pull request with Graphite.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.51.1</summary> ## [0.51.1](aztec-package-v0.51.0...aztec-package-v0.51.1) (2024-08-29) ### Features * Add status check to prover agent ([#8248](#8248)) ([7b3006a](7b3006a)) * Faster L1 deployment ([#8234](#8234)) ([51d6699](51d6699)) * Spartan token transfer ([#8163](#8163)) ([38f0157](38f0157)) </details> <details><summary>barretenberg.js: 0.51.1</summary> ## [0.51.1](barretenberg.js-v0.51.0...barretenberg.js-v0.51.1) (2024-08-29) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.51.1</summary> ## [0.51.1](aztec-packages-v0.51.0...aztec-packages-v0.51.1) (2024-08-29) ### Features * Add CLI command for gathering proving metrics ([#8221](#8221)) ([5929a42](5929a42)) * Add status check to prover agent ([#8248](#8248)) ([7b3006a](7b3006a)) * **avm:** 1-slot sload/sstore (nr, ts) ([#8264](#8264)) ([bdd9b06](bdd9b06)) * **avm:** Range check gadget ([#7967](#7967)) ([0dd954e](0dd954e)) * **docs:** Add partial notes doc ([#8192](#8192)) ([4299bbd](4299bbd)) * Faster L1 deployment ([#8234](#8234)) ([51d6699](51d6699)) * Initial validator set ([#8133](#8133)) ([6d31ad2](6d31ad2)) * L1-publisher cleanup ([#8148](#8148)) ([6ae2535](6ae2535)) * Proof surgery class ([#8236](#8236)) ([10d7edd](10d7edd)) * Request specific transactions through the p2p layer ([#8185](#8185)) ([54e1cc7](54e1cc7)) * Slot duration flexibility ([#8122](#8122)) ([708e4e5](708e4e5)) * Spartan token transfer ([#8163](#8163)) ([38f0157](38f0157)) ### Bug Fixes * Attempt to fix nightly test ([#8222](#8222)) ([477eec5](477eec5)) * **avm-simulator:** Await avm bytecode check ([#8268](#8268)) ([4410eb3](4410eb3)) * **bb-prover:** Create structure for AVM vk ([#8233](#8233)) ([55b6ba2](55b6ba2)) * **bb:** Mac build ([#8255](#8255)) ([ac54f5c](ac54f5c)) * **ci:** Spot-runner-action was not built ([#8274](#8274)) ([c1509c1](c1509c1)) * **ci:** Try fix brotli edge-case ([#8256](#8256)) ([e03ea0b](e03ea0b)) * Docker containers healthchecks ([#8228](#8228)) ([19edbbb](19edbbb)) * **docs:** Update entrypoint details on accounts page ([#8184](#8184)) ([8453ec7](8453ec7)) * Export brillig names in contract functions ([#8212](#8212)) ([4745741](4745741)) * Fixes for the nightly test run against Sepolia ([#8229](#8229)) ([cfc65c6](cfc65c6)) * Handle constant output for sha256 ([#8251](#8251)) ([0653ba5](0653ba5)) * Log public vm errors as warn in prover-agent ([#8247](#8247)) ([9f4ea9f](9f4ea9f)) * Remove devnet ARM builds for now ([#8202](#8202)) ([81ef715](81ef715)) * Remove fundFpc step from bootstrap ([#8245](#8245)) ([a742531](a742531)) * Ts codegen ([#8267](#8267)) ([cb58800](cb58800)) ### Miscellaneous * Add check to just release images to devnet-deploys ([#8242](#8242)) ([aa6791d](aa6791d)) * Add partial note support for value note ([#8141](#8141)) ([daa57cc](daa57cc)) * Always run `build-check` step in `publish-bb.yml` ([#8240](#8240)) ([5e9749f](5e9749f)) * **avm:** Replace range and cmp with gadgets ([#8164](#8164)) ([cc12558](cc12558)) * Basic network matrix ([#8257](#8257)) ([2a76b1a](2a76b1a)), closes [#8001](#8001) * **bb:** Use std::span in pippenger for scalars ([#8269](#8269)) ([2323cd5](2323cd5)) * Configure interval mining for anvil ([#8211](#8211)) ([eba57b4](eba57b4)) * Create external-ci-approved.yml ([#8235](#8235)) ([24b059b](24b059b)) * Disallow prune in devnet + add onlyOwners ([#8134](#8134)) ([c736f96](c736f96)) * Fix various warnings in noir code ([#8258](#8258)) ([1c6b478](1c6b478)) * Less noisy AVM failures in proving ([#8227](#8227)) ([03bcd62](03bcd62)) * Open an issue if publishing bb fails ([#8223](#8223)) ([2d7a775](2d7a775)) * Reinstate l1-contracts package ([#8250](#8250)) ([263a912](263a912)) * Remove unused generic parameters ([#8249](#8249)) ([00ed045](00ed045)) * Replace relative paths to noir-protocol-circuits ([1783c80](1783c80)) * Replace relative paths to noir-protocol-circuits ([ffe1f35](ffe1f35)) * Report prover metrics ([#8155](#8155)) ([dc7bcdf](dc7bcdf)), closes [#7675](#7675) * Rework balances map ([#8127](#8127)) ([1cac3dd](1cac3dd)), closes [#8104](#8104) * Run CI after merges to provernet ([#8244](#8244)) ([97e5e25](97e5e25)) ### Documentation * Minor fixes ([#8273](#8273)) ([2b8af9e](2b8af9e)) </details> <details><summary>barretenberg: 0.51.1</summary> ## [0.51.1](barretenberg-v0.51.0...barretenberg-v0.51.1) (2024-08-29) ### Features * **avm:** 1-slot sload/sstore (nr, ts) ([#8264](#8264)) ([bdd9b06](bdd9b06)) * **avm:** Range check gadget ([#7967](#7967)) ([0dd954e](0dd954e)) * Proof surgery class ([#8236](#8236)) ([10d7edd](10d7edd)) ### Bug Fixes * **bb-prover:** Create structure for AVM vk ([#8233](#8233)) ([55b6ba2](55b6ba2)) * **bb:** Mac build ([#8255](#8255)) ([ac54f5c](ac54f5c)) * Handle constant output for sha256 ([#8251](#8251)) ([0653ba5](0653ba5)) ### Miscellaneous * **avm:** Replace range and cmp with gadgets ([#8164](#8164)) ([cc12558](cc12558)) * **bb:** Use std::span in pippenger for scalars ([#8269](#8269)) ([2323cd5](2323cd5)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.51.1</summary> ## [0.51.1](AztecProtocol/aztec-packages@aztec-package-v0.51.0...aztec-package-v0.51.1) (2024-08-29) ### Features * Add status check to prover agent ([#8248](AztecProtocol/aztec-packages#8248)) ([7b3006a](AztecProtocol/aztec-packages@7b3006a)) * Faster L1 deployment ([#8234](AztecProtocol/aztec-packages#8234)) ([51d6699](AztecProtocol/aztec-packages@51d6699)) * Spartan token transfer ([#8163](AztecProtocol/aztec-packages#8163)) ([38f0157](AztecProtocol/aztec-packages@38f0157)) </details> <details><summary>barretenberg.js: 0.51.1</summary> ## [0.51.1](AztecProtocol/aztec-packages@barretenberg.js-v0.51.0...barretenberg.js-v0.51.1) (2024-08-29) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.51.1</summary> ## [0.51.1](AztecProtocol/aztec-packages@aztec-packages-v0.51.0...aztec-packages-v0.51.1) (2024-08-29) ### Features * Add CLI command for gathering proving metrics ([#8221](AztecProtocol/aztec-packages#8221)) ([5929a42](AztecProtocol/aztec-packages@5929a42)) * Add status check to prover agent ([#8248](AztecProtocol/aztec-packages#8248)) ([7b3006a](AztecProtocol/aztec-packages@7b3006a)) * **avm:** 1-slot sload/sstore (nr, ts) ([#8264](AztecProtocol/aztec-packages#8264)) ([bdd9b06](AztecProtocol/aztec-packages@bdd9b06)) * **avm:** Range check gadget ([#7967](AztecProtocol/aztec-packages#7967)) ([0dd954e](AztecProtocol/aztec-packages@0dd954e)) * **docs:** Add partial notes doc ([#8192](AztecProtocol/aztec-packages#8192)) ([4299bbd](AztecProtocol/aztec-packages@4299bbd)) * Faster L1 deployment ([#8234](AztecProtocol/aztec-packages#8234)) ([51d6699](AztecProtocol/aztec-packages@51d6699)) * Initial validator set ([#8133](AztecProtocol/aztec-packages#8133)) ([6d31ad2](AztecProtocol/aztec-packages@6d31ad2)) * L1-publisher cleanup ([#8148](AztecProtocol/aztec-packages#8148)) ([6ae2535](AztecProtocol/aztec-packages@6ae2535)) * Proof surgery class ([#8236](AztecProtocol/aztec-packages#8236)) ([10d7edd](AztecProtocol/aztec-packages@10d7edd)) * Request specific transactions through the p2p layer ([#8185](AztecProtocol/aztec-packages#8185)) ([54e1cc7](AztecProtocol/aztec-packages@54e1cc7)) * Slot duration flexibility ([#8122](AztecProtocol/aztec-packages#8122)) ([708e4e5](AztecProtocol/aztec-packages@708e4e5)) * Spartan token transfer ([#8163](AztecProtocol/aztec-packages#8163)) ([38f0157](AztecProtocol/aztec-packages@38f0157)) ### Bug Fixes * Attempt to fix nightly test ([#8222](AztecProtocol/aztec-packages#8222)) ([477eec5](AztecProtocol/aztec-packages@477eec5)) * **avm-simulator:** Await avm bytecode check ([#8268](AztecProtocol/aztec-packages#8268)) ([4410eb3](AztecProtocol/aztec-packages@4410eb3)) * **bb-prover:** Create structure for AVM vk ([#8233](AztecProtocol/aztec-packages#8233)) ([55b6ba2](AztecProtocol/aztec-packages@55b6ba2)) * **bb:** Mac build ([#8255](AztecProtocol/aztec-packages#8255)) ([ac54f5c](AztecProtocol/aztec-packages@ac54f5c)) * **ci:** Spot-runner-action was not built ([#8274](AztecProtocol/aztec-packages#8274)) ([c1509c1](AztecProtocol/aztec-packages@c1509c1)) * **ci:** Try fix brotli edge-case ([#8256](AztecProtocol/aztec-packages#8256)) ([e03ea0b](AztecProtocol/aztec-packages@e03ea0b)) * Docker containers healthchecks ([#8228](AztecProtocol/aztec-packages#8228)) ([19edbbb](AztecProtocol/aztec-packages@19edbbb)) * **docs:** Update entrypoint details on accounts page ([#8184](AztecProtocol/aztec-packages#8184)) ([8453ec7](AztecProtocol/aztec-packages@8453ec7)) * Export brillig names in contract functions ([#8212](AztecProtocol/aztec-packages#8212)) ([4745741](AztecProtocol/aztec-packages@4745741)) * Fixes for the nightly test run against Sepolia ([#8229](AztecProtocol/aztec-packages#8229)) ([cfc65c6](AztecProtocol/aztec-packages@cfc65c6)) * Handle constant output for sha256 ([#8251](AztecProtocol/aztec-packages#8251)) ([0653ba5](AztecProtocol/aztec-packages@0653ba5)) * Log public vm errors as warn in prover-agent ([#8247](AztecProtocol/aztec-packages#8247)) ([9f4ea9f](AztecProtocol/aztec-packages@9f4ea9f)) * Remove devnet ARM builds for now ([#8202](AztecProtocol/aztec-packages#8202)) ([81ef715](AztecProtocol/aztec-packages@81ef715)) * Remove fundFpc step from bootstrap ([#8245](AztecProtocol/aztec-packages#8245)) ([a742531](AztecProtocol/aztec-packages@a742531)) * Ts codegen ([#8267](AztecProtocol/aztec-packages#8267)) ([cb58800](AztecProtocol/aztec-packages@cb58800)) ### Miscellaneous * Add check to just release images to devnet-deploys ([#8242](AztecProtocol/aztec-packages#8242)) ([aa6791d](AztecProtocol/aztec-packages@aa6791d)) * Add partial note support for value note ([#8141](AztecProtocol/aztec-packages#8141)) ([daa57cc](AztecProtocol/aztec-packages@daa57cc)) * Always run `build-check` step in `publish-bb.yml` ([#8240](AztecProtocol/aztec-packages#8240)) ([5e9749f](AztecProtocol/aztec-packages@5e9749f)) * **avm:** Replace range and cmp with gadgets ([#8164](AztecProtocol/aztec-packages#8164)) ([cc12558](AztecProtocol/aztec-packages@cc12558)) * Basic network matrix ([#8257](AztecProtocol/aztec-packages#8257)) ([2a76b1a](AztecProtocol/aztec-packages@2a76b1a)), closes [#8001](AztecProtocol/aztec-packages#8001) * **bb:** Use std::span in pippenger for scalars ([#8269](AztecProtocol/aztec-packages#8269)) ([2323cd5](AztecProtocol/aztec-packages@2323cd5)) * Configure interval mining for anvil ([#8211](AztecProtocol/aztec-packages#8211)) ([eba57b4](AztecProtocol/aztec-packages@eba57b4)) * Create external-ci-approved.yml ([#8235](AztecProtocol/aztec-packages#8235)) ([24b059b](AztecProtocol/aztec-packages@24b059b)) * Disallow prune in devnet + add onlyOwners ([#8134](AztecProtocol/aztec-packages#8134)) ([c736f96](AztecProtocol/aztec-packages@c736f96)) * Fix various warnings in noir code ([#8258](AztecProtocol/aztec-packages#8258)) ([1c6b478](AztecProtocol/aztec-packages@1c6b478)) * Less noisy AVM failures in proving ([#8227](AztecProtocol/aztec-packages#8227)) ([03bcd62](AztecProtocol/aztec-packages@03bcd62)) * Open an issue if publishing bb fails ([#8223](AztecProtocol/aztec-packages#8223)) ([2d7a775](AztecProtocol/aztec-packages@2d7a775)) * Reinstate l1-contracts package ([#8250](AztecProtocol/aztec-packages#8250)) ([263a912](AztecProtocol/aztec-packages@263a912)) * Remove unused generic parameters ([#8249](AztecProtocol/aztec-packages#8249)) ([00ed045](AztecProtocol/aztec-packages@00ed045)) * Replace relative paths to noir-protocol-circuits ([1783c80](AztecProtocol/aztec-packages@1783c80)) * Replace relative paths to noir-protocol-circuits ([ffe1f35](AztecProtocol/aztec-packages@ffe1f35)) * Report prover metrics ([#8155](AztecProtocol/aztec-packages#8155)) ([dc7bcdf](AztecProtocol/aztec-packages@dc7bcdf)), closes [#7675](AztecProtocol/aztec-packages#7675) * Rework balances map ([#8127](AztecProtocol/aztec-packages#8127)) ([1cac3dd](AztecProtocol/aztec-packages@1cac3dd)), closes [#8104](AztecProtocol/aztec-packages#8104) * Run CI after merges to provernet ([#8244](AztecProtocol/aztec-packages#8244)) ([97e5e25](AztecProtocol/aztec-packages@97e5e25)) ### Documentation * Minor fixes ([#8273](AztecProtocol/aztec-packages#8273)) ([2b8af9e](AztecProtocol/aztec-packages@2b8af9e)) </details> <details><summary>barretenberg: 0.51.1</summary> ## [0.51.1](AztecProtocol/aztec-packages@barretenberg-v0.51.0...barretenberg-v0.51.1) (2024-08-29) ### Features * **avm:** 1-slot sload/sstore (nr, ts) ([#8264](AztecProtocol/aztec-packages#8264)) ([bdd9b06](AztecProtocol/aztec-packages@bdd9b06)) * **avm:** Range check gadget ([#7967](AztecProtocol/aztec-packages#7967)) ([0dd954e](AztecProtocol/aztec-packages@0dd954e)) * Proof surgery class ([#8236](AztecProtocol/aztec-packages#8236)) ([10d7edd](AztecProtocol/aztec-packages@10d7edd)) ### Bug Fixes * **bb-prover:** Create structure for AVM vk ([#8233](AztecProtocol/aztec-packages#8233)) ([55b6ba2](AztecProtocol/aztec-packages@55b6ba2)) * **bb:** Mac build ([#8255](AztecProtocol/aztec-packages#8255)) ([ac54f5c](AztecProtocol/aztec-packages@ac54f5c)) * Handle constant output for sha256 ([#8251](AztecProtocol/aztec-packages#8251)) ([0653ba5](AztecProtocol/aztec-packages@0653ba5)) ### Miscellaneous * **avm:** Replace range and cmp with gadgets ([#8164](AztecProtocol/aztec-packages#8164)) ([cc12558](AztecProtocol/aztec-packages@cc12558)) * **bb:** Use std::span in pippenger for scalars ([#8269](AztecProtocol/aztec-packages#8269)) ([2323cd5](AztecProtocol/aztec-packages@2323cd5)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* master: (28 commits) chore: bump noir-bignum to 0.3.2 (#8276) feat: Populate epoch 0 from initial validator set (#8286) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg chore(master): Release 0.51.1 (#8218) feat(avm): integrate new range and cmp gadgets (#8165) chore: rename process to propose for clarity (#8265) chore: Bump provernet agents to 8 and speed up bot (#8280) feat(avm): avm recursive verifier cpp (#8162) feat: moving fee payout + make proof submission sequential (#8262) feat: Block cheat codes in anvil (#8277) feat: wallet tx management (#8246) refactor(avm): replace range and cmp with gadgets (#8164) fix(docs): Update entrypoint details on accounts page (#8184) feat: l1-publisher cleanup (#8148) feat(avm): range check gadget (#7967) fix(ci): spot-runner-action was not built (#8274) fix: ts codegen (#8267) ...

This doesnt replace the existing range check - this just sets up the initial work for a range check gadget

IlyasRidhuan force-pushed the ir/08-06-feat_avm_range_check_gadget branch from 19ae9b7 to a4c2681 Compare August 14, 2024 12:42

IlyasRidhuan marked this pull request as ready for review August 14, 2024 13:23

IlyasRidhuan requested review from jeanmon, fcarreiro and Maddiaa0 as code owners August 14, 2024 13:23

IlyasRidhuan commented Aug 14, 2024

View reviewed changes

jeanmon approved these changes Aug 14, 2024

View reviewed changes

IlyasRidhuan force-pushed the ir/08-06-feat_avm_range_check_gadget branch from a4c2681 to 1ff04b5 Compare August 15, 2024 11:37

fcarreiro reviewed Aug 15, 2024

View reviewed changes

jeanmon reviewed Aug 22, 2024

View reviewed changes

barretenberg/cpp/src/barretenberg/vm/avm/trace/gadgets/range_check.hpp Show resolved Hide resolved

IlyasRidhuan force-pushed the ir/08-06-feat_avm_range_check_gadget branch from 1ff04b5 to 7322530 Compare August 23, 2024 15:48

This was referenced Aug 23, 2024

refactor(avm): replace range and cmp with gadgets #8164

Merged

feat(avm): integrate new range and cmp gadgets #8165

Merged

IlyasRidhuan force-pushed the ir/08-06-feat_avm_range_check_gadget branch 4 times, most recently from 332f078 to 534ec0a Compare August 28, 2024 16:01

feat(avm): range check gadget

0ea2110

IlyasRidhuan force-pushed the ir/08-06-feat_avm_range_check_gadget branch from 534ec0a to 0ea2110 Compare August 29, 2024 09:40

IlyasRidhuan merged commit 0dd954e into master Aug 29, 2024
100 checks passed

IlyasRidhuan deleted the ir/08-06-feat_avm_range_check_gadget branch August 29, 2024 17:34

AztecBot mentioned this pull request Aug 29, 2024

chore(master): Release 0.51.1 #8218

Merged

codygunton pushed a commit that referenced this pull request Aug 30, 2024

feat(avm): range check gadget (#7967)

82bd181

This doesnt replace the existing range check - this just sets up the initial work for a range check gadget

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm): range check gadget #7967

feat(avm): range check gadget #7967

IlyasRidhuan commented Aug 14, 2024 •

edited

Loading

IlyasRidhuan commented Aug 14, 2024 •

edited

Loading

AztecBot commented Aug 14, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

IlyasRidhuan Aug 14, 2024

IlyasRidhuan Aug 14, 2024

jeanmon left a comment

fcarreiro Aug 15, 2024

fcarreiro Aug 15, 2024

fcarreiro Aug 15, 2024

fcarreiro Aug 15, 2024

jeanmon Aug 22, 2024

jeanmon Aug 22, 2024 •

edited

Loading

jeanmon Aug 22, 2024 •

edited

Loading

IlyasRidhuan commented Aug 29, 2024 •

edited

Loading

feat(avm): range check gadget #7967

feat(avm): range check gadget #7967

Conversation

IlyasRidhuan commented Aug 14, 2024 • edited Loading

IlyasRidhuan commented Aug 14, 2024 • edited Loading

AztecBot commented Aug 14, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

IlyasRidhuan Aug 14, 2024

Choose a reason for hiding this comment

IlyasRidhuan Aug 14, 2024

Choose a reason for hiding this comment

jeanmon left a comment

Choose a reason for hiding this comment

fcarreiro Aug 15, 2024

Choose a reason for hiding this comment

fcarreiro Aug 15, 2024

Choose a reason for hiding this comment

fcarreiro Aug 15, 2024

Choose a reason for hiding this comment

fcarreiro Aug 15, 2024

Choose a reason for hiding this comment

jeanmon Aug 22, 2024

Choose a reason for hiding this comment

jeanmon Aug 22, 2024 • edited Loading

Choose a reason for hiding this comment

jeanmon Aug 22, 2024 • edited Loading

Choose a reason for hiding this comment

IlyasRidhuan commented Aug 29, 2024 • edited Loading

Merge activity

IlyasRidhuan commented Aug 14, 2024 •

edited

Loading

IlyasRidhuan commented Aug 14, 2024 •

edited

Loading

AztecBot commented Aug 14, 2024 •

edited

Loading

jeanmon Aug 22, 2024 •

edited

Loading

jeanmon Aug 22, 2024 •

edited

Loading

IlyasRidhuan commented Aug 29, 2024 •

edited

Loading