Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet tx management #8246

Merged
merged 15 commits into from
Aug 29, 2024
Merged

feat: wallet tx management #8246

merged 15 commits into from
Aug 29, 2024

Conversation

Thunkar
Copy link
Contributor

@Thunkar Thunkar commented Aug 28, 2024

This PR introduces the concept of cancellable transactions. It is now possible to send a TX as cancellable, which will output an extra nullifier in the entrypoint function using the tx nonce and a dedicated generator.

A subsequent transaction with the same nonce but an empty payload and a higher fee should then picked up by the sequencer, making the original one fail due to the duplicate nullifier. This is not yet implemented in the sequencer and kinda difficult to test at the moment.

New commands

  • get-tx [txHash]: Poor's man tx inspector/history. Provides a list of recent transactions (supports pagination), their aliases and status. Providing a txHash will inspect it in more detail.
Screenshot 2024-08-29 at 12 22 13
  • cancel-tx <txHash>: Cancels a previous transaction (provided it was done via the same wallet and we have the fee info) via its txHash (or alias), using a multiplier to the inclusionFee of the original tx.

Fixes

  • Should fix earthly compilation for devnet builds

@Thunkar Thunkar self-assigned this Aug 28, 2024
@AztecBot
Copy link
Collaborator

AztecBot commented Aug 28, 2024

Benchmark results

Metrics with a significant change:

  • avm_simulation_time_ms (FeeJuice:mint_public): 40.0 (-81%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,766 1,562 713 756 (-1%) 777 (+1%)
proof_construction_time_sha256_30_ms 11,487 3,091 1,381 1,438 (+1%) 1,466 (+1%)
proof_construction_time_sha256_100_ms 44,087 11,850 5,449 (+1%) 5,510 (+1%) 5,647 (-1%)
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 59.0 (+2%) 87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms 1,528 421 202 230 (+3%) 266
proof_construction_time_poseidon_hash_100_ms 5,639 1,515 681 (+1%) 730 (+3%) 746 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 4,356 7,876 14,884
l1_rollup_calldata_gas 50,184 92,972 177,712
l1_rollup_execution_gas 845,730 1,579,414 3,364,210
l2_block_processing_time_in_ms 257 (-4%) 450 (-1%) 810 (-11%)
l2_block_building_time_in_ms 11,413 22,311 44,462 (-1%)
l2_block_rollup_simulation_time_in_ms 11,412 22,311 44,461 (-1%)
l2_block_public_tx_process_time_in_ms 9,743 20,612 42,719 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 3,088 (+4%) 3,870 (-1%)
node_database_size_in_bytes 12,664,912 16,724,048
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms input_size_in_bytes output_size_in_bytes proving_time_in_ms
private-kernel-init 91.7 398 (+1%) 21,735 44,860 N/A
private-kernel-inner 189 (+7%) 706 (+1%) 72,544 45,007 N/A
private-kernel-reset-tiny 307 (-2%) 716 (-1%) 65,593 44,846 N/A
private-kernel-tail 166 (-1%) 136 (-1%) 50,644 52,257 N/A
base-parity 5.66 (+1%) N/A 160 96.0 N/A
root-parity 35.3 (-1%) N/A 73,948 96.0 N/A
base-rollup 2,960 (-2%) N/A 189,136 664 N/A
block-root-rollup 41.2 N/A 58,205 2,448 N/A
public-kernel-setup 84.9 (-1%) N/A 105,085 71,222 N/A
public-kernel-app-logic 97.5 N/A 104,911 71,222 N/A
public-kernel-tail 858 (-1%) N/A 390,582 16,414 N/A
private-kernel-reset-small 311 N/A 66,341 45,629 N/A
private-kernel-tail-to-public 677 (+2%) 616 (+1%) 455,400 1,825 N/A
public-kernel-teardown 85.7 (+2%) N/A 105,349 71,222 N/A
merge-rollup 20.0 (-1%) N/A 38,174 664 N/A
undefined N/A N/A N/A N/A 83,014 (+6%)

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms
ContractClassRegisterer:register 1,344 11,731 341 (-1%)
ContractInstanceDeployer:deploy 1,408 11,731 18.2
MultiCallEntrypoint:entrypoint 1,920 11,731 405
FeeJuice:deploy 1,376 11,731 386 (-2%)
SchnorrAccount:constructor 1,312 11,731 73.6
SchnorrAccount:entrypoint 2,336 (+1%) 11,731 394
Token:privately_mint_private_note 1,280 11,731 101 (-2%)
FPC:fee_entrypoint_public 1,344 11,731 26.6 (+3%)
Token:transfer 1,312 11,731 230
Benchmarking:create_note 1,344 11,731 86.9 (+2%)
SchnorrAccount:verify_private_authwit 1,280 11,731 27.5 (-16%)
Token:unshield 1,376 11,731 520 (-1%)
FPC:fee_entrypoint_private 1,376 11,731 693 (-1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
FeeJuice:_increase_public_balance 56.8 (-7%) 8,174
FeeJuice:set_portal 10.7 (-18%) 4,055
Token:constructor 84.2 29,082
FPC:constructor 53.6 (-1%) 18,940
FeeJuice:mint_public ⚠️ 40.0 (-81%) 6,522
Token:mint_public 321 (+1%) 12,704
Token:assert_minter_and_mint 44.5 (+4%) 8,467
AuthRegistry:set_authorized 49.6 (+2%) 4,194
FPC:prepare_fee 243 (-1%) 6,747
Token:transfer_public 37.3 (-1%) 39,863
FPC:pay_refund 62.1 (+13%) 9,398
Benchmarking:increment_balance 1,217 (-1%) 7,263
Token:_increase_public_balance 42.9 (-2%) 8,686
FPC:pay_refund_with_shielded_rebate 61.0 (-4%) 9,881

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.163 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 2.18 (-4%) 3.95 (-3%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.114 (-4%) 0.112 (-3%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 11.2 (-2%) 17.9 (-8%) 30.7 (-16%) 59.5 (-1%) 113 (-14%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.107 (-2%) 0.104 (-9%) 0.100 (-16%) 0.102 (-1%) 0.101 (-16%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 14.7 (-1%) 25.5 (-9%) 43.4 (-10%) 82.3 (-3%) 161 (-16%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.112 0.103 (-10%) 0.106 (-11%) 0.102 (-3%) 0.102 (-18%)
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 16.6 (-3%) N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 132 (-1%) N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.106 (-4%) N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 64,779 668,997

Transaction size based on fee payment method

| Metric | |
| - | |

@Thunkar Thunkar marked this pull request as ready for review August 29, 2024 10:13
@Thunkar Thunkar changed the title feat: cancellable transactions via dup nullifier feat: wallet tx management Aug 29, 2024
@Thunkar Thunkar requested a review from a team August 29, 2024 10:23
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let me know if you need help in handling this on the node side.

Copy link
Contributor

@sklppy88 sklppy88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work, have small qns, non blocking. 🙏 🚀

@Thunkar Thunkar merged commit 2cfe7cd into master Aug 29, 2024
99 checks passed
@Thunkar Thunkar deleted the gj/cancellable_transactions branch August 29, 2024 19:22
TomAFrench added a commit that referenced this pull request Aug 30, 2024
* master: (28 commits)
  chore: bump noir-bignum to 0.3.2 (#8276)
  feat: Populate epoch 0 from initial validator set (#8286)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  chore(master): Release 0.51.1 (#8218)
  feat(avm): integrate new range and cmp gadgets (#8165)
  chore: rename process to propose for clarity (#8265)
  chore: Bump provernet agents to 8 and speed up bot (#8280)
  feat(avm): avm recursive verifier cpp (#8162)
  feat: moving fee payout + make proof submission sequential (#8262)
  feat: Block cheat codes in anvil (#8277)
  feat: wallet tx management (#8246)
  refactor(avm): replace range and cmp with gadgets (#8164)
  fix(docs): Update entrypoint details on accounts page (#8184)
  feat: l1-publisher cleanup (#8148)
  feat(avm): range check gadget (#7967)
  fix(ci): spot-runner-action was not built (#8274)
  fix: ts codegen (#8267)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants