chore: remove unused generic parameters

[TomAFrench]

These generic parameters are not used by these functions so we can just remove them.

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 70.8 (+58%)
• avm_simulation_time_ms (Token:transfer_public): 32.0 (+49%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,754 (-3%)	1,559 (-3%)	715 (-2%)	769 (-3%)	776 (-2%)
proof_construction_time_sha256_30_ms	11,450 (-3%)	3,106 (-3%)	1,377 (-2%)	1,415 (-3%)	1,479 (-2%)
proof_construction_time_sha256_100_ms	44,114 (-3%)	11,839 (-2%)	5,435 (-2%)	5,686	5,721 (+1%)
proof_construction_time_poseidon_hash_ms	78.0 (-4%)	34.0 (-3%)	34.0 (-3%)	59.0 (+2%)	88.0 (-2%)
proof_construction_time_poseidon_hash_30_ms	1,527 (-3%)	421 (-3%)	202 (-2%)	229	269 (-3%)
proof_construction_time_poseidon_hash_100_ms	5,641 (-3%)	1,514 (-3%)	676 (-1%)	735 (-1%)	754 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,208	92,882	178,180
l1_rollup_execution_gas	842,868	1,576,438	3,361,792
l2_block_processing_time_in_ms	263 (+5%)	460 (+2%)	847
l2_block_building_time_in_ms	11,396	22,358	44,419 (-1%)
l2_block_rollup_simulation_time_in_ms	11,396	22,357	44,419 (-1%)
l2_block_public_tx_process_time_in_ms	9,695 (+1%)	20,531	42,559 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,062 (+1%)	4,115 (+4%)
node_database_size_in_bytes	12,632,144	16,740,432
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	98.9 (+3%)	399 (-4%)	21,735	44,860	N/A
private-kernel-inner	192 (+11%)	707 (+1%)	72,544	45,007	N/A
private-kernel-reset-tiny	314 (+2%)	723 (-1%)	65,593	44,846	N/A
private-kernel-tail	167	148 (+10%)	50,644	52,257	N/A
base-parity	5.64 (+1%)	N/A	160	96.0	N/A
root-parity	35.7	N/A	73,948	96.0	N/A
base-rollup	3,452	N/A	189,136	664	N/A
block-root-rollup	41.5	N/A	58,205	2,448	N/A
public-kernel-setup	85.9 (+1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	98.3 (+1%)	N/A	104,911	71,222	N/A
public-kernel-tail	861 (-1%)	N/A	390,582	16,414	N/A
private-kernel-reset-small	312 (+1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	1,406	618 (+1%)	455,400	1,825	N/A
public-kernel-teardown	84.3	N/A	105,349	71,222	N/A
merge-rollup	20.4 (-1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	77,526 (-1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	341 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.5
MultiCallEntrypoint:entrypoint	1,920	11,731	405
FeeJuice:deploy	1,376	11,731	393 (+1%)
SchnorrAccount:constructor	1,312	11,731	73.6
SchnorrAccount:entrypoint	2,304	11,731	395
Token:privately_mint_private_note	1,280	11,731	106
FPC:fee_entrypoint_public	1,344	11,731	25.9 (-8%)
Token:transfer	1,312	11,731	226 (+1%)
Benchmarking:create_note	1,344	11,731	88.2 (+2%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.9 (+1%)
Token:unshield	1,376	11,731	527
FPC:fee_entrypoint_private	1,376	11,731	707 (+2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	56.4 (-5%)	7,101
FeeJuice:set_portal	10.8 (-4%)	2,128
Token:constructor	82.1 (+2%)	25,285
FPC:constructor	54.1 (-1%)	17,853
FeeJuice:mint_public	40.7 (+5%)	5,415
Token:mint_public	⚠️ 70.8 (+58%)	10,101
Token:assert_minter_and_mint	40.9 (-28%)	6,844
AuthRegistry:set_authorized	37.9 (-6%)	3,969
FPC:prepare_fee	233 (+1%)	6,747
Token:transfer_public	⚠️ 32.0 (+49%)	38,126
FPC:pay_refund	56.2 (+10%)	9,398
Benchmarking:increment_balance	1,206	6,179
Token:_increase_public_balance	40.4 (-3%)	7,705
FPC:pay_refund_with_shielded_rebate	63.9 (-2%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.162 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.27 (+4%)	4.15 (+7%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.117 (+3%)	0.118 (+8%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.5 (+1%)	18.0 (+1%)	32.2 (+1%)	60.2 (+1%)	118 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.110 (+1%)	0.105 (+1%)	0.105 (+2%)	0.103 (+1%)	0.106 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.6 (+1%)	26.4 (+2%)	45.4	83.3 (+1%)	169 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.111 (+1%)	0.107 (+2%)	0.110 (+1%)	0.103 (+1%)	0.107
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.9	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.108	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |