chore: fix various warnings in noir code

[TomAFrench]

Fixing various issues in the Noir code

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,364 (+104%)
• avm_simulation_time_ms (Token:transfer_public): 37.9 (+39%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,772	1,562 (-1%)	709	758 (+1%)	780 (+1%)
proof_construction_time_sha256_30_ms	11,460	3,074	1,372	1,422	1,463
proof_construction_time_sha256_100_ms	44,117	11,788	5,423	5,407 (+1%)	5,714 (-1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	59.0 (+2%)	88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,533	422	201	220 (-4%)	276 (+3%)
proof_construction_time_poseidon_hash_100_ms	5,656	1,517	679 (+1%)	725 (-1%)	741 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,256	92,984	178,072
l1_rollup_execution_gas	842,916	1,576,540	3,361,684
l2_block_processing_time_in_ms	274 (+9%)	453	818
l2_block_building_time_in_ms	11,420	22,271 (-1%)	44,523
l2_block_rollup_simulation_time_in_ms	11,420	22,271 (-1%)	44,522
l2_block_public_tx_process_time_in_ms	9,697	20,446 (-1%)	42,668

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,115 (+4%)	3,858 (-2%)
node_database_size_in_bytes	12,599,376	16,666,704
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	97.2 (+6%)	378 (-5%)	21,735	44,860	N/A
private-kernel-inner	174 (-2%)	686 (-2%)	72,544	45,007	N/A
private-kernel-reset-tiny	309 (-2%)	697 (-3%)	65,593	44,846	N/A
private-kernel-tail	166 (-1%)	130 (-4%)	50,644	52,257	N/A
base-parity	5.56 (-1%)	N/A	160	96.0	N/A
root-parity	35.3 (-1%)	N/A	73,948	96.0	N/A
base-rollup	3,463	N/A	189,136	664	N/A
block-root-rollup	41.2 (-1%)	N/A	58,205	2,448	N/A
public-kernel-setup	84.2 (-1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	97.2	N/A	104,911	71,222	N/A
public-kernel-tail	857 (-1%)	N/A	390,582	16,414	N/A
private-kernel-reset-small	309	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	⚠️ 1,364 (+104%)	588 (-5%)	455,400	1,825	N/A
public-kernel-teardown	84.1 (-1%)	N/A	105,349	71,222	N/A
merge-rollup	20.5 (+1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	84,017 (+9%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	341
ContractInstanceDeployer:deploy	1,408	11,731	18.1 (-1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	403
FeeJuice:deploy	1,376	11,731	385 (-2%)
SchnorrAccount:constructor	1,312	11,731	73.5 (-1%)
SchnorrAccount:entrypoint	2,304	11,731	394
Token:privately_mint_private_note	1,280	11,731	100 (-1%)
FPC:fee_entrypoint_public	1,344	11,731	26.2 (-3%)
Token:transfer	1,312	11,731	219 (-2%)
Benchmarking:create_note	1,344	11,731	86.8 (+1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.9 (+1%)
Token:unshield	1,376	11,731	524
FPC:fee_entrypoint_private	1,376	11,731	704

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	57.8 (+1%)	7,101
FeeJuice:set_portal	12.0 (-1%)	2,128
Token:constructor	80.6 (-2%)	25,285
FPC:constructor	55.2 (+1%)	17,853
FeeJuice:mint_public	39.4 (-6%)	5,415
Token:mint_public	45.2 (+1%)	10,101
Token:assert_minter_and_mint	66.4 (+1%)	6,844
AuthRegistry:set_authorized	46.2 (-4%)	3,969
FPC:prepare_fee	235 (-5%)	6,747
Token:transfer_public	⚠️ 37.9 (+39%)	38,126
FPC:pay_refund	62.2 (+20%)	9,398
Benchmarking:increment_balance	1,200	6,179
Token:_increase_public_balance	40.7 (+2%)	7,705
FPC:pay_refund_with_shielded_rebate	62.5 (+3%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.164 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.27 (+5%)	3.87 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.118 (+5%)	0.109 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.2 (-3%)	18.2 (+2%)	31.4 (+3%)	59.9 (+1%)	115 (+3%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.107 (-3%)	0.105 (+2%)	0.102 (+3%)	0.103	0.103 (+3%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.2 (-1%)	25.8	44.0 (+2%)	83.1	163 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108	0.104 (+1%)	0.107 (+2%)	0.103	0.103 (+2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.7	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |