-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add status
to contract and use it to catch prune
#8620
Milestone
Comments
This was referenced Sep 18, 2024
Rumata888
pushed a commit
that referenced
this issue
Sep 27, 2024
Fixes #8620, by using the status function to figure out when a prune have happened and unwind state. It do NOT tell the world state synchronizer about the unwinding and that should be addressed as part of #8665. Adds tests to `e2e_synching` making sure that an archiver will correctly catch the prune happening and delete the blocks and accompanying data. Also adds e2e_synching to earthfile. Removes the `proven_store` since we learn this from the status and it is not more closely linked to the fetching of blocks. Note that we are not handling L1 re-orgs specifically in here, but they will for some cases be caught as well. But not all, so there is still #8621 as well. Fixes an issue where asking for block 0 would return block 1, as there is no block 0. Explicitly return undefined if block 0 is requested now, and gives an error if using `getBlocks` from a block that is before the initial block.
Rumata888
pushed a commit
that referenced
this issue
Sep 27, 2024
Fixes #8620, by using the status function to figure out when a prune have happened and unwind state. It do NOT tell the world state synchronizer about the unwinding and that should be addressed as part of #8665. Adds tests to `e2e_synching` making sure that an archiver will correctly catch the prune happening and delete the blocks and accompanying data. Also adds e2e_synching to earthfile. Removes the `proven_store` since we learn this from the status and it is not more closely linked to the fetching of blocks. Note that we are not handling L1 re-orgs specifically in here, but they will for some cases be caught as well. But not all, so there is still #8621 as well. Fixes an issue where asking for block 0 would return block 1, as there is no block 0. Explicitly return undefined if block 0 is requested now, and gives an error if using `getBlocks` from a block that is before the initial block.
Rumata888
pushed a commit
that referenced
this issue
Sep 27, 2024
Fixes #8620, by using the status function to figure out when a prune have happened and unwind state. It do NOT tell the world state synchronizer about the unwinding and that should be addressed as part of #8665. Adds tests to `e2e_synching` making sure that an archiver will correctly catch the prune happening and delete the blocks and accompanying data. Also adds e2e_synching to earthfile. Removes the `proven_store` since we learn this from the status and it is not more closely linked to the fetching of blocks. Note that we are not handling L1 re-orgs specifically in here, but they will for some cases be caught as well. But not all, so there is still #8621 as well. Fixes an issue where asking for block 0 would return block 1, as there is no block 0. Explicitly return undefined if block 0 is requested now, and gives an error if using `getBlocks` from a block that is before the initial block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The archiver shall be able to figure out when a prune have been made, and delete the necessary blocks from its database.
The text was updated successfully, but these errors were encountered: