feat: Archiver must handle L1 re-orgs gracefully. #8621
Milestone
Comments
This was referenced Sep 18, 2024
LHerskind
added a commit
that referenced
this issue
Sep 26, 2024
Fixes #8620, by using the status function to figure out when a prune have happened and unwind state. It do NOT tell the world state synchronizer about the unwinding and that should be addressed as part of #8665. Adds tests to `e2e_synching` making sure that an archiver will correctly catch the prune happening and delete the blocks and accompanying data. Also adds e2e_synching to earthfile. Removes the `proven_store` since we learn this from the status and it is not more closely linked to the fetching of blocks. Note that we are not handling L1 re-orgs specifically in here, but they will for some cases be caught as well. But not all, so there is still #8621 as well. Fixes an issue where asking for block 0 would return block 1, as there is no block 0. Explicitly return undefined if block 0 is requested now, and gives an error if using `getBlocks` from a block that is before the initial block.
Rumata888
pushed a commit
that referenced
this issue
Sep 27, 2024
Fixes #8620, by using the status function to figure out when a prune have happened and unwind state. It do NOT tell the world state synchronizer about the unwinding and that should be addressed as part of #8665. Adds tests to `e2e_synching` making sure that an archiver will correctly catch the prune happening and delete the blocks and accompanying data. Also adds e2e_synching to earthfile. Removes the `proven_store` since we learn this from the status and it is not more closely linked to the fetching of blocks. Note that we are not handling L1 re-orgs specifically in here, but they will for some cases be caught as well. But not all, so there is still #8621 as well. Fixes an issue where asking for block 0 would return block 1, as there is no block 0. Explicitly return undefined if block 0 is requested now, and gives an error if using `getBlocks` from a block that is before the initial block.
Rumata888
pushed a commit
that referenced
this issue
Sep 27, 2024
Fixes #8620, by using the status function to figure out when a prune have happened and unwind state. It do NOT tell the world state synchronizer about the unwinding and that should be addressed as part of #8665. Adds tests to `e2e_synching` making sure that an archiver will correctly catch the prune happening and delete the blocks and accompanying data. Also adds e2e_synching to earthfile. Removes the `proven_store` since we learn this from the status and it is not more closely linked to the fetching of blocks. Note that we are not handling L1 re-orgs specifically in here, but they will for some cases be caught as well. But not all, so there is still #8621 as well. Fixes an issue where asking for block 0 would return block 1, as there is no block 0. Explicitly return undefined if block 0 is requested now, and gives an error if using `getBlocks` from a block that is before the initial block.
Rumata888
pushed a commit
that referenced
this issue
Sep 27, 2024
Fixes #8620, by using the status function to figure out when a prune have happened and unwind state. It do NOT tell the world state synchronizer about the unwinding and that should be addressed as part of #8665. Adds tests to `e2e_synching` making sure that an archiver will correctly catch the prune happening and delete the blocks and accompanying data. Also adds e2e_synching to earthfile. Removes the `proven_store` since we learn this from the status and it is not more closely linked to the fetching of blocks. Note that we are not handling L1 re-orgs specifically in here, but they will for some cases be caught as well. But not all, so there is still #8621 as well. Fixes an issue where asking for block 0 would return block 1, as there is no block 0. Explicitly return undefined if block 0 is requested now, and gives an error if using `getBlocks` from a block that is before the initial block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current archiver lives in a fairy world where the base-layer never reorgs. By using only block numbers as its checkpoints it cannot tell if a re-org have happened and what do to about it. This can be an issue if for example blocks are pulled up till block 20, with no l2 blocks, it then re-orgs and there would have been a l2 block at block the "new" block 19. In this case, it would never find that block because it only starts looking at 20.
The text was updated successfully, but these errors were encountered: