Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update decoder block specification comment #1690

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

LHerskind
Copy link
Contributor

Fixes #1678 and creates a gist for easier fixing in the future by anyone.

Pads more consistently and removed values that were not really in the blocks. Should follow the l2_block.ts now.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@iAmMichaelConnor iAmMichaelConnor enabled auto-merge (squash) August 21, 2023 09:46
@iAmMichaelConnor iAmMichaelConnor merged commit 5a0a4c4 into master Aug 21, 2023
78 checks passed
@iAmMichaelConnor iAmMichaelConnor deleted the lh/1678-decoder-comment branch August 21, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Decoder.sol comment error?
2 participants