Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoder.sol comment error? #1678

Closed
iAmMichaelConnor opened this issue Aug 20, 2023 · 1 comment · Fixed by #1690
Closed

Decoder.sol comment error? #1678

iAmMichaelConnor opened this issue Aug 20, 2023 · 1 comment · Fixed by #1690
Labels
A-documentation Area: relates to documentation T-question Type: Someone is asking a questions about something

Comments

@iAmMichaelConnor
Copy link
Contributor

aztec-packages/l1-contracts/src/core/libraries/Decoder.sol

Line 50 in a78d939

* | 0x0244 | a * 0x20 | newCommitments (each element 32 bytes)

I didn't understand this row of the decoder block comment. The byte start is the same as the row above it, and the declaration of variable a (presumably the len(newCommitments)?) is missing.

(@LHerskind)
@iAmMichaelConnor iAmMichaelConnor added A-documentation Area: relates to documentation T-question Type: Someone is asking a questions about something labels Aug 20, 2023
@LHerskind
Copy link
Contributor

Looks like a stale comment ye. We got a python script for generating the comment, think there is probably just a missing line in there or could be from a weird merge. Will fix it tomorrow.

@LHerskind LHerskind mentioned this issue Aug 21, 2023
Merged
4 tasks
iAmMichaelConnor pushed a commit that referenced this issue Aug 21, 2023
@LHerskind
fix: update decoder block specification comment (#1690)
5a0a4c4 
Fixes #1678 and creates a gist for easier fixing in the future by
anyone.

Pads more consistently and removed values that were not really in the
blocks. Should follow the `l2_block.ts` now.
codygunton pushed a commit that referenced this issue Jan 23, 2024
@PhilWindle @jonybur
Merge pull request #1678 from AztecProtocol/defi-bridge-project
40476bb 
* Copied index.html to output (#1661)

* Generate htnl file (#1662)

* Deployment fix (#1663)

* Deployment fixes (#1665)

* Deployment fix attempt (#1667)

* Updated falafel and kebab terraform with new project directory structure (#1670)

* Reduce the amount of logging in kebab (#1668)

* Reduce the amount of logging in kebab

* Logging improvement

* Bug fix

* Reverted erroneous change

* Pw/increase faucet drip (#1669)

* Increased the faucet drip size

* Force contract redeployment

* Deploy terraform from correct directory (#1671)

* JB/Website grants updates (#1666)

* Add new grant

* Improve research images

* Mini typo

* JB/Website build manifest (#1672)

* Add website to build manifest

* JB/Brand iteration (#1673)

* Small build change

* JB/Fix website deployment (#1676)

* Fix deployment

* JB/Fix website deploy (#1677)

* Fix deploy

Co-authored-by: Jonathan Bursztyn <jobur93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-documentation Area: relates to documentation T-question Type: Someone is asking a questions about something
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update decoder block specification comment AztecProtocol/aztec-packages
2 participants
@LHerskind @iAmMichaelConnor