chore(ci): switch to pulling ACIR from artifacts #3043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof, this is unfortunate. We need to set up |
|
Can you use the aztec bot token for this? |
|
Yeah, we don't really need any permissions so aztec-bot would work. I'll take a look at this sometime tomorrow/Fri. |
* master: (95 commits) feat!: make noir_wasm the default compiler (#3090) feat: Add root rollup circuit (#3217) refactor: Move sumcheck (#3189) refactor: Move flavors (#3188) refactor: Move honk/pcs (#3187) feat: Extract types to a types crate (#3203) fix: better update steps for dockerized sandbox (#3204) refactor: Move transcripts (#3176) chore: Fix typo in aztec sandbox (#3191) feat: Enable pkc in noir (#3194) chore: more boiler plate code for merge rollup (#3182) fix: remove unused import (#3200) feat(docs): New getting started flow (#2957) feat!: adding all the (note, nonce) pairs in `PXE.addNote` and hiding `PXE.getNoteNonces` (#3196) chore: refactor e2e to not use @aztec/types (#3175) chore: bump noir (#3197) feat: add cli command update aztec dependencies (#3128) feat!: API inconsistency fix (#3190) chore: Add initial skeleton code for root/merge/mase rollups for Noir (#3178) feat: migrate cpp private kernel tests to noir (#3165) ...
|
It's not clear to me where these tokens are being injected from plus we're going to need it inside an EC2 instance(?) rather than a script being run directly on circleci. I don't think I know enough about the CI setup here to be able to do this quickly tbh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to noir-lang/noir#3288
This switches us over to pulling the ACIR artifacts from an artifact on a workflow run. Instead of closing the Noir repository we look for an artifact called "acir-artifacts" on a workflow attached to the particular branch on the Noir repository.