Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused pedersen c_binds #3058

Merged
merged 31 commits into from
Oct 26, 2023
Merged

chore: Remove unused pedersen c_binds #3058

merged 31 commits into from
Oct 26, 2023

Commits on Oct 25, 2023

  1. remove pedersen_buffer_to_field from cbinds

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    84c35f5 View commit details
    Browse the repository at this point in the history

  2. regenerate bindings

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    d74eb76 View commit details
    Browse the repository at this point in the history

  3. remove test

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    7586a6d View commit details
    Browse the repository at this point in the history

  4. use compressWIthHashIndex for redundant methods

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    53c65cd View commit details
    Browse the repository at this point in the history

  5. remove pedersenGetHash

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    4954a42 View commit details
    Browse the repository at this point in the history

  6. lint

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    3c16824 View commit details
    Browse the repository at this point in the history

  7. add test to show that some methods are all the same

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c3a54d0 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/master' into kw/pedersen-cleanup… 

    …-rename-compress
    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    6798941 View commit details
    Browse the repository at this point in the history

  9. rename compress -> hash

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c1ebc73 View commit details
    Browse the repository at this point in the history

  10. rename codebase to use hash

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    18a8e74 View commit details
    Browse the repository at this point in the history

  11. lint

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    1841760 View commit details
    Browse the repository at this point in the history

  12. fix typos

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    1095911 View commit details
    Browse the repository at this point in the history

  13. fix typo

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    245e44b View commit details
    Browse the repository at this point in the history

  14. Empty commit

    @kevaundray
    kevaundray committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    362f185 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. move output argument to last position to match c_bind_new and other c… 

    … functions
    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ccd0c96 View commit details
    Browse the repository at this point in the history

  2. modify calling code to: 

    - account for argument switch
- fix: allocate instead of using scratch space
    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ef27e71 View commit details
    Browse the repository at this point in the history

  3. optimize pedersenHash for wasm scratch space

    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    0a52d4f View commit details
    Browse the repository at this point in the history

  4. lint

    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    96d4ebd View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into kw/pedersen-cleanup-argument-ordering-fix

    @LeilaWang
    LeilaWang authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    8f7408a View commit details
    Browse the repository at this point in the history

  6. charlie review: free the allocated input

    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    3deef57 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'kw/pedersen-cleanup-argument-ordering-fix' into kw/pede… 

    …rsen-cleanup-optimize-hashing
    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    4a8f73b View commit details
    Browse the repository at this point in the history

  8. remove unused cbinds

    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d8a6917 View commit details
    Browse the repository at this point in the history

  9. re-generate bindings

    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    3aa048c View commit details
    Browse the repository at this point in the history

  10. update tests

    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    e5c922e View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/master' into kw/pedersen-cleanup… 

    …-remove-unused-cbinds
    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    5a039cb View commit details
    Browse the repository at this point in the history

  12. compress -> hash

    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    427d1d9 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into kw/pedersen-cleanup-remove-unused-cbinds

    @kevaundray
    kevaundray authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6723259 View commit details
    Browse the repository at this point in the history

  14. make pedersen_hash look exactly like pedersen_compress

    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    55a7e87 View commit details
    Browse the repository at this point in the history

  15. remove leftover function definitions from header

    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    8ce6c40 View commit details
    Browse the repository at this point in the history

  16. Empty commit

    @kevaundray
    kevaundray committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    36ffe57 View commit details
    Browse the repository at this point in the history

  17. chore: remove pedersen getHashTree (#3069) 

    Related to #3029 

We can merge this into `kw/pedersen-cleanup-remove-unused-cbinds` as
part of the cleanup

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
    @kevaundray
    kevaundray authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    5e78f63 View commit details
    Browse the repository at this point in the history