chore: automatic c_binds for commit should return a point instead of an Fr element #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- account for argument switch - fix: allocate instead of using scratch space
…rsen-cleanup-optimize-hashing
…-remove-unused-cbinds
Related to #3029 We can merge this into `kw/pedersen-cleanup-remove-unused-cbinds` as part of the cleanup # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
kevaundray
changed the base branch from
master
to
kw/pedersen-cleanup-remove-unused-cbinds
Base automatically changed from
kw/pedersen-cleanup-remove-unused-cbinds
to
master
October 26, 2023 16:59
…e-fix-commit-interface
4 tasks
kevaundray
added a commit
that referenced
this pull request
Oct 26, 2023
…an Fr element (#3072) Commit history was a bit messed up in #3071 Related to #3029 # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3029
This is a remnant from the previous pedersen algorithm. Commit now returns a point (x,y)
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.