chore(noir-contracts): remove redundant return value of 1

[rahul-kothari]

Fix #2615

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_trial_decrypting_time_in_ms (5): 188 (+49%)
• note_trial_decrypting_time_in_ms (8): 99.7 (+1521%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit d94d88bf and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	223,056	868,124	3,449,288
l1_rollup_execution_gas	842,143	3,595,232	22,204,657
l2_block_processing_time_in_ms	2,007 (-1%)	7,639 (-1%)	30,007 (-1%)
note_successful_decrypting_time_in_ms	296 (-2%)	884 (-2%)	3,194 (-4%)
note_trial_decrypting_time_in_ms	⚠️ 99.7 (+1521%)	95.4 (-12%)	141 (-2%)
l2_block_building_time_in_ms	20,611 (-1%)	82,014	326,779
l2_block_rollup_simulation_time_in_ms	11,932 (-2%)	47,574	188,878
l2_block_public_tx_process_time_in_ms	8,634	34,302	137,385

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,678 (-1%)	42,441 (-1%)
note_history_successful_decrypting_time_in_ms	2,032	4,004
note_history_trial_decrypting_time_in_ms	⚠️ 188 (+49%)	157 (-22%)
node_database_size_in_bytes	1,630,218	1,096,336
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	766	61,697	18,905
private-kernel-ordering	127	24,297	8,153
base-rollup	1,755	656,428	873
root-rollup	168 (-1%)	4,072	1,097
private-kernel-inner	791	81,568	18,905
public-kernel-private-input	575 (+1%)	41,519	18,905
public-kernel-non-first-iteration	410	41,561	18,905
merge-rollup	15.4 (-1%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,787	27,547