chore: Recursive verifier updates

[ledwards2225]

This work contains the following updates:

1. Previously we used only check_circuit() to ensure correctness of the Honk recursive verifier circuits. This is somewhat incomplete if the arithmetization of the circuit is Goblin Ultra Honk since check_circuit() is only complete for the conventional Ultra arithmetization and does not cover Goblin style ecc op gates or the DataBus functionality. This PR swaps out check_circuit for genuine proof construction/verification which is more time consuming but also more robust.
2. Updates constructor of recursive verifier to take a native verification key directly rather than requiring prior external construction of the stdlib verification key.
3. Adds a debug only method for ensuring all selectors have the same length.

Note: Currently the two recursive verifier test suites share a lot of code. A follow on should potentially combine the two suites.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 25.4 (+31%)
• note_trial_decrypting_time_in_ms (32): 80.1 (+62%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 91cb369a and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,888	868,160	3,449,384
l1_rollup_execution_gas	841,975	3,595,268	22,204,753
l2_block_processing_time_in_ms	2,221	8,506	35,395 (+1%)
note_successful_decrypting_time_in_ms	317 (+2%)	941 (+2%)	3,386 (+1%)
note_trial_decrypting_time_in_ms	⚠️ 25.4 (+31%)	⚠️ 80.1 (+62%)	200 (+1%)
l2_block_building_time_in_ms	20,483 (+1%)	81,357	326,371 (+1%)
l2_block_rollup_simulation_time_in_ms	16,936 (+1%)	67,350	270,084 (+1%)
l2_block_public_tx_process_time_in_ms	3,499	13,856	55,732

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	24,733 (-2%)	47,621
note_history_successful_decrypting_time_in_ms	2,190 (-1%)	4,245
note_history_trial_decrypting_time_in_ms	166 (-1%)	236 (+3%)
node_database_size_in_bytes	2,793,887	5,016,933
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	200 (+1%)	43,109	20,441
private-kernel-ordering	115	25,833	9,689
base-rollup	2,960	664,108	873
root-rollup	90.5 (+5%)	4,072	1,097
private-kernel-inner	261	64,516	20,441
public-kernel-private-input	171 (-1%)	25,203	20,441
public-kernel-non-first-iteration	168	25,245	20,441
merge-rollup	10.8	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	10,323	25,938

[ledwards2225]

These were not used in any of our existing code paths (always null) and were causing confusion as I was debugging.

[maramihali]

Looks good! Very minor comments

[maramihali]

out of curiosity, can you explain what happened here? I believe the other q_busread changes are related to this,

[ledwards2225]

This is actually an insignificant change. In this context this->selectors and selectors are identical. In some cases the distinction is important but here the this-> was simply unnecessary so I removed it to avoid confusion.