feat: sequencer processes transactions in phases

[just-mitch]

Turn public processor into a state machine to progress through the phases:

1. Fee Prep
2. App Logic
3. Fee Distribution

Add abstract phase manager to hold common logic.

Presently the Fee Prep and Fee Distribution phases are noops.

In the logs you will now see:

aztec:sequencer:fee-preparation Handle 0f79ae7198b4ed85829f6881af69fc590ed986b528e74af252b3afe430172d99 with no-op +0ms
aztec:sequencer:application-logic Processing tx 0f79ae7198b4ed85829f6881af69fc590ed986b528e74af252b3afe430172d99 +0ms
aztec:sequencer:fee-distribution Handle 0f79ae7198b4ed85829f6881af69fc590ed986b528e74af252b3afe430172d99 with no-op +0ms

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (32): 121 (+140%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit f85a8708 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,412	179,524	716,068
l1_rollup_calldata_gas	221,704	866,860	3,448,408
l1_rollup_execution_gas	314,191	984,600	3,668,065
l2_block_processing_time_in_ms	1,154 (-1%)	4,357	17,309
note_successful_decrypting_time_in_ms	338 (-1%)	994 (-1%)	3,735 (-1%)
note_trial_decrypting_time_in_ms	49.0 (-9%)	⚠️ 121 (+140%)	147 (-1%)
l2_block_building_time_in_ms	18,241	71,824	288,361
l2_block_rollup_simulation_time_in_ms	13,067	51,654	207,979
l2_block_public_tx_process_time_in_ms	5,113	20,097 (-1%)	80,131 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,911	26,746
note_history_successful_decrypting_time_in_ms	2,602 (+6%)	4,727 (-2%)
note_history_trial_decrypting_time_in_ms	93.3 (+4%)	190 (-10%)
node_database_size_in_bytes	17,330,256	33,198,160 (+1%)
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	316	44,897	26,193
private-kernel-ordering	192 (-1%)	44,513	14,929
base-rollup	1,405 (-1%)	128,970	881
root-rollup	83.1	4,088	677
private-kernel-inner	421	72,056	26,193
public-kernel-private-input	241 (-1%)	32,615	26,193
public-kernel-non-first-iteration	240	32,657	26,193
merge-rollup	7.63	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	11.3	12.6	17.2 (+2%)	23.0 (+1%)	64.1	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.594	0.631	0.537	0.533 (+2%)	0.482 (+1%)	0.442	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	75.8	47.6	239	466 (+1%)	905	3,570
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.468	0.488	0.437	0.435 (+1%)	0.431	0.428
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	104 (-1%)	56.9	349	693	1,372	5,434
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.494 (-1%)	0.498	0.477 (+1%)	0.475	0.476	0.473
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.7	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.579	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,575	37,677

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	581 (-1%)	1,362

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.486	625 (-1%)

[spalladino]

LGTM!

• I believe you don't need to redefine the constructors in the derived classes if they are not doing anything different than the parent's.
• It took me a while to understand why the FeePrep phase handler returned only public kernel circuits and not private, only to realize that this is all happening at the sequencer. Maybe rename the PhaseManagers to PublicPhaseManagers to make it more explicit..? Feel free to ignore this.

[just-mitch]

@spalladino Thanks!

• You're absolutely right. I had done that to override the default log in the derived classes, but when I come back to these classes I'll probably add a factory function to do it instead.
• Good point. Public might be a good prefix. I think we should also have a big comment somewhere that explains that only the sequencer has "phases". Also it should be clear (famous last words) since it is in the sequencer_client. I'll think about it again when we fill in the implementations for the Fee phases.

[PhilWindle]

We generally use undefined instead of null.

[just-mitch]

I'll fix this when we add in the implementation. I'm glad we have taken a stance!

[PhilWindle]

@just-mitch Really nice. Just one nit!