refactor!: Use NoteSerialize and NoteDeserialize traits for note specific serialization

[LHerskind]

This PR introduces updates the NoteInterface to include serialization and deserialization specific to notes.

The change is made to distinguish between Serialization of the full struct, and serialization for note content which is used when computing the note_hash, nullifier and emitting an encrypted log.

The trait is extended as follows.

    fn serialize_content(self) -> [Field; N];
    fn deserialize_content(fields: [Field; N]) -> Self;

With the change, trying to pass a Note as an argument to a contract function will fail if the serialize function is not implemented on the Note. The serialize is expected to be the full struct, so should make it easier to figure out what is wrong for users that run into this case.

[LHerskind]

Current dependencies on/for this PR:

• master
  • PR refactor!: Use NoteSerialize and NoteDeserialize traits for note specific serialization  #4383 👈
    • PR feat: pass note as argument #4395

This stack of pull requests is managed by Graphite.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 107 (+556%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 8569e7c0 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,636	180,516	720,036
l1_rollup_calldata_gas	222,540	871,032	3,463,992
l1_rollup_execution_gas	315,027	988,772	3,683,649
l2_block_processing_time_in_ms	1,160 (+1%)	4,434 (+1%)	17,387 (+1%)
note_successful_decrypting_time_in_ms	296 (-3%)	980 (+1%)	3,675 (+2%)
note_trial_decrypting_time_in_ms	⚠️ 107 (+556%)	109 (+9%)	143 (+2%)
l2_block_building_time_in_ms	17,850 (+1%)	70,434	283,410 (+1%)
l2_block_rollup_simulation_time_in_ms	13,152 (+1%)	51,899	209,125 (+1%)
l2_block_public_tx_process_time_in_ms	4,671 (+1%)	18,459	74,034 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,958 (+8%)	28,432 (+8%)
note_history_successful_decrypting_time_in_ms	2,305 (-4%)	4,611 (-4%)
note_history_trial_decrypting_time_in_ms	77.1 (-18%)	225 (+26%)
node_database_size_in_bytes	17,309,776	33,058,896
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	310	44,481	26,193
private-kernel-ordering	193	44,513	14,929
base-rollup	1,408	128,970	881
root-rollup	82.5	4,088	677
private-kernel-inner	416	71,640	26,193
public-kernel-private-input	240	32,615	26,193
public-kernel-non-first-iteration	239	32,657	26,193
merge-rollup	7.61	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.3	11.1 (-1%)	12.8 (-3%)	16.9	23.1 (+1%)	64.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.596	0.593 (-5%)	0.542 (-3%)	0.520 (-1%)	0.482 (+1%)	0.441	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	74.7	47.6 (+1%)	240 (+1%)	461	908 (+1%)	3,570 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.462	0.488	0.437	0.432	0.431 (+1%)	0.429
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	104 (+1%)	56.9 (+1%)	349	687	1,365 (-2%)	5,436 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.494 (+1%)	0.497	0.475	0.473	0.472 (-1%)	0.473
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.578	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,575	37,974

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	548	1,217

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.514 (-17%)	572

[benesjan]

Looks good 👍