chore: switch noir pull to master branch

[sirasistant]

No description provided.

[ludamad]

What's with this?

[ludamad]

Answered, noir version changes cargo lock

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@aztec/bb.js@0.23.0, npm/@eslint/js@8.55.0, npm/eslint@8.55.0

View full report↗︎

[ludamad]

Note for others, this history matters a LOT less now that we just squash changes into Noir. Originally we replayed commit by commit history, but as this was going into bulk PRs anyway it's not the most worthwhile complexity tradeoff. The only reason this should be updating now is on pulls

[sirasistant]

@vezenovm The array_dynamic_blackbox_input that was added in noir master is failing to verify in acir tests. I sent a message to @guipublic to see if he can take a look but maybe you know why it could be failing 🤔

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit e23d048e and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,956	181,604	724,196
l1_rollup_calldata_gas	227,216	888,824	3,534,080
l1_rollup_execution_gas	320,407	1,007,272	3,754,458
l2_block_processing_time_in_ms	1,201 (+1%)	4,491	17,688
note_successful_decrypting_time_in_ms	319 (+1%)	1,002 (+2%)	3,599 (-1%)
note_trial_decrypting_time_in_ms	30.8 (+15%)	34.9 (-69%)	172 (-1%)
l2_block_building_time_in_ms	18,249	72,260	288,966
l2_block_rollup_simulation_time_in_ms	13,542	53,414	214,885
l2_block_public_tx_process_time_in_ms	4,678	18,759 (+1%)	73,828

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,435 (-8%)	30,754 (+2%)
note_history_successful_decrypting_time_in_ms	2,541 (-1%)	4,943 (+1%)
note_history_trial_decrypting_time_in_ms	112 (-1%)	277 (+51%)
node_database_size_in_bytes	17,256,528	33,177,680
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	327	44,528	25,313
private-kernel-ordering	196	43,633	16,193
base-rollup	1,462	129,774	933
root-rollup	83.1 (-3%)	4,192	729
private-kernel-inner	436	70,819	25,313
public-kernel-private-input	242 (+1%)	33,663	26,945
public-kernel-non-first-iteration	240	33,705	26,945
merge-rollup	7.88 (-2%)	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.3 (+1%)	10.7	12.7 (-1%)	16.8 (-4%)	23.0	63.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.599 (+1%)	0.593	0.538	0.520 (-4%)	0.479	0.440	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	75.4 (+1%)	48.0 (+1%)	239	464	912 (+1%)	3,544
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.465 (+1%)	0.492 (+1%)	0.436	0.435	0.432 (+1%)	0.427
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	106 (+2%)	56.8	353	794 (+14%)	1,369	5,441
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.504 (+2%)	0.497	0.475	0.549 (+16%)	0.473	0.472
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	60.1 (+5%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.611 (+6%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	16,859	35,462 (-11%)

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	573 (+3%)	1,441

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.501 (-1%)	578

[sirasistant]

Opened noir-lang/noir#4356, removing the test in the meantime

[vezenovm]

@vezenovm The array_dynamic_blackbox_input that was added in noir master is failing to verify in acir tests. I sent a message to @guipublic to see if he can take a look but maybe you know why it could be failing 🤔

Thanks for flagging going to look now