fix(dsl): Add full recursive verification test

[vezenovm]

This PR adds a test that does a full recursive verification similar to TestFullRecursiveComposition under recursion_constraint.test.cpp but using Noir.

A couple bugs fixes were done to enable the new double_verify_nested_proof test:

• We have an assert in the recursion constraint that checks num_public_inputs == RecursionConstraint::AGGREGATION_OBJECT_SIZE when generating the dummy transcript for when we do not have valid witness assignments. If we want to recursively verify a recursive proof that itself has extra public inputs this assertion makes that impossible (in fact the cpp test does not use any public inputs for TestFullRecursiveComposition and this may be why this assertion wasn't hit earlier).
• After moving to a definition of a proof as separate from its public inputs in (chore!: cleanup recursion interface #3528) we were missing the accurate copy constraints in the case of no valid witness assignment. In the case of a nested proof the public inputs will contain an aggregation object for which we expect two accurate G1 points. Otherwise, even with the removed assertion above we will always hit a "trying to invert 0" error when working without valid witness assignments.

[vezenovm]

Turning back to a draft as there is a remaining bug in the CI acir tests that were passing locally for me. This is most likely an issue with how the dummy transcript is being created in the case of invalid witness assignments.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_trial_decrypting_time_in_ms (5): 178 (+103%)
• note_successful_decrypting_time_in_ms (8): 317 (-27%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit e63f0226 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	46,020	181,668	724,260
l1_rollup_calldata_gas	227,124	888,612	3,534,120
l1_rollup_execution_gas	321,310	1,008,060	3,755,521
l2_block_processing_time_in_ms	1,186 (-1%)	4,486	17,804
note_successful_decrypting_time_in_ms	⚠️ 317 (-27%)	1,011 (+4%)	3,769 (+4%)
note_trial_decrypting_time_in_ms	29.1 (-31%)	42.6 (-59%)	175 (-1%)
l2_block_building_time_in_ms	18,481 (+1%)	72,669 (+1%)	291,996 (+1%)
l2_block_rollup_simulation_time_in_ms	13,584	53,705 (+1%)	216,236 (+1%)
l2_block_public_tx_process_time_in_ms	4,821 (+3%)	18,888 (+1%)	75,501 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,360 (-4%)	29,547 (-3%)
note_history_successful_decrypting_time_in_ms	2,633 (+15%)	4,872 (+5%)
note_history_trial_decrypting_time_in_ms	⚠️ 178 (+103%)	247
node_database_size_in_bytes	17,277,008	33,161,296
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	332 (+2%)	44,664	25,409
private-kernel-ordering	196	43,729	16,289 (+1%)
base-rollup	1,468 (+1%)	129,870	933
root-rollup	83.6 (+1%)	4,192	825 (+13%)
private-kernel-inner	433	71,051	25,409
public-kernel-private-input	247 (+2%)	33,895 (+1%)	27,041
public-kernel-non-first-iteration	242 (+2%)	33,937 (+1%)	27,041
merge-rollup	7.84	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.3	11.3 (+3%)	12.6 (-1%)	17.0 (-1%)	26.6 (+16%)	64.2	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.598 (-1%)	0.629 (+2%)	0.535 (-1%)	0.526 (-1%)	0.554 (+16%)	0.442	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	75.6	47.7 (-1%)	238	463 (-1%)	905 (+1%)	3,556
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.466	0.488 (-1%)	0.435	0.433 (-2%)	0.430 (+1%)	0.428
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	105 (+1%)	57.1 (+1%)	348 (-1%)	690 (-1%)	1,366	5,443
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.496	0.498 (+1%)	0.474 (-1%)	0.473 (-1%)	0.473	0.472
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	57.0	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.578	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	17,050 (+1%)	37,663 (+6%)

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	579 (+5%)	1,468 (+2%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.511 (+1%)	590 (+3%)

[vezenovm]

@signorecello Perhaps it would be worth it to expand your recursion example to work with a test like in this PR? The test shows how to recursively verify a proof that is itself a recursive proof.

[signorecello]

@signorecello Perhaps it would be worth it to expand your recursion example to work with a test like in this PR? The test shows how to recursively verify a proof that is itself a recursive proof.

Yes this is something on my to-do list, I'll put this in devrel planning so we can schedule it. cc @critesjosh