refactor: replacing use of L2Tx with TxEffect
#4858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
benesjan
changed the title
L2Tx with TxEffect
benesjan
commented
Feb 29, 2024
| @@ -438,27 +438,12 @@ export class PXEService implements PXE { | |||
| }); | |||
| } | |||
|
|
|||
| public async getTxReceipt(txHash: TxHash): Promise<TxReceipt> { | |||
There was a problem hiding this comment.
Moved the implementation to aztec node since I needed an access to block source to be able to populated the block number and block hash of the receipt.
benesjan
force-pushed
the
02-29-refactor_replacing_use_of_L2Tx_with_TxEffect
branch
from
5d9f7fd
to
28fadab
Compare
benesjan
force-pushed
the
02-29-refactor_replacing_use_of_L2Tx_with_TxEffect
branch
from
88dc0c8
to
29348d6
Compare
|
Can't push to this branch anymore (probably because graphite expired). So I am opening a new branch #4876 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4845