refactor: dropping 'new' from TxEffect's properties #4861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
benesjan
force-pushed
the
02-29-refactor_replacing_use_of_L2Tx_with_TxEffect
branch
from
88dc0c8
to
29348d6
Compare
benesjan
force-pushed
the
02-29-refactor_dropping_new_from_TxEffect_s_properties
branch
from
02a3821
to
50cac02
Compare
ludamad
deleted the
02-29-refactor_dropping_new_from_TxEffect_s_properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having "new" in the naming of tx effect properties is not necessary as it's clear that the values are related to the given tx effect. This PR does the renamings.