refactor(avm): Introduce fixed gas cost instruction abstraction

[spalladino]

Introduces a FixedGasCost base Instruction class that follows the pattern of computing gas cost, consuming it, and then runs an internal execute. This allows instructions with dynamic gas costs, like CALL, to just override Instruction. Also renames run to execute, and execute to internalExecute.

[spalladino]

• feat(avm): Track gas usage based on memory accesses #5518
• refactor(avm): Introduce fixed gas cost instruction abstraction #5514 👈
• feat(avm): Gas usage for nested calls #5495 : 1 other dependent PR (#5563 )
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spalladino and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_successful_decrypting_time_in_ms (32): 564 (-16%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 9ffe4571 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,424	6,400	6,412
l1_rollup_execution_gas	585,757	585,733	585,745
l2_block_processing_time_in_ms	1,302 (-2%)	4,754	9,332 (-1%)
note_successful_decrypting_time_in_ms	261 (-12%)	⚠️ 564 (-16%)	1,042 (+2%)
note_trial_decrypting_time_in_ms	64.0 (-36%)	82.3 (-6%)	59.7 (+24%)
l2_block_building_time_in_ms	12,256	44,833	88,333
l2_block_rollup_simulation_time_in_ms	7,488	26,110 (-1%)	51,152
l2_block_public_tx_process_time_in_ms	4,747	18,671	37,079

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,766 (+2%)	26,708 (-3%)
note_history_successful_decrypting_time_in_ms	1,323 (+2%)	2,526 (+6%)
note_history_trial_decrypting_time_in_ms	131 (+41%)	182 (+48%)
node_database_size_in_bytes	18,624,592	35,061,840
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	184 (+1%)	44,379	28,214
private-kernel-ordering	172	52,880	14,296
base-parity	3,750 (+6%)	128	311
root-parity	1,298 (+3%)	1,244	311
base-rollup	15,136	165,760	861
root-rollup	50.3 (+3%)	4,359	725
private-kernel-inner	230 (+1%)	73,795	28,214
public-kernel-app-logic	97.0 (+1%)	35,252	28,217
public-kernel-tail	140 (+1%)	40,928	28,217
merge-rollup	9.31 (+11%)	2,568	861
public-kernel-teardown	91.6 (+1%)	35,252	28,217
public-kernel-setup	90.9 (+1%)	35,252	28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1 (+1%)	16.5 (+2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.589 (+1%)	0.506 (+2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.8 (+1%)	72.4	233	456 (+1%)	870 (-1%)	1,735 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.479 (+1%)	0.446	0.424	0.425 (+1%)	0.414	0.414	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.7 (+1%)	107 (-1%)	338	689 (+3%)	1,314	2,618	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.482 (+1%)	0.483	0.459	0.474 (+3%)	0.456	0.455	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.8
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.539

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,968	495,320

Transaction size based on fee payment method

Metric	none fee payment method	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	773	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,833 (+2%)	1,229 (+2%)	5,681 (+3%)

Metric	0 public data writes	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	9.84	588 (+1%)	436 (+1%)	1,165 (+2%)	578 (+2%)	2,024 (+2%)	563 (+3%)

[Maddiaa0]

Im in favor of repeating ourselves with gas accounting here to keep the code more readable rather than it living in the inherited class