refactor: nuking accounts from e2e setup

[benesjan]

Fixes #5307

[benesjan]

• refactor: nuking accounts from e2e setup #5574 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 39.1 (+316%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit d827705f and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,424	6,424	6,424
l1_rollup_execution_gas	585,757	585,757	585,757
l2_block_processing_time_in_ms	1,343 (+3%)	4,726 (-2%)	9,413
note_successful_decrypting_time_in_ms	239 (+14%)	607 (-1%)	940
note_trial_decrypting_time_in_ms	⚠️ 39.1 (+316%)	14.2 (-25%)	43.1 (-29%)
l2_block_building_time_in_ms	11,959	43,101	84,724
l2_block_rollup_simulation_time_in_ms	7,175 (+1%)	24,348	47,099
l2_block_public_tx_process_time_in_ms	4,748 (-1%)	18,630	37,388

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,374 (-6%)	27,824 (+2%)
note_history_successful_decrypting_time_in_ms	1,328 (+7%)	2,426 (+3%)
note_history_trial_decrypting_time_in_ms	78.0 (+6%)	117 (+40%)
node_database_size_in_bytes	18,665,552	34,975,824
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	180	44,377	26,164
private-kernel-ordering	161 (-1%)	50,830	39,325
base-parity	4,230	128	311
root-parity	1,165 (+2%)	1,244	311
base-rollup	14,409	116,608	861
root-rollup	50.1 (-1%)	4,359	725
private-kernel-inner	217	71,744	26,164
public-kernel-app-logic	119 (-1%)	47,695	40,661
public-kernel-tail	163 (-1%)	53,372	13,269
merge-rollup	9.31 (-10%)	2,568	861
public-kernel-teardown	118 (+1%)	47,695	40,661
public-kernel-setup	117 (+1%)	47,695	40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1	16.1 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.585 (+1%)	0.496 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.1 (+1%)	72.3 (+1%)	232	449 (+2%)	867 (-1%)	1,732 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.473 (+1%)	0.445 (+1%)	0.422	0.419 (+2%)	0.413 (-1%)	0.414	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.4 (+1%)	107	343 (+1%)	663 (+2%)	1,310	2,608	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.479	0.482	0.467 (+1%)	0.455 (+2%)	0.453	0.455	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.5 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.535 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	40,548	501,142

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,713 (-1%)	1,084 (-1%)	5,452 (+1%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	577	440 (+1%)	1,081 (+1%)	527	1,757 (+1%)	592 (+1%)

[sklppy88]

shit's pretty 🪰 👍 🙌

[sklppy88]

very much like putting this in line with all the other e2e tests

[sklppy88]

Wdyt about sticking to this as a convention?

Suggested change

	gasPortalAddress = deployL1ContractsValues.l1ContractAddresses.gasPortalAddress;
	({gasPortalAddress} = deployL1ContractsValues.l1ContractAddresses);

Pros: Slightly more terse
Cons: More error prone if fucking something up with semicolons, arguably harder to read ?

[benesjan]

I think in this case it doesn't matter much.

[sklppy88]

yuck but I understand why it was done 🤷