feat: sequencer validates setup/teardown function selectors

[alexghr]

This PR refactors the TxValidator class so it's more flexible and adds whitelisting capabilities on the function selector for setup/teardown phases.

Fix #5401

[alexghr]

• feat: sequencer validates setup/teardown function selectors #5649 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexghr and the rest of your teammates on Graphite

[alexghr]

I changed this to keep app-logic function calls towards the front of the queue and setup/teardown (ie. [...app, ...setup, teardown]) to match what the PXE does. The sequencer then reverses it before it starts public execution

[alexghr]

Not the best parsing since it assumes that an AztecAddress extends Fr but it should always be prefixed with 0x

[alexghr]

What does everyone thing of this change? (sequencer depending on contracts)

It allows me to add sane defaults in the config and to use the new Contract.storage.<thing>.slot for the gas token balance

[PhilWindle]

If this is referring to our contracts, including things like the gas token then I think it's fine.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 79.6 (+91%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,400	6,400	6,424
l1_rollup_execution_gas	585,733	585,733	585,757
l2_block_processing_time_in_ms	1,298 (+3%)	4,710 (-2%)	9,144 (-1%)
note_successful_decrypting_time_in_ms	275 (+13%)	579 (-2%)	972
note_trial_decrypting_time_in_ms	⚠️ 79.6 (+91%)	86.7 (+40%)	93.2 (-1%)
l2_block_building_time_in_ms	10,415 (+1%)	37,151	73,034
l2_block_rollup_simulation_time_in_ms	10,292	36,761	72,267 (-1%)
l2_block_public_tx_process_time_in_ms	4,916 (-1%)	19,219 (-1%)	38,672 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,222 (+2%)	26,663 (+1%)
note_history_successful_decrypting_time_in_ms	1,247 (+5%)	2,240 (+1%)
note_history_trial_decrypting_time_in_ms	55.8 (+46%)	77.8 (-1%)
node_database_size_in_bytes	18,628,688	34,984,016
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	143 (-1%)	44,377	26,164
private-kernel-inner	155 (-2%)	71,744	26,164
private-kernel-ordering	107 (-1%)	50,830	39,026
base-parity	3,949 (+2%)	128	311
root-parity	973 (-10%)	1,244	311
base-rollup	13,321 (-1%)	110,464	861
root-rollup	49.3	4,359	725
public-kernel-app-logic	79.5	47,695	40,661
public-kernel-tail	111 (-1%)	53,372	7,125
merge-rollup	10.0 (+1%)	2,568	861
public-kernel-teardown	75.7 (-1%)	47,695	40,661
public-kernel-setup	74.5 (-1%)	47,695	40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.0 (-1%)	16.0 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.583 (-1%)	0.496 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.1 (+1%)	72.2	232 (-1%)	447 (+1%)	871	1,732	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.473	0.445	0.422 (-1%)	0.417	0.414 (+1%)	0.414	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.2	107	337	662	1,310	2,628 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.479	0.481	0.458	0.455	0.454	0.455	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.2
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.534

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	40,372	496,534

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,186 (-1%)	826 (-1%)	3,969 (-2%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	421	277 (-1%)	718 (-2%)	361 (-9%)	1,175 (-2%)	428 (-1%)

[alexghr]

This stopped being necessary since #5267 but I forgot to remove the check from this contract.

[PhilWindle]

This is great!

[PhilWindle]

If this is referring to our contracts, including things like the gas token then I think it's fine.