chore(public): remove getNullifierMembershipWitness

[fcarreiro]

Remove getNullifierMembershipWitness oracle implementation from PUBLIC since it should not be used there. Nullifier checks are done through checkNullifierExists.

[fcarreiro]

• chore(public): remove getNullifierMembershipWitness #5715 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_successful_decrypting_time_in_ms (8): 241 (+53%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,796	6,784	6,808
l1_rollup_execution_gas	587,277	587,265	587,289
l2_block_processing_time_in_ms	1,298	4,703	9,037
note_successful_decrypting_time_in_ms	⚠️ 241 (+53%)	453 (-8%)	897 (-6%)
note_trial_decrypting_time_in_ms	45.5 (-26%)	58.9 (-40%)	114 (+66%)
l2_block_building_time_in_ms	10,282 (-3%)	36,554 (-3%)	72,308 (-2%)
l2_block_rollup_simulation_time_in_ms	10,170 (-3%)	36,160 (-3%)	71,572 (-2%)
l2_block_public_tx_process_time_in_ms	4,909 (-3%)	19,295 (-3%)	38,477 (-3%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,190 (+2%)	26,759 (-4%)
note_history_successful_decrypting_time_in_ms	1,173 (+3%)	2,191 (+2%)
note_history_trial_decrypting_time_in_ms	41.5 (+11%)	119 (+65%)
node_database_size_in_bytes	18,755,664	35,188,816
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	141 (-3%)	44,561	26,424
private-kernel-inner	151 (-3%)	72,188	26,424
private-kernel-ordering	105 (-3%)	51,090	39,297
base-parity	3,840 (-2%)	128	311
root-parity	1,051	1,244	311
base-rollup	12,934 (-2%)	110,820	957
root-rollup	48.5 (-1%)	4,551	821
public-kernel-app-logic	80.9 (-3%)	48,151	40,933
public-kernel-tail	119 (-2%)	53,644	7,385
merge-rollup	10.9 (+7%)	2,760	957
public-kernel-teardown	78.2	48,151	40,933
public-kernel-setup	77.2	48,151	40,933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.78 (-2%)	15.6 (-3%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.570 (-2%)	0.482 (-3%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	44.7 (-3%)	71.2 (-2%)	225 (-2%)	433 (-4%)	841 (-4%)	1,755 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.458 (-3%)	0.439 (-2%)	0.409 (-3%)	0.403 (-4%)	0.399 (-3%)	0.419 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	52.9 (-2%)	105 (-2%)	326 (-4%)	643 (-3%)	1,265 (-3%)	2,541 (-3%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.467 (-3%)	0.473 (-2%)	0.443 (-4%)	0.442 (-3%)	0.439 (-3%)	0.442 (-3%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	59.5 (-3%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.519 (-3%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	41,005	528,889

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,122	742 (-3%)	3,359 (-1%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	428 (-2%)	295	752	382 (+1%)	1,221	451

[dbanks12]

LGTM

[fcarreiro]

Merge activity

• Apr 12, 9:07 AM EDT: @fcarreiro merged this pull request with Graphite.