feat(avm): DSL integration of AVM recursive verifier #8405

jeanmon · 2024-09-05T16:50:25Z

Resolves #8285

AztecBot · 2024-09-09T11:04:36Z

Benchmark results

Metrics with a significant change:

avm_simulation_time_ms (FeeJuice:_increase_public_balance): 164 (+245%)
avm_simulation_time_ms (Token:mint_public): 314 (+605%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 61.2 (-90%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,765	1,562 (+1%)	704	759	778 (+2%)
proof_construction_time_sha256_30_ms	11,591 (+1%)	3,052	1,359 (-1%)	1,435 (+1%)	1,463 (+1%)
proof_construction_time_sha256_100_ms	46,478 (+2%)	12,146 (+3%)	5,922 (+2%)	5,946	5,477 (+2%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	35.0 (+3%)	58.0	88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,530	416	199 (+1%)	229 (+1%)	265
proof_construction_time_poseidon_hash_100_ms	5,674 (+1%)	1,509 (+1%)	681 (+2%)	716 (-1%)	755 (+2%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,220	92,982	177,952
l1_rollup_execution_gas	843,061	1,576,719	3,361,745
l2_block_processing_time_in_ms	259 (+1%)	434 (-5%)	824 (+1%)
l2_block_building_time_in_ms	11,504 (+1%)	22,583	45,315 (+2%)
l2_block_rollup_simulation_time_in_ms	11,504 (+1%)	22,583	45,314 (+2%)
l2_block_public_tx_process_time_in_ms	9,829 (+1%)	20,867	43,567 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,313 (-3%)	4,138 (-5%)
node_database_size_in_bytes	14,188,784 (-1%)	18,215,152
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	71.1	387 (+2%)	21,027	44,933	N/A
private-kernel-inner	138	689 (+2%)	71,803	45,067	N/A
private-kernel-reset-tiny	292 (+1%)	682	64,669	44,922	N/A
private-kernel-tail	150	128 (+2%)	50,553	57,178	N/A
base-parity	5.55 (+1%)	N/A	160	96.0	N/A
root-parity	35.0 (-1%)	N/A	73,964	96.0	N/A
base-rollup	2,628 (+1%)	N/A	189,128	664	N/A
block-root-rollup	41.2	N/A	58,217	2,448	N/A
public-kernel-setup	84.4 (-1%)	N/A	114,433	79,670	N/A
public-kernel-app-logic	98.1	N/A	114,251	79,670	N/A
public-kernel-tail	844	N/A	487,098	16,414	N/A
private-kernel-reset-small	270	N/A	66,345	45,629	N/A
private-kernel-tail-to-public	788 (+1%)	610 (+3%)	449,631	1,825	N/A
public-kernel-teardown	83.4 (-1%)	N/A	114,697	79,670	N/A
merge-rollup	20.2	N/A	38,182	664	N/A
undefined	N/A	N/A	N/A	N/A	80,405 (-1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	342
ContractInstanceDeployer:deploy	1,408	11,731	18.1 (+1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	420
FeeJuice:deploy	1,376	11,731	392
SchnorrAccount:constructor	1,312	11,731	60.0 (+1%)
SchnorrAccount:entrypoint	2,336	11,731	368 (+1%)
FeeJuice:claim	1,344	11,731	36.2 (-4%)
Token:privately_mint_private_note	1,280	11,731	70.2 (+7%)
FPC:fee_entrypoint_public	1,344	11,731	25.7 (-2%)
Token:transfer	1,312	11,731	215 (+4%)
Benchmarking:create_note	1,344	11,731	73.0 (-1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	26.5
Token:unshield	1,376	11,731	481
FPC:fee_entrypoint_private	1,376	11,731	638 (-2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	⚠️ 164 (+245%)	2,283
FeeJuice:set_portal	12.3 (-15%)	2,610
Token:constructor	76.8 (+2%)	12,960
FPC:constructor	48.7 (-3%)	7,766
FeeJuice:check_balance	36.9 (+1%)	2,002
Token:mint_public	⚠️ 314 (+605%)	4,441
Token:assert_minter_and_mint	⚠️ 61.2 (-90%)	2,921
AuthRegistry:set_authorized	39.6 (-14%)	945
FPC:prepare_fee	69.6 (-6%)	3,947
Token:transfer_public	14.0 (-21%)	8,909
FPC:pay_refund	38.3 (-1%)	4,873
Benchmarking:increment_balance	1,234	3,146
Token:_increase_public_balance	39.3 (+1%)	2,260
FPC:pay_refund_with_shielded_rebate	53.1 (+5%)	4,873

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.167 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.23 (+3%)	3.85 (-3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.116 (+3%)	0.108 (-3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.2	17.6 (-1%)	30.9 (-1%)	59.3 (-4%)	116
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.107	0.102 (-1%)	0.100 (-2%)	0.102 (-4%)	0.104 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3 (-1%)	25.8 (-1%)	44.2	82.2 (-7%)	166 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.109	0.104 (-1%)	0.106 (+3%)	0.102 (-6%)	0.105
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.2 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,416	668,302

Transaction size based on fee payment method

| Metric | |
| - | |

fcarreiro

Minor comments on our cpp files. I'll leave the actual DSL review to the crypto team.

fcarreiro · 2024-09-09T13:33:05Z

barretenberg/cpp/src/barretenberg/vm/avm/generated/flavor.cpp

@@ -2207,6 +2207,10 @@ AvmFlavor::CommitmentLabels::CommitmentLabels()
    Base::incl_mem_tag_err_counts = "INCL_MEM_TAG_ERR_COUNTS";
 };

+// Note: current de-/serialization routines are not including the padded zero univariates which are added as part of


Does this mean that we will eventually need to change something, or is it just an FYI?

AFAIK, this code is not used and therefore I did not want to adapt some code which we might remove. There are other flavors for which these serialization routines are used but not ours. Since I was not sure if there might be used in the future I did not delete this code.

fcarreiro · 2024-09-09T13:37:10Z

barretenberg/cpp/src/barretenberg/vm/avm/generated/flavor.hpp

+         *
+         * @return std::vector<FF>
+         */
+        std::vector<FF> to_field_elements() const


Please put the definition in the cpp file.

barretenberg/cpp/src/barretenberg/vm/avm/generated/flavor.hpp

lucasxia01

Looks fine in general. However, it's missing an actual noir test, so maybe that can be a followup.

barretenberg/cpp/src/barretenberg/bb/main.cpp

lucasxia01 · 2024-09-09T14:18:01Z

barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp

+
+    // Now that the circuit has been completely built, we add the output aggregation as public
+    // inputs.
+    if (!constraint_system.avm_recursion_constraints.empty()) {


if we ever try to create a circuit with both honk and avm recursion constraints, this will throw an error, but I think we can resolves this later.

error comes from calling set_recursive_proof multiple times.

I suggest that I add a comment and a reference to the issue 1095 to solve this. @lucasxia01 Ok?

sounds fine

barretenberg/cpp/src/barretenberg/dsl/acir_format/avm_recursion_constraint.test.cpp

jeanmon · 2024-09-09T15:41:00Z

Looks fine in general. However, it's missing an actual noir test, so maybe that can be a followup.

@lucasxia01 The next issue I am tackling is noir integration. (in public kernel) So, we will have to test as part of this ticket.
#7791

verification

* master: (49 commits) fix(avm): full proving kernel fix (#8468) fix: guesstimate gas for propose (#8445) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg feat(avm)!: make JUMP(I) 16-bit (#8443) feat(avm)!: variants for SET opcode (#8441) feat(avm)!: variants for MOV opcode (#8440) installer terraform has cloudfront for https support. remove http support once new aztec-up released. fix(docs): Some docs updates (#8412) feat: archiver fork block num (#8425) feat(avm-transpiler): optionally count opcode types (#8439) chore(ci): rerun ci when ready for review + don't allow draft merge (#8456) feat(avm): DSL integration of AVM recursive verifier (#8405) chore: Rename files relating to what were "instances" (#8383) fix: fmt (#8454) fix: add re-exports back (#8453) fix(bb): mac release (#8450) chore(docs): update box readme, remove duplicated features, added box install to the docs (#8254) ...

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.54.0</summary> ## [0.54.0](aztec-package-v0.53.0...aztec-package-v0.54.0) (2024-09-10) ### Features * Archiver fork block num ([#8425](#8425)) ([a9f2364](a9f2364)) ### Miscellaneous * Merge devnet to master ([#8472](#8472)) ([26706e9](26706e9)) </details> <details><summary>barretenberg.js: 0.54.0</summary> ## [0.54.0](barretenberg.js-v0.53.0...barretenberg.js-v0.54.0) (2024-09-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.54.0</summary> ## [0.54.0](aztec-packages-v0.53.0...aztec-packages-v0.54.0) (2024-09-10) ### ⚠ BREAKING CHANGES * **avm:** variants for binary operations ([#8473](#8473)) * **avm:** make JUMP(I) 16-bit ([#8443](#8443)) * **avm:** variants for SET opcode ([#8441](#8441)) * **avm:** variants for MOV opcode ([#8440](#8440)) ### Features * (bb) 128-bit challenges ([#8406](#8406)) ([d5b2397](d5b2397)) * `Module::add_item` (noir-lang/noir#5947) ([8ac81b1](8ac81b1)) * Add `Expr::as_let` (noir-lang/noir#5964) ([8ac81b1](8ac81b1)) * Add `FunctionDefinition::module` and `StructDefinition::module` (noir-lang/noir#5956) ([8ac81b1](8ac81b1)) * Add `FunctionDefinition` methods `is_unconstrained` and `set_unconstrained` (noir-lang/noir#5962) ([8ac81b1](8ac81b1)) * Add `StructDefinition::add_generic` (noir-lang/noir#5961) ([8ac81b1](8ac81b1)) * Add `StructDefinition::name` (noir-lang/noir#5960) ([8ac81b1](8ac81b1)) * Add a `panic` method to the stdlib (noir-lang/noir#5966) ([8ac81b1](8ac81b1)) * Archiver fork block num ([#8425](#8425)) ([a9f2364](a9f2364)) * Arithmetic Generics (noir-lang/noir#5950) ([8ac81b1](8ac81b1)) * **avm-transpiler:** Optionally count opcode types ([#8439](#8439)) ([21c06b5](21c06b5)) * **avm/public:** User space PublicContext::get_args_hash ([#8292](#8292)) ([56ce16a](56ce16a)) * **avm:** DSL integration of AVM recursive verifier ([#8405](#8405)) ([467120e](467120e)), closes [#8285](#8285) * **avm:** Make JUMP(I) 16-bit ([#8443](#8443)) ([5bb38b1](5bb38b1)) * **avm:** Variants for binary operations ([#8473](#8473)) ([8de1f2a](8de1f2a)) * **avm:** Variants for MOV opcode ([#8440](#8440)) ([5b27fbc](5b27fbc)) * **avm:** Variants for SET opcode ([#8441](#8441)) ([dc43306](dc43306)) * **bb:** Towards reduced polynomial memory usage ([#7990](#7990)) ([372f23c](372f23c)) * Let `nargo` and LSP work well in the stdlib (noir-lang/noir#5969) ([8ac81b1](8ac81b1)) * LSP autocompletion for attributes (noir-lang/noir#5963) ([8ac81b1](8ac81b1)) * LSP now suggests self fields and methods (noir-lang/noir#5955) ([8ac81b1](8ac81b1)) * Show doc comments in LSP (noir-lang/noir#5968) ([8ac81b1](8ac81b1)) ### Bug Fixes * Add re-exports back ([#8453](#8453)) ([b6cab90](b6cab90)) * **avm:** Full proving kernel fix ([#8468](#8468)) ([684d962](684d962)) * **bb:** Mac release ([#8450](#8450)) ([1b3f914](1b3f914)) * **docs:** Some docs updates ([#8412](#8412)) ([ad73f30](ad73f30)) * Error when `quote` is used in runtime code (noir-lang/noir#5978) ([8ac81b1](8ac81b1)) * Error when comptime functions are used in runtime code (noir-lang/noir#5976) ([8ac81b1](8ac81b1)) * Fmt ([#8454](#8454)) ([34b4a8a](34b4a8a)) * Guesstimate gas for propose ([#8445](#8445)) ([bff0338](bff0338)) * Let `derive(Eq)` work for empty structs (noir-lang/noir#5965) ([8ac81b1](8ac81b1)) * LSP document symbol didn't work for primitive impls (noir-lang/noir#5970) ([8ac81b1](8ac81b1)) * **mem2reg:** Handle aliases better when setting a known value for a load (noir-lang/noir#5959) ([8ac81b1](8ac81b1)) * **mem2reg:** Handle aliases in function last store cleanup and additional alias unit test (noir-lang/noir#5967) ([8ac81b1](8ac81b1)) * Public data reads and writes verification ([#8296](#8296)) ([ae86347](ae86347)) * Restrict keccak256_injective test input to 8 bits (noir-lang/noir#5977) ([8ac81b1](8ac81b1)) * Suggest trait attributes in LSP (noir-lang/noir#5972) ([8ac81b1](8ac81b1)) ### Miscellaneous * **bb:** Remove poly downsizing, other fast-follow from structured polys ([#8475](#8475)) ([ac88f30](ac88f30)) * **ci:** Rerun ci when ready for review + don't allow draft merge ([#8456](#8456)) ([ede16d3](ede16d3)) * **docs:** Update box readme, remove duplicated features, added box install to the docs ([#8254](#8254)) ([b747ac1](b747ac1)) * Document BoundedVec (noir-lang/noir#5974) ([8ac81b1](8ac81b1)) * Document HashMap (noir-lang/noir#5984) ([8ac81b1](8ac81b1)) * Merge devnet to master ([#8472](#8472)) ([26706e9](26706e9)) * Remove 3 unused functions warnings in the stdlib (noir-lang/noir#5973) ([8ac81b1](8ac81b1)) * Remove warnings from protocol circuits ([#8420](#8420)) ([c4dbcab](c4dbcab)) * Rename files relating to what were "instances" ([#8383](#8383)) ([a934e85](a934e85)) * Replace relative paths to noir-protocol-circuits ([1c43bae](1c43bae)) </details> <details><summary>barretenberg: 0.54.0</summary> ## [0.54.0](barretenberg-v0.53.0...barretenberg-v0.54.0) (2024-09-10) ### ⚠ BREAKING CHANGES * **avm:** variants for binary operations ([#8473](#8473)) * **avm:** make JUMP(I) 16-bit ([#8443](#8443)) * **avm:** variants for SET opcode ([#8441](#8441)) * **avm:** variants for MOV opcode ([#8440](#8440)) ### Features * (bb) 128-bit challenges ([#8406](#8406)) ([d5b2397](d5b2397)) * **avm:** DSL integration of AVM recursive verifier ([#8405](#8405)) ([467120e](467120e)), closes [#8285](#8285) * **avm:** Make JUMP(I) 16-bit ([#8443](#8443)) ([5bb38b1](5bb38b1)) * **avm:** Variants for binary operations ([#8473](#8473)) ([8de1f2a](8de1f2a)) * **avm:** Variants for MOV opcode ([#8440](#8440)) ([5b27fbc](5b27fbc)) * **avm:** Variants for SET opcode ([#8441](#8441)) ([dc43306](dc43306)) * **bb:** Towards reduced polynomial memory usage ([#7990](#7990)) ([372f23c](372f23c)) ### Bug Fixes * **avm:** Full proving kernel fix ([#8468](#8468)) ([684d962](684d962)) * **bb:** Mac release ([#8450](#8450)) ([1b3f914](1b3f914)) ### Miscellaneous * **bb:** Remove poly downsizing, other fast-follow from structured polys ([#8475](#8475)) ([ac88f30](ac88f30)) * Rename files relating to what were "instances" ([#8383](#8383)) ([a934e85](a934e85)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.54.0</summary> ## [0.54.0](AztecProtocol/aztec-packages@aztec-package-v0.53.0...aztec-package-v0.54.0) (2024-09-10) ### Features * Archiver fork block num ([#8425](AztecProtocol/aztec-packages#8425)) ([a9f2364](AztecProtocol/aztec-packages@a9f2364)) ### Miscellaneous * Merge devnet to master ([#8472](AztecProtocol/aztec-packages#8472)) ([26706e9](AztecProtocol/aztec-packages@26706e9)) </details> <details><summary>barretenberg.js: 0.54.0</summary> ## [0.54.0](AztecProtocol/aztec-packages@barretenberg.js-v0.53.0...barretenberg.js-v0.54.0) (2024-09-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.54.0</summary> ## [0.54.0](AztecProtocol/aztec-packages@aztec-packages-v0.53.0...aztec-packages-v0.54.0) (2024-09-10) ### ⚠ BREAKING CHANGES * **avm:** variants for binary operations ([#8473](AztecProtocol/aztec-packages#8473)) * **avm:** make JUMP(I) 16-bit ([#8443](AztecProtocol/aztec-packages#8443)) * **avm:** variants for SET opcode ([#8441](AztecProtocol/aztec-packages#8441)) * **avm:** variants for MOV opcode ([#8440](AztecProtocol/aztec-packages#8440)) ### Features * (bb) 128-bit challenges ([#8406](AztecProtocol/aztec-packages#8406)) ([d5b2397](AztecProtocol/aztec-packages@d5b2397)) * `Module::add_item` (noir-lang/noir#5947) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add `Expr::as_let` (noir-lang/noir#5964) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add `FunctionDefinition::module` and `StructDefinition::module` (noir-lang/noir#5956) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add `FunctionDefinition` methods `is_unconstrained` and `set_unconstrained` (noir-lang/noir#5962) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add `StructDefinition::add_generic` (noir-lang/noir#5961) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add `StructDefinition::name` (noir-lang/noir#5960) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Add a `panic` method to the stdlib (noir-lang/noir#5966) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Archiver fork block num ([#8425](AztecProtocol/aztec-packages#8425)) ([a9f2364](AztecProtocol/aztec-packages@a9f2364)) * Arithmetic Generics (noir-lang/noir#5950) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * **avm-transpiler:** Optionally count opcode types ([#8439](AztecProtocol/aztec-packages#8439)) ([21c06b5](AztecProtocol/aztec-packages@21c06b5)) * **avm/public:** User space PublicContext::get_args_hash ([#8292](AztecProtocol/aztec-packages#8292)) ([56ce16a](AztecProtocol/aztec-packages@56ce16a)) * **avm:** DSL integration of AVM recursive verifier ([#8405](AztecProtocol/aztec-packages#8405)) ([467120e](AztecProtocol/aztec-packages@467120e)), closes [#8285](AztecProtocol/aztec-packages#8285) * **avm:** Make JUMP(I) 16-bit ([#8443](AztecProtocol/aztec-packages#8443)) ([5bb38b1](AztecProtocol/aztec-packages@5bb38b1)) * **avm:** Variants for binary operations ([#8473](AztecProtocol/aztec-packages#8473)) ([8de1f2a](AztecProtocol/aztec-packages@8de1f2a)) * **avm:** Variants for MOV opcode ([#8440](AztecProtocol/aztec-packages#8440)) ([5b27fbc](AztecProtocol/aztec-packages@5b27fbc)) * **avm:** Variants for SET opcode ([#8441](AztecProtocol/aztec-packages#8441)) ([dc43306](AztecProtocol/aztec-packages@dc43306)) * **bb:** Towards reduced polynomial memory usage ([#7990](AztecProtocol/aztec-packages#7990)) ([372f23c](AztecProtocol/aztec-packages@372f23c)) * Let `nargo` and LSP work well in the stdlib (noir-lang/noir#5969) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * LSP autocompletion for attributes (noir-lang/noir#5963) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * LSP now suggests self fields and methods (noir-lang/noir#5955) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Show doc comments in LSP (noir-lang/noir#5968) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) ### Bug Fixes * Add re-exports back ([#8453](AztecProtocol/aztec-packages#8453)) ([b6cab90](AztecProtocol/aztec-packages@b6cab90)) * **avm:** Full proving kernel fix ([#8468](AztecProtocol/aztec-packages#8468)) ([684d962](AztecProtocol/aztec-packages@684d962)) * **bb:** Mac release ([#8450](AztecProtocol/aztec-packages#8450)) ([1b3f914](AztecProtocol/aztec-packages@1b3f914)) * **docs:** Some docs updates ([#8412](AztecProtocol/aztec-packages#8412)) ([ad73f30](AztecProtocol/aztec-packages@ad73f30)) * Error when `quote` is used in runtime code (noir-lang/noir#5978) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Error when comptime functions are used in runtime code (noir-lang/noir#5976) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Fmt ([#8454](AztecProtocol/aztec-packages#8454)) ([34b4a8a](AztecProtocol/aztec-packages@34b4a8a)) * Guesstimate gas for propose ([#8445](AztecProtocol/aztec-packages#8445)) ([bff0338](AztecProtocol/aztec-packages@bff0338)) * Let `derive(Eq)` work for empty structs (noir-lang/noir#5965) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * LSP document symbol didn't work for primitive impls (noir-lang/noir#5970) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * **mem2reg:** Handle aliases better when setting a known value for a load (noir-lang/noir#5959) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * **mem2reg:** Handle aliases in function last store cleanup and additional alias unit test (noir-lang/noir#5967) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Public data reads and writes verification ([#8296](AztecProtocol/aztec-packages#8296)) ([ae86347](AztecProtocol/aztec-packages@ae86347)) * Restrict keccak256_injective test input to 8 bits (noir-lang/noir#5977) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Suggest trait attributes in LSP (noir-lang/noir#5972) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) ### Miscellaneous * **bb:** Remove poly downsizing, other fast-follow from structured polys ([#8475](AztecProtocol/aztec-packages#8475)) ([ac88f30](AztecProtocol/aztec-packages@ac88f30)) * **ci:** Rerun ci when ready for review + don't allow draft merge ([#8456](AztecProtocol/aztec-packages#8456)) ([ede16d3](AztecProtocol/aztec-packages@ede16d3)) * **docs:** Update box readme, remove duplicated features, added box install to the docs ([#8254](AztecProtocol/aztec-packages#8254)) ([b747ac1](AztecProtocol/aztec-packages@b747ac1)) * Document BoundedVec (noir-lang/noir#5974) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Document HashMap (noir-lang/noir#5984) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Merge devnet to master ([#8472](AztecProtocol/aztec-packages#8472)) ([26706e9](AztecProtocol/aztec-packages@26706e9)) * Remove 3 unused functions warnings in the stdlib (noir-lang/noir#5973) ([8ac81b1](AztecProtocol/aztec-packages@8ac81b1)) * Remove warnings from protocol circuits ([#8420](AztecProtocol/aztec-packages#8420)) ([c4dbcab](AztecProtocol/aztec-packages@c4dbcab)) * Rename files relating to what were "instances" ([#8383](AztecProtocol/aztec-packages#8383)) ([a934e85](AztecProtocol/aztec-packages@a934e85)) * Replace relative paths to noir-protocol-circuits ([1c43bae](AztecProtocol/aztec-packages@1c43bae)) </details> <details><summary>barretenberg: 0.54.0</summary> ## [0.54.0](AztecProtocol/aztec-packages@barretenberg-v0.53.0...barretenberg-v0.54.0) (2024-09-10) ### ⚠ BREAKING CHANGES * **avm:** variants for binary operations ([#8473](AztecProtocol/aztec-packages#8473)) * **avm:** make JUMP(I) 16-bit ([#8443](AztecProtocol/aztec-packages#8443)) * **avm:** variants for SET opcode ([#8441](AztecProtocol/aztec-packages#8441)) * **avm:** variants for MOV opcode ([#8440](AztecProtocol/aztec-packages#8440)) ### Features * (bb) 128-bit challenges ([#8406](AztecProtocol/aztec-packages#8406)) ([d5b2397](AztecProtocol/aztec-packages@d5b2397)) * **avm:** DSL integration of AVM recursive verifier ([#8405](AztecProtocol/aztec-packages#8405)) ([467120e](AztecProtocol/aztec-packages@467120e)), closes [#8285](AztecProtocol/aztec-packages#8285) * **avm:** Make JUMP(I) 16-bit ([#8443](AztecProtocol/aztec-packages#8443)) ([5bb38b1](AztecProtocol/aztec-packages@5bb38b1)) * **avm:** Variants for binary operations ([#8473](AztecProtocol/aztec-packages#8473)) ([8de1f2a](AztecProtocol/aztec-packages@8de1f2a)) * **avm:** Variants for MOV opcode ([#8440](AztecProtocol/aztec-packages#8440)) ([5b27fbc](AztecProtocol/aztec-packages@5b27fbc)) * **avm:** Variants for SET opcode ([#8441](AztecProtocol/aztec-packages#8441)) ([dc43306](AztecProtocol/aztec-packages@dc43306)) * **bb:** Towards reduced polynomial memory usage ([#7990](AztecProtocol/aztec-packages#7990)) ([372f23c](AztecProtocol/aztec-packages@372f23c)) ### Bug Fixes * **avm:** Full proving kernel fix ([#8468](AztecProtocol/aztec-packages#8468)) ([684d962](AztecProtocol/aztec-packages@684d962)) * **bb:** Mac release ([#8450](AztecProtocol/aztec-packages#8450)) ([1b3f914](AztecProtocol/aztec-packages@1b3f914)) ### Miscellaneous * **bb:** Remove poly downsizing, other fast-follow from structured polys ([#8475](AztecProtocol/aztec-packages#8475)) ([ac88f30](AztecProtocol/aztec-packages@ac88f30)) * Rename files relating to what were "instances" ([#8383](AztecProtocol/aztec-packages#8383)) ([a934e85](AztecProtocol/aztec-packages@a934e85)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

jeanmon force-pushed the jm/8285-avm-recursive-acir-dsl branch 3 times, most recently from 93a0a70 to 5c95ec0 Compare September 9, 2024 07:52

jeanmon marked this pull request as ready for review September 9, 2024 10:09

jeanmon requested review from IlyasRidhuan, fcarreiro and Maddiaa0 as code owners September 9, 2024 10:09

jeanmon force-pushed the jm/8285-avm-recursive-acir-dsl branch 2 times, most recently from 4f19447 to da290ae Compare September 9, 2024 10:17

jeanmon force-pushed the jm/8285-avm-recursive-acir-dsl branch from da290ae to 1d5b3b4 Compare September 9, 2024 11:45

jeanmon requested a review from lucasxia01 September 9, 2024 13:30

fcarreiro reviewed Sep 9, 2024

View reviewed changes

lucasxia01 approved these changes Sep 9, 2024

View reviewed changes

jeanmon added 6 commits September 9, 2024 15:43

8285: typo in README

59ca283

8285: takes an aggregation object as parameter of AVM recursive

3d6352d

verification

8285: dsl for avm recursive verifier

0d4f15b

8285: fix gcc errors

5fb3335

8285: unit test for dsl avm recursive verifier

db13979

8285: addressing of review comments

1110861

jeanmon force-pushed the jm/8285-avm-recursive-acir-dsl branch from 1d5b3b4 to 1110861 Compare September 9, 2024 15:44

8285: fixes after rebase on master

796ce73

jeanmon merged commit 467120e into master Sep 9, 2024
99 checks passed

jeanmon deleted the jm/8285-avm-recursive-acir-dsl branch September 9, 2024 17:03

TomAFrench mentioned this pull request Sep 12, 2024

Nightly release failed #8511

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm): DSL integration of AVM recursive verifier #8405

feat(avm): DSL integration of AVM recursive verifier #8405

jeanmon commented Sep 5, 2024

AztecBot commented Sep 9, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

fcarreiro left a comment

fcarreiro Sep 9, 2024

jeanmon Sep 9, 2024

fcarreiro Sep 9, 2024

lucasxia01 left a comment

lucasxia01 Sep 9, 2024

lucasxia01 Sep 9, 2024

jeanmon Sep 9, 2024

lucasxia01 Sep 9, 2024

jeanmon commented Sep 9, 2024

feat(avm): DSL integration of AVM recursive verifier #8405

feat(avm): DSL integration of AVM recursive verifier #8405

Conversation

jeanmon commented Sep 5, 2024

AztecBot commented Sep 9, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

fcarreiro left a comment

Choose a reason for hiding this comment

fcarreiro Sep 9, 2024

Choose a reason for hiding this comment

jeanmon Sep 9, 2024

Choose a reason for hiding this comment

fcarreiro Sep 9, 2024

Choose a reason for hiding this comment

lucasxia01 left a comment

Choose a reason for hiding this comment

lucasxia01 Sep 9, 2024

Choose a reason for hiding this comment

lucasxia01 Sep 9, 2024

Choose a reason for hiding this comment

jeanmon Sep 9, 2024

Choose a reason for hiding this comment

lucasxia01 Sep 9, 2024

Choose a reason for hiding this comment

jeanmon commented Sep 9, 2024

AztecBot commented Sep 9, 2024 •

edited

Loading