fix(avm): full proving kernel fix

[IlyasRidhuan]

Please read contributing guidelines and remove this line.

[IlyasRidhuan]

• fix(avm): full proving kernel fix #8468 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @IlyasRidhuan and the rest of your teammates on Graphite

[jeanmon]

LGTM.

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_poseidon_hash_ms (4): 48.0 (+41%)
• avm_simulation_time_ms (FeeJuice:_increase_public_balance): 167 (+247%)
• avm_simulation_time_ms (Token:mint_public): 323 (+551%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 64.6 (-90%)
• avm_simulation_time_ms (Token:transfer_public): 26.7 (+107%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,739	1,549	706	755 (-3%)	777
proof_construction_time_sha256_30_ms	11,797	3,146	1,396	1,425 (-2%)	1,474
proof_construction_time_sha256_100_ms	43,914	11,734	5,389	5,993 (+5%)	5,381
proof_construction_time_poseidon_hash_ms	78.0	⚠️ 48.0 (+41%)	34.0	57.0 (-5%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,525	415	198	223 (-3%)	267
proof_construction_time_poseidon_hash_100_ms	5,640	1,514	673 (+1%)	724 (-2%)	756 (+2%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,420	7,940	14,948
l1_rollup_calldata_gas	50,500	93,166	178,520
l1_rollup_execution_gas	843,633	1,577,195	3,362,606
l2_block_processing_time_in_ms	256 (-1%)	456 (+2%)	815
l2_block_building_time_in_ms	11,466	22,647 (+1%)	44,855
l2_block_rollup_simulation_time_in_ms	11,466	22,646 (+1%)	44,854
l2_block_public_tx_process_time_in_ms	9,769 (-1%)	20,928 (+1%)	43,099

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,495 (+6%)	4,566 (+7%)
node_database_size_in_bytes	14,156,016 (-1%)	18,206,960
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	75.4 (-1%)	376 (+1%)	21,027	44,933	N/A
private-kernel-inner	140	677 (-2%)	71,803	45,067	N/A
private-kernel-reset-tiny	286 (-1%)	670 (+1%)	64,669	44,922	N/A
private-kernel-tail	150	126 (-2%)	50,553	57,178	N/A
base-parity	5.55 (+1%)	N/A	160	96.0	N/A
root-parity	34.9 (-1%)	N/A	73,964	96.0	N/A
base-rollup	2,583 (-1%)	N/A	189,128	664	N/A
block-root-rollup	41.2 (+1%)	N/A	58,217	2,448	N/A
public-kernel-setup	83.4 (-1%)	N/A	114,433	79,670	N/A
public-kernel-app-logic	97.9 (+1%)	N/A	114,251	79,670	N/A
public-kernel-tail	842	N/A	487,098	16,414	N/A
private-kernel-reset-small	269	N/A	66,345	45,629	N/A
private-kernel-tail-to-public	1,430 (-6%)	616 (+5%)	449,631	1,825	N/A
public-kernel-teardown	83.4	N/A	114,697	79,670	N/A
merge-rollup	20.1 (+1%)	N/A	38,182	664	N/A
undefined	N/A	N/A	N/A	N/A	83,910 (+2%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	338 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.1
MultiCallEntrypoint:entrypoint	1,920	11,731	416
FeeJuice:deploy	1,376	11,731	389 (+1%)
SchnorrAccount:constructor	1,312	11,731	59.7 (+1%)
SchnorrAccount:entrypoint	2,336	11,731	366
FeeJuice:claim	1,344	11,731	38.5 (+12%)
Token:privately_mint_private_note	1,280	11,731	68.9 (+4%)
FPC:fee_entrypoint_public	1,344	11,731	26.3 (+11%)
Token:transfer	1,312	11,731	209
Benchmarking:create_note	1,344	11,731	73.0 (-1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	26.4
Token:unshield	1,376	11,731	485
FPC:fee_entrypoint_private	1,376	11,731	653 (+2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	⚠️ 167 (+247%)	1,732
FeeJuice:set_portal	12.4 (+17%)	1,746
Token:constructor	77.3 (+5%)	9,230
FPC:constructor	47.4 (+5%)	5,377
FeeJuice:check_balance	36.8 (-1%)	1,467
Token:mint_public	⚠️ 323 (+551%)	3,339
Token:assert_minter_and_mint	⚠️ 64.6 (-90%)	2,193
AuthRegistry:set_authorized	47.2 (+19%)	670
FPC:prepare_fee	70.4 (+8%)	2,621
Token:transfer_public	⚠️ 26.7 (+107%)	6,306
FPC:pay_refund	50.0 (+25%)	3,282
Benchmarking:increment_balance	1,232 (+1%)	2,124
Token:_increase_public_balance	49.3 (+11%)	1,738
FPC:pay_refund_with_shielded_rebate	49.6 (-1%)	3,282

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.198 (-25%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.21 (+1%)	3.89	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.115 (+1%)	0.109	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.3 (+1%)	18.1 (+4%)	30.9 (+2%)	60.8 (+2%)	116 (+4%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108 (+1%)	0.105 (+3%)	0.100 (+2%)	0.104 (+1%)	0.103 (+3%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.4	26.6 (+1%)	44.1	85.2 (-1%)	165 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.110	0.107	0.106	0.105 (-3%)	0.105 (+2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.3	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,416	668,302

Transaction size based on fee payment method

| Metric | |
| - | |