-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report]: Microsoft.Compute\virtualMachines\readme.md does not have correct syntax for joining a domain #1595
Labels
Comments
Thanks! Do you want to make a PR to solve this issue? |
Sure, I’d be happy to.
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows
From: Rainer ***@***.***>
Sent: Tuesday, June 28, 2022 12:16 PM
To: ***@***.***>
Cc: Jim ***@***.***>; ***@***.***>
Subject: Re: [Azure/ResourceModules] [Bug Report]: Microsoft.Compute\virtualMachines\readme.md does not have correct syntax for joining a domain (Issue #1595)
Thanks! Do you want to make a PR to solve this issue?
—
Reply to this email directly, view it on GitHub<#1595 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJEVPC32RBJYR6JPZBSYF2LVRMQNRANCNFSM5Z23ULYA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
jriekse5555
added a commit
to jriekse5555/ResourceModules
that referenced
this issue
Jul 23, 2022
Readme PR per request by Rainer Halanek PR related to bug I submitted (Azure#1595). Updated the domain join settings to the correct ones to domain join correctly. The previous ones in the readme do not work and would attempt to join a blank workgroup. Reference: https://docs.microsoft.com/en-us/azure/active-directory-domain-services/join-windows-vm-template
10 tasks
10 tasks
eriqua
pushed a commit
that referenced
this issue
Aug 1, 2022
* Update readme.md Readme PR per request by Rainer Halanek PR related to bug I submitted (#1595). Updated the domain join settings to the correct ones to domain join correctly. The previous ones in the readme do not work and would attempt to join a blank workgroup. Reference: https://docs.microsoft.com/en-us/azure/active-directory-domain-services/join-windows-vm-template * Update deploy.bicep @description on the extensionDomainJoinPassword param to match readme change In response to @ahmadabdalla 's request in the PR review. Module param description updated to reflect change in readme to correct domain join settings. * Update readme.md Updated same changes in domain join setting parameters as in vm readme. Also changed parameter description in readme * Update readme.md Updated the readme parameter description to match the changes. * Update deploy.bicep Updated parameter description for extensionDomainJoinPassword to match changes * Update deploy.bicep Description for parameter updated to match changes in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the bug
Based on the module this is the correct parameter to domain join a VM:
"extensionDomainJoinConfig": {
"value": {
"enabled": true,
"settings": {
"name": "contoso.com",
"user": "test.user@testcompany.com",
"ouPath": "OU=testOU; DC=contoso; DC=com",
"restart": true,
"options": 3
}
}
},
Below is what is listed in the readme. The domain and domainJoin prefix on the setting values below will prevent this from working. The end result will be an exception trying to join Workgroup ''
"extensionDomainJoinConfig": {
"value": {
"enabled": true,
"settings": {
"domainName": "contoso.com",
"domainJoinUser": "test.user@testcompany.com",
"domainJoinOU": "OU=testOU; DC=contoso; DC=com",
"domainJoinRestart": true,
"domainJoinOptions": 3
}
}
},
To reproduce
Deploy via the readme settings and see exception when trying "to join Workgroup '' "
Code snippet
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: