-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes] Update VM domainJoin parameter usage #1711
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readme PR per request by Rainer Halanek PR related to bug I submitted (Azure#1595). Updated the domain join settings to the correct ones to domain join correctly. The previous ones in the readme do not work and would attempt to join a blank workgroup. Reference: https://docs.microsoft.com/en-us/azure/active-directory-domain-services/join-windows-vm-template
eriqua
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
[cat] modules
category: modules
labels
Jul 23, 2022
ahmadabdalla
requested changes
Jul 24, 2022
…aram to match readme change In response to @ahmadabdalla 's request in the PR review. Module param description updated to reflect change in readme to correct domain join settings.
ahmadabdalla
requested changes
Jul 24, 2022
Updated same changes in domain join setting parameters as in vm readme. Also changed parameter description in readme
Updated the readme parameter description to match the changes.
Updated parameter description for extensionDomainJoinPassword to match changes
Description for parameter updated to match changes in readme
ahmadabdalla
added
blocked
if an issue is blocked
and removed
blocked
if an issue is blocked
labels
Jul 29, 2022
ahmadabdalla
approved these changes
Jul 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @jriekse5555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[cat] modules
category: modules
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme PR per request by Rainer Halanek PR related to bug I submitted (#1595). Updated the domain join settings to the correct ones to domain join correctly. The previous ones in the readme do not work and would attempt to join a blank workgroup. Reference: https://docs.microsoft.com/en-us/azure/active-directory-domain-services/join-windows-vm-template
Description
Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist