Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Service bus private networking ACL #1453

Merged
merged 41 commits into from
Jul 7, 2022
Merged

[Modules] Service bus private networking ACL #1453

merged 41 commits into from
Jul 7, 2022

Conversation

ChrisSidebotham
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham commented May 31, 2022 •
edited
Loading

Description

Private Networking for Azure Service Bus

Adding of the networkRuleSets Module to allow network configurations to be dynamically created for Azure Service Bus based on SKU and Private Endpoint

Pipeline references

Pipeline
ServiceBus: Namespaces

https://github.com/ChrisSidebotham/ResourceModules/actions/runs/2410217790

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels May 31, 2022
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) June 1, 2022 07:57
@eriqua eriqua changed the title Service bus private networking ACL [Module] Service bus private networking ACL Jun 1, 2022
ChrisSidebotham and others added 5 commits June 1, 2022 14:29
@ChrisSidebotham @eriqua
removed whitespace
46ebf09 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@ChrisSidebotham @eriqua
Applied suggestions from @eriqua
6d4a446 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@ChrisSidebotham
Added param for Azure Trusted Services
6ca5b3e 
Trusted Services set default is true
@ChrisSidebotham
updated readme to matech changes in #6d4a446
ae572b7
@ChrisSidebotham
Updated version following new param addition
cea8697
@ChrisSidebotham @MariusStorhaug
Apply suggestions from Marius code review
3c69a58 
NetworkACL => NetworkRuleSet
Version Change

Co-authored-by: Marius Storhaug <marstor@hotmail.com>
eriqua
eriqua reviewed Jun 6, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further team discussion needed to align on the implementation as this fits into a wider topic (ref issue #819)

ChrisSidebotham and others added 2 commits June 6, 2022 12:29
@ChrisSidebotham @MariusStorhaug
Apply suggestions from Marius code review
4ec874e 
Friendly name of resource change to match resource type

Co-authored-by: Marius Storhaug <marstor@hotmail.com>
@ChrisSidebotham @MariusStorhaug
Update arm/Microsoft.ServiceBus/namespaces/networkRuleSets/readme.md
134230a 
Removed TODO's

Co-authored-by: Marius Storhaug <marstor@hotmail.com>
@eriqua eriqua mentioned this pull request Jun 15, 2022
Closed
15 tasks
@eriqua eriqua mentioned this pull request Jul 4, 2022
Merged
4 tasks
@ChrisSidebotham ChrisSidebotham requested a review from a team as a code owner July 5, 2022 12:00
ChrisSidebotham and others added 2 commits July 6, 2022 11:36
@ChrisSidebotham @eriqua
Update condition on nsr deployments
b1b9558 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@ChrisSidebotham @eriqua
Update params template
8a8b24b 
params set as defaults in code

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@ChrisSidebotham @AlexanderSehr
Adding param for reinforced telemetry
d741873 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
eriqua
eriqua approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua dismissed MariusStorhaug’s stale review July 7, 2022 11:14

All conversations resolved

@MariusStorhaug MariusStorhaug merged commit b0505a6 into Azure:main Jul 7, 2022
@ChrisSidebotham ChrisSidebotham deleted the service-bus-private-networking branch July 7, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr left review comments

@eriqua eriqua eriqua approved these changes

@MariusStorhaug MariusStorhaug Awaiting requested review from MariusStorhaug

Assignees

@ChrisSidebotham ChrisSidebotham

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisSidebotham @AlexanderSehr @MariusStorhaug @eriqua