Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Network Interface module API Version #1722

Merged
merged 1 commit into from
Jul 29, 2022
Merged

[Modules] Updated Network Interface module API Version #1722

merged 1 commit into from
Jul 29, 2022

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Jul 29, 2022 •
edited
Loading

closes #1718

Description

  • Updated nic module API version and documentation.
  • Updated VM documentation for the new nic api version

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: NetworkInterfaces
Compute: VirtualMachines

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla requested a review from a team as a code owner July 29, 2022 07:29
@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules [prio] high importance of the issue: high priority labels Jul 29, 2022
@ahmadabdalla ahmadabdalla added this to the Release 0.7 milestone Jul 29, 2022
@ahmadabdalla ahmadabdalla mentioned this pull request Jul 29, 2022
Merged
10 tasks
@eriqua eriqua changed the title Updated Network Interface module API Version [Modules] Updated Network Interface module API Version Jul 29, 2022
eriqua
eriqua approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@ahmadabdalla ahmadabdalla merged commit d3738f6 into main Jul 29, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/nicUpdates branch July 29, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@ahmadabdalla ahmadabdalla

Labels
bug Something isn't working [cat] modules category: modules [prio] high importance of the issue: high priority
Projects
Backlog
Status: Done
Milestone
Release 0.7
2 participants
@ahmadabdalla @eriqua