-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes] Resource removal stage attempts to remove dependency resources #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadabdalla
added
bug
Something isn't working
[prio] high
importance of the issue: high priority
[cat] pipelines
category: pipelines
[cat] github
category: GitHub
[cat] azure devops
category: Azure DevOps
labels
Aug 13, 2022
Unit Test Results 1 files ± 0 1 suites ±0 1m 10s ⏱️ +25s Results for commit 974344c. ± Comparison against base commit c05d706. This pull request removes 87 and adds 164 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
AlexanderSehr
changed the title
[Bug Fix] Resource removal stage attempts to remove dependency resources
[Fixes] Resource removal stage attempts to remove dependency resources
Aug 14, 2022
AlexanderSehr
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
[cat] azure devops
category: Azure DevOps
[cat] github
category: GitHub
[cat] pipelines
category: pipelines
[prio] high
importance of the issue: high priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1781
Closes #1782
Description
Add support for token replacement for the dependency resources during the token replacement step in the deployment. The reason is that the removal step relies on dependency resources parameter files tokens to be replaced, and given that we do not have a value for the
localToken_namePrefix
, it will be replaced by empty thus impacting dependency resources risk being removed. Replacing the tokens for dependency files before the removal step kicks in guarantees that there are no tokens that need to be swappedFuture feature suggestion:
Pipeline references
Before
After
ADO
Type of Change
Checklist