Static Anycast Gateway HLD #837
Conversation
|
|
There was a problem hiding this comment.
General comments:
- The HLD is missing a high level description before even discussing the config db which should be followed by yang model.
Please check the HLD Template guidelines (https://github.com/Azure/SONiC/blob/master/doc/hld_template.md) it is very helpful to understand the feature and be able to review the code later on. - The CLI as described is very high level and the part of the interface does not define and of the checkers expected on the CLI level. The CLI itself IMO should be described in the same way we have in the command reference md file.
- The flow is very high level and does to explain clearly (although there is a flow image). i don't see any reference to the SAI it self and the parameters used. Missing flow of vlan interface delete, not the sag part.
- The default behaviour should be clearly mentioned. it is disabled by default.
- It was mentioned it must go with VXLAN/EVPN. Is there any validation? what will happen if not? what tis the expected behaviour? ignored? error?
|
@kperumalbfn @venkatmahalingam @preetham-singh @hasan-brcm @dgsudharsan @liat-grozovik |
|
All related PR's are sent and updated tracking table in this PR. |
|
@superchild would you please add the test PR into the code PR list? Thanks. |
@zhangyanzhao What is the test PR?
sonic-swss-common#540 and sonic-utilities#1887 don't have reviewer yet, could you please assign someone help to review? Thanks. |
yxieca
force-pushed
the
master
branch
2 times, most recently
from
8498931
to
8837dc2
Compare
|
Reviewers, can you please help to finish your review on this feature? Thanks. |
|
@superchild could you please sign the easyCLA? |
|
@liat-grozovik thanks for your reminder, already signed. |
|
@liat-grozovik can you please let me know if we can merge this PR? Nvidia is the registered reviewer. Thanks. |
|
It was reviewed by Nvidia and approved (@dgsudharsan and @Junchao-Mellanox ). please go a head and merge the HLD. |
@superchild can you please address this comment? Thanks. |
How did you do it? Bases on the SAG HLD sonic-net/SONiC#837, design needed test cases to verify its functionality. How did you verify/test it? Executing all SAG sonic-mgmt test cases using edge-core devices Any platform specific information? N/A Supported testbed topology if it's a new test case? ptf32, ptf64
How did you do it? Bases on the SAG HLD sonic-net/SONiC#837, design needed test cases to verify its functionality. How did you verify/test it? Executing all SAG sonic-mgmt test cases using edge-core devices Any platform specific information? N/A Supported testbed topology if it's a new test case? ptf32, ptf64
|
HLD has been reviewed in SONiC community on 8/24/2021 |
|
HLD was reviewed and approved by reviewers, merge the HLD. |
|
@liat-grozovik NVIDIA is the reviewing company, can you please merge this PR? Thanks. |
How did you do it? Bases on the SAG HLD sonic-net/SONiC#837, design needed test cases to verify its functionality. How did you verify/test it? Executing all SAG sonic-mgmt test cases using edge-core devices Any platform specific information? N/A Supported testbed topology if it's a new test case? ptf32, ptf64
Add SAG table definition for static anycast gateway. Static anycast gateway HLD [#837](sonic-net/SONiC#837)
|
New Updated PRs: |
Static Anycast Gateway (SAG) HLD
Add SAG implementation#2881