[SAG]: Add SAG implementation #1974

superchild · 2021-10-20T07:26:09Z

What I did

Add static anycast gateway implementation in intfmgr/intforch
Revise routeroch's API to handle add/delete IPv6 link-local route
Add related testcases

Why I did it

To support static anycast gateway feature

How I verified it

Using vs environment to execute the test cases, all test cases passed

Details if related

SAG HLD #837

Signed-off-by: Jimi Chen jimi_chen@edge-core.com

superchild · 2021-10-28T01:00:44Z

@prsunny could you please help to review the code?
The related schema changed PR is sonic-swss-common#540, but it doesn't have reviewer yet.
Could you please help to assign someone to review?
Thanks.

kperumalbfn · 2021-11-15T19:58:25Z

tests/mock_tests/aclorch_ut.cpp

@@ -327,8 +327,13 @@ namespace aclorch_test
            ASSERT_EQ(gVrfOrch, nullptr);
            gVrfOrch = new VRFOrch(m_app_db.get(), APP_VRF_TABLE_NAME, m_state_db.get(), STATE_VRF_OBJECT_TABLE_NAME);

+            vector<table_name_with_pri_t> intf_tables = {
+                { APP_INTF_TABLE_NAME,  IntfsOrch::intfsorch_pri},
+                { APP_SAG_TABLE_NAME,   IntfsOrch::intfsorch_pri}


HLD has only CONFIG_DB for SAG MAC. Why do we need additional APP_DB? Any change between config and app_db?

The purpose to carry SAG MAC to app_db is to let intsforch to handle IPv6 link-local route add/delete in VRFs.
I'll update HLD to add the SAG table used in app_db.

kperumalbfn · 2021-11-15T20:01:51Z

orchagent/intfsorch.cpp

+                SWSS_LOG_NOTICE("Created link local ipv6 route %s to cpu in default VRF", linklocal_prefix.to_string().c_str());
+
+                // add link local route for existed vrf
+                for (auto vrf_id: vrf_ids)


Do we need refcount or other additional checks to see when SAG MAC is deleted but some interfaces are enabled with SAG to use that MAC?

This part handles the IPv6 link-local route to ASIC_DB in VRFs.
In current design, the IPv6 link-local route to ASIC_DB in default VRF is added when routeorch init.
When SAG mac is added, it needs to add IPv6 link-local route to existed VRfs.
To simplify the design, I only use m_sagMac to store the SAG MAC info in intfsorch to handle the change.

kperumalbfn · 2021-11-15T20:06:03Z

orchagent/intfsorch.cpp

@@ -652,6 +659,17 @@ void IntfsOrch::doTask(Consumer &consumer)
            }
        }

+        //TODO: consider to refactor for different private function
+        if (table_name == APP_SAG_TABLE_NAME)


Could you update sonic-swss/doc with the new CONFIG_DB or APP_DB tables.

Please update the HLD if you are planning to have additional APP_DB tables

I'll update the HLD to address the APP_DB table change.

superchild · 2021-11-16T02:18:28Z

@kperumalbfn
The new SAG_TABLE added in APPL_DB is updated in the HLD PR, please help to check.

zhangyanzhao · 2021-12-02T16:24:04Z

all the comments are addressed, @prsunny please help to review to see if you are ok to approve. Branch conflicts and build failure need be addressed by @superchild

superchild · 2021-12-03T07:44:58Z

@zhangyanzhao , the code conflict has been resolved.
For the build failure, it's due to sonic-swss-common#540 not merged yet.
For that schema PR, the build failure seems timeout for the build task.
I don't have the permission to trigger the CI build again, could you help to trigger the build again?

superchild · 2021-12-10T06:03:56Z

@prsunny could you please help to view?
@zhangyanzhao the CI build needs sonic-swss-common#540 to be merged first, and then I'll trigger another build to test

…t#1974) What I did fixes sonic-net/sonic-buildimage#9411 on multi-asic platform, config reload CLI was not working without -f option. This was because swss_ready function was checking status of swss.service and multi-asic platform will not have swss.service, it will have per-namespace swss service. How I did it Fix swss_ready function to check all swss services status running on the platform.

* Fix change SAG mac doesn't reset MAC address on VLAN interface * Fix compile error for update admin status api change

superchild · 2022-05-06T13:42:34Z

@prsunny @kperumalbfn
Could you help to review?
Thanks.

prsunny · 2022-05-07T00:32:05Z

@venkatmahalingam , please review

zhangyanzhao · 2023-02-01T07:29:29Z

Added maintainers as reviewers. Can you please help to finish the review and merge? This feature has been delayed from 202211 release. Thanks.

cfgmgr/intfmgr.cpp

cfgmgr/intfmgrd.cpp

orchagent/intfsorch.cpp

zhangyanzhao · 2023-05-09T06:17:36Z

@Junchao-Mellanox can you please help to approve the PR if you are good? Thanks.
@superchild can you please help to resolve the conflict? Thanks.

Junchao-Mellanox · 2023-05-09T09:31:32Z

hi @zhangyanzhao , i will approve once all comments are fixed.

superchild · 2023-06-16T03:34:35Z

@Junchao-Mellanox ,
Please help to review again for the latest commit, it should address all comments.

tests/test_sag.py

* Fix test cases errors * Refine logic to keep it simple

zhangyanzhao · 2024-01-24T23:20:28Z

/azpw run "Azure.sonic-swss"

zhangyanzhao · 2024-01-24T23:22:19Z

/azpw run

zhangyanzhao · 2024-01-24T23:22:37Z

@superchild can you please fix the conflicts? Thanks.

linux-foundation-easycla · 2024-02-07T00:58:39Z

The committers listed above are authorized under a signed CLA.

✅ login: superchild / name: Jimi Chen (007854e, 8548d1b, 0e92c96, fb90a04, a0de06d, 53e2225, 42d4951, 371be65, 75ddeea, 4d092b2, b708ae4, 2139a2e, 4e4afb3, 4a6d856)
✅ login: linarnan / name: linarnan (da1f6c0, 69c34c3, 62a293d, 97b3432)

superchild · 2024-02-07T01:03:10Z

@linarnan please help to sign the easyCLA

* Fixes mock test failure * Fixes mock test run failure fixes pipeline run failure FAIL: p4orch_tests_usan ======================= ../../../orchagent/vrforch.cpp:113:41: runtime error: member call on null pointer of type 'struct RouteOrch' ../../../orchagent/vrforch.cpp:113:41: runtime error: member access within null pointer of type 'struct RouteOrch' FAIL p4orch_tests_usan (exit status: 139)

superchild · 2024-02-07T04:02:36Z

/azpw run

mssonicbld · 2024-02-07T04:02:38Z

/AzurePipelines run

azure-pipelines · 2024-02-07T04:02:48Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2024-04-11T16:52:12Z

@superchild can you please handle conflict so i can go a head and merge?

superchild · 2024-04-18T13:13:03Z

@liat-grozovik
I don't work on this project anymore and don't have related build machine to test.
I'll suggest someone can help to finish this or send the other PR.

linarnan · 2024-04-23T08:42:23Z

@liat-grozovik

I am from Edgecore, and will continue this work, thx

* Fixes mock test failure * Fixes mock test run failure fixes pipeline run failure FAIL: p4orch_tests_usan ======================= ../../../orchagent/vrforch.cpp:113:41: runtime error: member call on null pointer of type 'struct RouteOrch' ../../../orchagent/vrforch.cpp:113:41: runtime error: member access within null pointer of type 'struct RouteOrch' FAIL p4orch_tests_usan (exit status: 139) * Fixed orchagent crash in VM with the Qos BUFFER_QUEUE|system-port|Queue-id-range config (sonic-net#3050) * Fixed orchagent crash in VM with the Qos BUFFER_QUEUE|system-port|Queue-id-range config * [intfsorch] Enable ipv6 proxy ndp along with proxy arp (sonic-net#3045) * [intfsorch] Enable ipv6 proxy ndp along with proxy arp setting SAI_VLAN_ATTR_UNKNOWN_MULTICAST_FLOOD_CONTROL_TYPE to SAI_VLAN_FLOOD_CONTROL_TYPE_NONE when proxy arp is enabled. This fixes a bug where ipv6 NS packets were flooding ports with duplicate packets. We now set multicast flood type to none. * Fix multi VLAN neighbor learning (sonic-net#3049) What I did When adding a new neighbor, check if the neighbor IP has already been learned on a different VLAN. If it has, remove the old neighbor entry before adding the new one. Why I did it On Gemini devices, if a neighbor IP moves from an active port in one VLAN to a second VLAN, then back to the first VLAN (with 3 different MAC addresses), orchagent will crash. Even though the MAC address of the last move is different from the first MAC address, orchagent believes the last MAC address to already be programmed in the hardware and tries to set an attribute of the entry which doesn't exist. * [asan] Disable the "maybe-uninitialized" warning when compiled with ASAN enabled. * Set HOST_TX_READY_NOTIFY attribute only after query capabilities(sonic-net#3070) *Set HOST_TX_READY_NOTIFY attribute only after query capabilities * [EVPN] Skip EVPN routes with invalid VNI or router mac field (sonic-net#3073) * Skip EVPN routes with invalid VNI or router mac field * Add port flap count and last flap timestamp to APPL_DB (sonic-net#3052) * Add port flap count and last flap timestamp * Add basic fabric link monitoring counters and states handling. (sonic-net#2988) * Add basic fabric link monitoring counters and states handling. * [Mellanox] Fix inconsistence in the shared headroom pool initialization (sonic-net#3057) * Fix inconsistence in the shared headroom pool initialization * Why I did it During initialization, if SHP is enabled the buffer pool sizes, xoff have initialized to 0, which means SHP is disabled but the buffer profiles already indicate SHP later on the buffer pool sizes are updated with off being non-zero In case the orchagent starts handling buffer configuration between 2 and 3, it is inconsistent between buffer pools and profiles, which fails Mellanox SAI sanity check. To avoid it, it indicates SHP enabled by setting a very small buffer pool and SHP sizes * [acl] Add IN_PORTS qualifier for L3 table (sonic-net#3078) * Apply IN_PORTS qualifiier for L3 table Why I did it IN_PORTS qualifier was allowed for L3 table in 202012 release and below. Changes in sonic-net#1982 removed that support leading to regression in some of our testcases. The following error was observed ERR swss#orchagent: :- validateAclRuleMatch: Match SAI_ACL_ENTRY_ATTR_FIELD_IN_PORTS in rule RULE_1 is not supported by table DATAACL * [bulker] add support for neighbor bulking (sonic-net#2768) Adding support for sai_neighbor_api_t bulking in bulker.h * [buffermgrd] Move switch-statement outside of if-statement in BufferMgr::doTask (sonic-net#3055) * [buffermgr] Moved switch statement outside of if-statmement in Buffermgr::doTask The switch statement which would normally erase buffer events was moved to be inside the if-statement which would only enter if the event is a SET event. This was introduced in commit e5329c39. This would cause an infinite loop, since non-set events would never be erased. The switch statement has now been moved to occur outside the if, allowing for non-set commands to be processed. * [portsorch] process only updated APP_DB fields when port is already created (sonic-net#3025) * [portsorch] process only updated APP_DB fields when port is already created What I did Fixing an issue when setting some port attribute in APPL_DB triggers serdes parameters to be re-programmed with port toggling. Made portsorch to handle only those attributes that were pushed to APPL_DB, so that serdes programming happens only by xcvrd's request to do so. * [Copp]Refactor coppmgr tests (sonic-net#3093) What I did Refactoring coppmgr mock tests Why I did it After migration to bookworm, coppmgr tests started failing due to the use of sudo commands. * Revert "[acl] Add IN_PORTS qualifier for L3 table (sonic-net#3078)" (sonic-net#3092) This reverts commit 9d4a3ad. *Revert "[acl] Add IN_PORTS qualifier for L3 table" * [orchagent] TWAMP Light orchagent implementation (sonic-net#2927) * [orchagent] TWAMP Light orchagent implementation. (sonic-net#2927) * What I did Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(sonic-net/SONiC#1320). * Clang format change. (sonic-net#3080) What I did This PR has no real code change. It is purely clang formatting. It only applies to the P4Orch codes. Commands that I run: find orchagent/p4orch -name *.h -o -name .cpp | xargs clang-format -i -style="{BasedOnStyle: Microsoft, DerivePointerAlignment: false}" find orchagent -name response_publisher -o -name return_code.h | xargs clang-format -i -style="{BasedOnStyle: Microsoft, DerivePointerAlignment: false}" * T2-VOQ-VS: Fix iBGP bringup issue (sonic-net#3053) * Fix iBGP bringup issue T2-vswitch * On T2-VOQ chassis Emulation with multi-asic linecards, iBGP sessions dont come up. Related Issue: sonic-net/sonic-buildimage#18129 * [Fdbsyncd] Adding extern_learn flag with fdb entry so Kernel doesn't age out (sonic-net#2985) * Adding extern_learn flag with fdb entry so that Kernel doesn't age out the MAC * [Fdbsyncd] Adding extern_learn flag with fdb entry so Kernel doesn't age out What I did extern_learn flag is added while programming the fdb entry into the Kernel. This will make sure that kernel doesn't age out the fdb entry. (#15004) How I did it A flag extern_learn will be passed while programing the fdb entry. (#15004) How to verify it Tested MAC add/del to the Kernel from the local FDB entry. (#15004) Signed-off-by: kishore.kunal@broadcom.com --------- Signed-off-by: kishore.kunal@broadcom.com Co-authored-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com> * Fix oper FEC retrieval after warmboot (sonic-net#3100) Updating oper FEC status in state_db after warm-reboot as part of refresh port status call * [EVPN]Fix fpmsyncd crash when EVPN type5 is received with bgp fib suppression enabled (sonic-net#3101) * [EVPN]Fix fpmsyncd crash when EVPN type5 is received with bgp fib suppression enabled * [portsorch] Handle TRANSCEIVER_INFO table on warm boot (sonic-net#3087) * Add existing data from TRANSCEIVER_INFO table * Introduce a new role for DPU-NPU Interconnect Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> Co-authored-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com> * [p4orch] Clang format change. (sonic-net#3096) What I did [p4orch] This PR has no real code change. It is purely clang formatting. It does the same as sonic-net#3080. * [dash] fix ENI admin state update (sonic-net#3081) * [dash] fix ENI admin state update * Add force option for fabric port unisolate command (sonic-net#3089) What I did Add force option to the unisolate link command, so users can make the links not isolate if they want. depends on sonic-net/sonic-buildimage#18447 * [twamporch] Explicitly initialize local variable (sonic-net#3115) What I did Explicitly initialized local variable. Why I did it We met below error message in sonic-buildimage armhf build (sonic-net/sonic-buildimage#18334) * Add bookworm build to the PR checkers (sonic-net#3114) What I did Add a Bookworm build to the PR checkers. Also fix some Bookworm build errors that crept in. Why I did it Buildimage now builds swss for Bookworm, so the build needs to succeed. * [ACL] Remove flex counter when updating ACL rule (sonic-net#3118) What I did This PR is to fix sonic-net/sonic-buildimage#18719 When ACL rule is created for the first time, a flex counter is created and registered. When the same ACL rule is being updated, the FlexCounter created before is not removed, and another FlexCounter is created and registered. Why I did it Fix the issue that FlexCounter is duplicated when updating existing ACL rule. --------- Signed-off-by: kishore.kunal@broadcom.com Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> Co-authored-by: saksarav-nokia <sakthivadivu.saravanaraj@nokia.com> Co-authored-by: Nikola Dancejic <26731235+Ndancejic@users.noreply.github.com> Co-authored-by: Lawrence Lee <lawlee@microsoft.com> Co-authored-by: Oleksandr Ivantsiv <oivantsiv@nvidia.com> Co-authored-by: noaOrMlnx <58519608+noaOrMlnx@users.noreply.github.com> Co-authored-by: Lior Avramov <73036155+liorghub@users.noreply.github.com> Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com> Co-authored-by: jfeng-arista <98421150+jfeng-arista@users.noreply.github.com> Co-authored-by: Stephen Sun <5379172+stephenxs@users.noreply.github.com> Co-authored-by: Neetha John <nejo@microsoft.com> Co-authored-by: Amir <mazora@marvell.com> Co-authored-by: Stepan Blyshchak <38952541+stepanblyschak@users.noreply.github.com> Co-authored-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com> Co-authored-by: xiaodong hu <32903206+huseratgithub@users.noreply.github.com> Co-authored-by: mint570 <70396898+mint570@users.noreply.github.com> Co-authored-by: Deepak Singhal <115033986+deepak-singhal0408@users.noreply.github.com> Co-authored-by: KISHORE KUNAL <64033340+kishorekunal01@users.noreply.github.com> Co-authored-by: Vivek <vivekreddykarri98@gmail.com> Co-authored-by: Yakiv Huryk <62013282+Yakiv-Huryk@users.noreply.github.com> Co-authored-by: Saikrishna Arcot <sarcot@microsoft.com> Co-authored-by: bingwang-ms <66248323+bingwang-ms@users.noreply.github.com>

pbrisset · 2024-05-01T22:00:20Z

Hi,
It's been a while this PR is in this state. Is there any plan to continue / finish the work on this?
Patrice

huangchengjiu · 2024-05-14T12:36:15Z

cfgmgr/intfmgr.cpp

+                        {
+                            setHostSubIntfAdminStatus(alias, "down");
+                            setIntfMac(alias, gwmac);
+                            setHostSubIntfAdminStatus(alias, "up");


Wouldn't it be better to restore the interface to its original admin state instead of just bringing it up directly?

yanjundeng · 2024-06-20T17:51:47Z

Hi ALL Reviewers:
Since the PR is out of date with the latest master branch, Pls review : #3167
Thanks/yanjun

Add SAG support

007854e

superchild requested a review from prsunny as a code owner October 20, 2021 07:26

superchild mentioned this pull request Oct 20, 2021

Static Anycast Gateway HLD sonic-net/SONiC#837

Merged

Merge branch 'master' into sag-dev

a0de06d

Refine field name in CONFIG_DB according to yang model change

75ddeea

kperumalbfn reviewed Nov 15, 2021

View reviewed changes

Merge branch 'master' into sag-dev

53e2225

superchild added 2 commits March 31, 2022 08:11

Merge branch 'github-master' into sag-dev

0e92c96

Fix compile error and bugs

b708ae4

* Fix change SAG mac doesn't reset MAC address on VLAN interface * Fix compile error for update admin status api change

zhangyanzhao requested review from svshah-intel, kperumalbfn, marian-pritsak and StephenWangGoogle February 1, 2023 07:28

Merge branch 'master' into sag-dev

4d092b2

Junchao-Mellanox suggested changes Mar 7, 2023

View reviewed changes

Junchao-Mellanox reviewed Mar 7, 2023

View reviewed changes

orchagent/intfsorch.cpp Show resolved Hide resolved

superchild added 3 commits June 14, 2023 20:29

Merge branch 'master' into sag-dev

42d4951

Fix compile error

4e4afb3

Refine code and add comments

8548d1b

Junchao-Mellanox reviewed Jun 20, 2023

View reviewed changes

tests/test_sag.py Show resolved Hide resolved

Add delete SAG global MAC while VLAN is enabled test case

371be65

* Fix test cases errors * Refine logic to keep it simple

Junchao-Mellanox approved these changes Jun 25, 2023

View reviewed changes

superchild and others added 3 commits January 25, 2024 10:46

Merge branch 'master' into sag-dev

fb90a04

Add missing extern gMacAddress

4a6d856

Fixes mock test failure

da1f6c0

linarnan added 2 commits February 7, 2024 09:44

Fixes merge conflict issue

69c34c3

Merge branch 'sonic-net:master' into sag-dev

2139a2e

superchild requested review from abdosi and judyjoseph as code owners April 24, 2024 13:26

huangchengjiu reviewed May 14, 2024

View reviewed changes

yanjundeng mentioned this pull request May 24, 2024

[swss] add static anycast gateway support #3167

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SAG]: Add SAG implementation #1974

[SAG]: Add SAG implementation #1974

superchild commented Oct 20, 2021

superchild commented Oct 28, 2021

kperumalbfn Nov 15, 2021

superchild Nov 16, 2021

kperumalbfn Nov 15, 2021

superchild Nov 16, 2021 •

edited

Loading

kperumalbfn Nov 15, 2021

kperumalbfn Nov 15, 2021

superchild Nov 16, 2021

superchild commented Nov 16, 2021

zhangyanzhao commented Dec 2, 2021

superchild commented Dec 3, 2021

superchild commented Dec 10, 2021

superchild commented May 6, 2022

prsunny commented May 7, 2022

zhangyanzhao commented Feb 1, 2023

zhangyanzhao commented May 9, 2023

Junchao-Mellanox commented May 9, 2023

superchild commented Jun 16, 2023

zhangyanzhao commented Jan 24, 2024

zhangyanzhao commented Jan 24, 2024

zhangyanzhao commented Jan 24, 2024

linux-foundation-easycla bot commented Feb 7, 2024 •

edited

Loading

superchild commented Feb 7, 2024

superchild commented Feb 7, 2024

mssonicbld commented Feb 7, 2024

azure-pipelines bot commented Feb 7, 2024

liat-grozovik commented Apr 11, 2024

superchild commented Apr 18, 2024

linarnan commented Apr 23, 2024

pbrisset commented May 1, 2024

huangchengjiu May 14, 2024

yanjundeng commented Jun 20, 2024

[SAG]: Add SAG implementation #1974

Are you sure you want to change the base?

[SAG]: Add SAG implementation #1974

Conversation

superchild commented Oct 20, 2021

superchild commented Oct 28, 2021

kperumalbfn Nov 15, 2021

Choose a reason for hiding this comment

superchild Nov 16, 2021

Choose a reason for hiding this comment

kperumalbfn Nov 15, 2021

Choose a reason for hiding this comment

superchild Nov 16, 2021 • edited Loading

Choose a reason for hiding this comment

kperumalbfn Nov 15, 2021

Choose a reason for hiding this comment

kperumalbfn Nov 15, 2021

Choose a reason for hiding this comment

superchild Nov 16, 2021

Choose a reason for hiding this comment

superchild commented Nov 16, 2021

zhangyanzhao commented Dec 2, 2021

superchild commented Dec 3, 2021

superchild commented Dec 10, 2021

superchild commented May 6, 2022

prsunny commented May 7, 2022

zhangyanzhao commented Feb 1, 2023

zhangyanzhao commented May 9, 2023

Junchao-Mellanox commented May 9, 2023

superchild commented Jun 16, 2023

zhangyanzhao commented Jan 24, 2024

zhangyanzhao commented Jan 24, 2024

zhangyanzhao commented Jan 24, 2024

linux-foundation-easycla bot commented Feb 7, 2024 • edited Loading

superchild commented Feb 7, 2024

superchild commented Feb 7, 2024

mssonicbld commented Feb 7, 2024

azure-pipelines bot commented Feb 7, 2024

liat-grozovik commented Apr 11, 2024

superchild commented Apr 18, 2024

linarnan commented Apr 23, 2024

pbrisset commented May 1, 2024

huangchengjiu May 14, 2024

Choose a reason for hiding this comment

yanjundeng commented Jun 20, 2024

superchild Nov 16, 2021 •

edited

Loading

linux-foundation-easycla bot commented Feb 7, 2024 •

edited

Loading