Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SAG SONiC Yang #9018

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add SAG SONiC Yang #9018

wants to merge 15 commits into from

Conversation

superchild
Copy link

Why I did it

For static anycast gateway feature, add related yang model.
Refer to SAG HLD#837

Signed-off-by: Jimi Chen jimi_chen@edge-core.com

How I did it

  • Defined sonic-static-anycast-gateway.yang model, and modify sonic-vlan.yang for new added field.
  • Add sonic-yang-model/sonic-yang-mgmt unit test case

How to verify it

  • build sonic_yang_models-1.0-py3-none-any.whl /sonic_yang_mgmt-1.0-py3-none-any.whl successfully

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@superchild superchild requested a review from lguohan as a code owner October 20, 2021 07:58
@superchild superchild mentioned this pull request Oct 20, 2021
Merged
@superchild
Copy link
Author

@lguohan Could you please help to review the code?
The related CLI sonic-utilities#1887 code change doesn't have reviewer yet, could you please help to assign someone to review?
Thanks.

@superchild
Copy link
Author

@venkatmahalingam please help to review the updated version, thanks.

@superchild
Copy link
Author

@venkatmahalingam @lguohan
Can you please help to check and review?
Thanks.

qiluo-msft
qiluo-msft reviewed Jan 13, 2022
View reviewed changes
src/sonic-yang-models/yang-models/sonic-vlan.yang Outdated
description "Enable/disable static anycast gateway for the vlan interface";
type boolean;
default false;
}
Copy link
Collaborator

@qiluo-msft qiluo-msft Jan 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    [](http://example.com/codeflow?start=0&length=8)

Mixing spaces and tabs in this file. #Closed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already unified indentation to spaces and aligned format

venkatmahalingam
venkatmahalingam reviewed Jan 18, 2022
View reviewed changes
src/sonic-yang-models/yang-models/sonic-vlan.yang Outdated

import sonic-port {
prefix port;
revision-date 2019-07-01;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need a revision date.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in updated commit.

venkatmahalingam
venkatmahalingam reviewed Jan 18, 2022
View reviewed changes
src/sonic-yang-models/yang-models/sonic-vlan.yang Outdated
}

description "VLAN yang Module for SONiC OS";

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the new revision for the SAG support.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add revision in updated commit.

@superchild
Copy link
Author

@qiluo-msft @venkatmahalingam Could you please help to review the change?

@superchild
Copy link
Author

@qiluo-msft @venkatmahalingam @lguohan
Could you please help to review again?
Thanks.

@venkatmahalingam venkatmahalingam self-requested a review May 6, 2022 16:47
qiluo-msft
qiluo-msft previously approved these changes May 6, 2022
View reviewed changes
@qiluo-msft
Copy link
Collaborator

Could you merge latest master? It will also retrigger the PR checkers.

@zhangyanzhao
Copy link
Collaborator

@superchild can you please sign-off the EasyCLA? This merge is blocked by it. Thanks.

@superchild
Copy link
Author

@zhangyanzhao
I already signed the EasyCLA, there're some conflicts existed.
I'll fix the conflicts soon.

@superchild
Copy link
Author

@zhangyanzhao
Conflict is resolved, I think it needs reviewer to approve running workflows.

Junchao-Mellanox
Junchao-Mellanox suggested changes Mar 7, 2023
View reviewed changes
src/sonic-yang-models/tests/files/sample_config_db.json
@@ -1782,6 +1788,11 @@
"rfc6939_support": "true"
}
},
"SAG": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate SAG entry?

src/sonic-yang-models/yang-models/sonic-vlan.yang Outdated
@@ -36,6 +36,10 @@ module sonic-vlan {

description "VLAN yang Module for SONiC OS";

revision 2023-02-13 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the indent

@liat-grozovik
Copy link
Collaborator

@venkatmahalingam i see you had comments, can you please review following comments handling so i can go a head and merge

@liat-grozovik
Copy link
Collaborator

@superchild please handle conflicts

@superchild
Copy link
Author

@liat-grozovik
I don't work on this project anymore and don't have related build machine to test.
I'll suggest someone can help to finish this or send the other PR.

@yanjundeng yanjundeng mentioned this pull request May 24, 2024
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junchao-Mellanox Junchao-Mellanox Junchao-Mellanox approved these changes

@venkatmahalingam venkatmahalingam venkatmahalingam left review comments

@qiluo-msft qiluo-msft qiluo-msft left review comments

@lguohan lguohan Awaiting requested review from lguohan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@superchild @qiluo-msft @zhangyanzhao @liat-grozovik @venkatmahalingam @Junchao-Mellanox