Add SAG SONiC Yang #9018
Add SAG SONiC Yang #9018
Conversation
|
@lguohan Could you please help to review the code? |
|
@venkatmahalingam please help to review the updated version, thanks. |
|
@venkatmahalingam @lguohan |
| description "Enable/disable static anycast gateway for the vlan interface"; | ||
| type boolean; | ||
| default false; | ||
| } |
There was a problem hiding this comment.
[](http://example.com/codeflow?start=0&length=8)
Mixing spaces and tabs in this file. #Closed
There was a problem hiding this comment.
Already unified indentation to spaces and aligned format
|
|
||
| import sonic-port { | ||
| prefix port; | ||
| revision-date 2019-07-01; |
There was a problem hiding this comment.
We dont need a revision date.
| } | ||
|
|
||
| description "VLAN yang Module for SONiC OS"; | ||
|
|
There was a problem hiding this comment.
We need the new revision for the SAG support.
There was a problem hiding this comment.
Add revision in updated commit.
|
@qiluo-msft @venkatmahalingam Could you please help to review the change? |
|
@qiluo-msft @venkatmahalingam @lguohan |
|
Could you merge latest master? It will also retrigger the PR checkers. |
|
@superchild can you please sign-off the EasyCLA? This merge is blocked by it. Thanks. |
|
@zhangyanzhao |
|
@zhangyanzhao |
| @@ -1782,6 +1788,11 @@ | |||
| "rfc6939_support": "true" | |||
| } | |||
| }, | |||
| "SAG": { | |||
There was a problem hiding this comment.
duplicate SAG entry?
| @@ -36,6 +36,10 @@ module sonic-vlan { | |||
|
|
|||
| description "VLAN yang Module for SONiC OS"; | |||
|
|
|||
| revision 2023-02-13 { | |||
There was a problem hiding this comment.
please fix the indent
liat-grozovik
dismissed stale reviews from qiluo-msft and venkatmahalingam
via
224f0af
|
@venkatmahalingam i see you had comments, can you please review following comments handling so i can go a head and merge |
|
@superchild please handle conflicts |
|
@liat-grozovik |
Why I did it
For static anycast gateway feature, add related yang model.
Refer to SAG HLD#837
Signed-off-by: Jimi Chen jimi_chen@edge-core.com
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)