Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription key improvements #2212

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

malincrist
Copy link
Member

This PR introduces some improvements for the Subscription Key flows in the test console:

  1. If the subscription key is required, the header is always present in the "headers" section, and marked as required:
    image

  2. The "Subscription key" from Authorization section is masked out by default an it can be un-masked:
    subscriptionkeyauth

  3. If the user tries to send the request without any value completed for the subscription key header, the request will not be sent and an error will be shown: (related issue Incorrect message for invalid/missing subscription key using policy fragment with cors & Users shouldn't be able to send requests when not subscribed. #2202)
    image

Similar behavior for GraphQL and WebSocket and subscription key parameter.

@github-actions
Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 28 check(s) passed, and 24 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@malincrist malincrist merged commit 2805ab9 into master Jun 20, 2023
@malincrist malincrist deleted the malincrist/feature/subscription-key-improvements branch June 20, 2023 13:45
@arbs-io
Copy link

arbs-io commented Jan 29, 2024

Hi @f-alizada, @malincrist
Has this change introduced a bug? We've noticed over the weekend that the subscription key is now always required. Even if both Product and API have subscription-required disabled.

@malincrist
Copy link
Member Author

Hello @arbs-io , yes, there is a regression in the new release that always marks the subscription key header as required. We have fixed it (see #2382) and will prioritize the deployment of the fix for the affected services. Apologies for the inconveniences created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants