Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed subscription header always required #2382

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

malincrist
Copy link
Member

@malincrist malincrist commented Jan 29, 2024

Problem

After the fix for managed portals for filling the subscription key when opening the test console, the Ocp-Apim-Subscription-Key is always marked as required in the test console.

This is because, after subscribing to this.selectedSubscriptionKey.subscribe(this.applySubscriptionKey.bind(this)), we set the selectedSubscriptionKey to null. This results in applySubscriptionKey to be called (with null), which adds the header Ocp-Apim-Subscription-Key (with null) , even if the subscription key is not required.

Solution

Remove this.selectedSubscriptionKey(null);, since, if the subscription key is required, we will set the Ocp-Apim-Subscription-Key to null , from the method setSubscriptionKeyHeader.

Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 29 check(s) passed, and 23 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@JMach1 JMach1 self-requested a review January 29, 2024 10:11
@malincrist malincrist merged commit cffee03 into master Jan 29, 2024
10 checks passed
@malincrist malincrist deleted the malincrist/bug/subscription-header-always-required branch January 29, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants