Fixed subscription header always required #2382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After the fix for managed portals for filling the subscription key when opening the test console, the
Ocp-Apim-Subscription-Key
is always marked as required in the test console.This is because, after subscribing to
this.selectedSubscriptionKey.subscribe(this.applySubscriptionKey.bind(this))
, we set theselectedSubscriptionKey
to null. This results inapplySubscriptionKey
to be called (with null), which adds the headerOcp-Apim-Subscription-Key
(with null) , even if the subscription key is not required.Solution
Remove
this.selectedSubscriptionKey(null);
, since, if the subscription key is required, we will set theOcp-Apim-Subscription-Key
to null , from the methodsetSubscriptionKeyHeader
.