Update code to support adding and parsing provider name #1032

bquantump · 2021-02-16T17:26:35Z

https://dev.azure.com/azure-mgmt-ex/DotNET%20Management%20SDK/_boards/board/t/DotNET%20Management%20SDK%20Team/Stories/?workitem=5393

bquantump · 2021-02-16T17:28:01Z

Pavel Krymets FTE 1 hour ago Member
Typically we don't modify the CodeModel during the generation. If some logic needs to be applied to the output model it needs to go into the corresponding output model class (https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Output/Models/Client.cs , https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Output/Models/RestClient.cs , https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Output/Models/Types/ObjectType.cs , etc.)

bquantump · 2021-02-16T17:28:58Z

#1031 (review)

bquantump · 2021-02-16T17:32:27Z

Pavel Krymets FTE 1 hour ago Member
Typically we don't modify the CodeModel during the generation. If some logic needs to be applied to the output model it needs to go into the corresponding output model class (https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Output/Models/Client.cs , https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Output/Models/RestClient.cs , https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Output/Models/Types/ObjectType.cs , etc.)

@pakrym This property will be needed by more than one output type for us (a new client and model output we will make). Is there any other good place to put this code given that?

pakrym · 2021-02-16T17:37:03Z

Can you please add a description of what this feature would ultimately achieve? It would help figure out a good place for this to go. The other option might be to integrate this feature into some existing code to see it work.

bquantump · 2021-02-16T17:46:28Z

Can you please add a description of what this feature would ultimately achieve? It would help figure out a good place for this to go. The other option might be to integrate this feature into some existing code to see it work.

This feature is to support basically having a property somewhere (I put it in the code model for this PR) that has the full provider name for a give resource (1:1 with an operation group). For example, subnet would be Microsoft.Network/virtualNetworks/subnets. We can either get this from the swagger or the OperationsGroupMapping list in the configuration file also added in this PR.

This property will need to be used to generate multiple new output types. (our new model and client types). These types are not implemented in code yet and will be implemented in later PRs.

pakrym · 2021-02-16T17:49:03Z

How do we know this code works?

https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Output/Builders/BuilderHelpers.cs might be a reasonable place for this.

pakrym · 2021-02-16T17:50:09Z

src/AutoRest.CSharp/Output/Models/Types/OutputLibrary.cs

+            }
+            return providerName.TrimEnd('/');
+        }
+        private static List<string> GetPathSegments(string httpRequestUri)


Can

autorest.csharp/src/AutoRest.CSharp/Utilities/StringExtensions.cs

Line 67 in a853571

public static IEnumerable<(string Text, bool IsLiteral)> GetPathParts(string? path)

be used here?

bquantump · 2021-02-16T18:00:40Z

How do we know this code works?

https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Output/Builders/BuilderHelpers.cs might be a reasonable place for this.

These are all static and we would not want to run this logic to parse the URI to get the provider name more than once, since the logic is not simple. That is why we want to really store somewhere that many output types can use.

src/AutoRest.CSharp/AutoRest/Plugins/Configuration.cs

pakrym · 2021-02-16T18:07:22Z

How do we know this code works?

These are all static and we would not want to run this logic to parse the URI to get the provider name more than once, since the logic is not simple

I doubt it would noticeably affect the generation time. We can cache it if perf becomes a problem and we would have a better feel of what other moving pieces are.

src/AutoRest.CSharp/AutoRest/Communication/StandaloneGeneratorRunner.cs

src/AutoRest.CSharp/Input/CodeModelPartials.cs

src/AutoRest.CSharp/Output/Models/Types/OutputLibrary.cs

src/AutoRest.CSharp/AutoRest/Communication/StandaloneGeneratorRunner.cs

src/AutoRest.CSharp/Output/Models/Types/OutputLibrary.cs

…st.csharp into stevens_5393_providername

bquantump · 2021-02-18T01:28:16Z

@pakrym

Why is this https://github.com/Azure/azure-rest-api-specs/blob/d9cf7c7ed3d674ebd482836e82b274014245ae67/specification/imds/data-plane/readme.md

have azure-arm: true

when it is data-pane?

pakrym · 2021-02-18T16:19:41Z

Why is this Azure/azure-rest-api-specs@d9cf7c7/specification/imds/data-plane/readme.md
have azure-arm: true
when it is data-pane?

No idea.

* Mnash 5154 skeleton operations (#1011) * create shell resource operations objects * added trailing newline * Revert "added trailing newline" This reverts commit a24d17d. * update launch settings to add a compute option vs modifying * updates after adding dummy constructor * updates after merge * updates to generated code * address pr comments * update after redoing npm install * update launchsettings * update samples list * revert unintended change * update ordering for launch settings * add resource container shell to mgmt generation (#1025) * add resource container shell to mgmt generation * Address review comments * Renaming Azure.ResourceManager.Compute to Azure.ResourceManager.Sample (#1034) * Update code to support adding and parsing provider name (#1032) * WIP: Update code for provider name * Add operationsGroupMappings example * Only Write out if has field * WIP: update operations config * Update readme * Wip: update compute * WIP: off by one * Remove Synapse * Remove more tests * Remove all mgmt test * Update OutputLibrary.cs * remove imds for now * Update Operations * Tenant id (#1037) * WIP: tenant id * WIP: rebase * Rebase * WIP * WIP: tenant deco * NIT * NIT * WIP: Update * NIT newline * Updates * WIP: updates * Updates * NIT * Enable OperationGroup get associated resource name from one property (#1049) * WIP: update (#1052) * WIP: update * Updates * Fix bad merge * White space * Update config * Mergev3tomgmt (#1062) * Generate public client constructors and options (#1046) Generate public client constructors and options * Make client options class partial (#1055) * Disable buffering for stream responses (#1060) * updates after merge * duplicate end file * regen after merge Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> * merge feature/v3 into feature/mgmt-track2 (#1072) * Generate public client constructors and options (#1046) Generate public client constructors and options * Make client options class partial (#1055) * Disable buffering for stream responses (#1060) * Add Url Encoded Body support (#1042) - Fixes: #986 * Fix LRO create request from relative path on Unix (#1059) * Remove automated buffering logic (#1064) * Add System.Text.Json converter to models (#1063) Fixes: #947 * Fix feature/v3 integration with azure-sdk-for-net (#1065) - Autorest core 3.0.6372 and above crash due to directive ordering bug Tim is digging into now - New shared code does not compile cleanly with azure-sdk-for-net rules * Hide paging classes (#1066) * Add help content (#1067) * Add help content * update after merge Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: Chris Hamons <chris.hamons@microsoft.com> Co-authored-by: pavelprystinka <30868871+pavelprystinka@users.noreply.github.com> Co-authored-by: Timothee Guerin <tiguerin@microsoft.com> * Support generating empty data and data serialization file (#1074) * Add compute to test projects * Support generating empty [Resource]Data.cs and [Resource]Data.Serialization.cs * Upload compute codegen result * Remove codegen result * Resolve merge conflicts * Resolve reference errors * Refactor code * Regenerate Azure.ResourceManager.Sample * Regenerate Azure.Management.Storage * Update all other codegen files when running Generate.ps1 * Re-run Generate.ps1 * Remove the stale compute project * Decorate schema * Change ResourceData to inherit from ObjectType * Regenerate Azure.Management.Storage * Regenerate Azure.ResourceManager.Sample * Correct the Resource name in [Resource]Container.cs and [Resource]Operation.cs * Regenerate Azure.Management.Storage * Regenerate Azure.ResourceManager.Sample * Cleanup comments * Re-run Generate.ps1 * Address review comments * Run Generate.ps1 * regen * add files Co-authored-by: YalinLi0312 <yall@microsoft.com> * [Mgmt Track 2] 5156 generate empty resource autorest change (#1076) * Empty Resource Code Change * CI fix * Empty Resource Sample Update * Rename arm to mgmt as ARM is ingored * Updating storage sample * Updated resource to be in the Generated folder * Updates after merge * regenerate with feature/v3 changes * Update [Resource]Data to inherit the exact matching base class (#1095) * Add Azure.ResourceManager.Core to package reference group * Override inheritance in [Resource]Data * Regenerate Azure.Resourcemanager.Sample * Regenerate Azure.Management.Storage * Update Azure.Core and Azure.ResourceManager.Core version * Rebuild model inheritance * Correct the properties to generate * Update ResourceDataWriter and its serialization writer * Regenerate Azure.ResourceManager.Sample * Update Azure.resourceManager.Core version * Regenerate Azure.Management.Storage * Run Generate.ps1 * Address review comments * Run Generate.ps1 * initial changes to compile * finish merge * initial mgmt fork * more changes to mgmt fork * updates after merge * remove unnecessary Arm configuration checks * missed a merge conflict to enable the inheritance code * auto-generate after merge and changes * address review comments * change to ireadonlydictionary * Remove mgmt response headers * LROs * remove M-LROs * remove files until next pr * address pr comments * update csproj writer * update protected property Co-authored-by: Allen Zhang <allenzhang@live.com> Co-authored-by: bquantump <53361486+bquantump@users.noreply.github.com> Co-authored-by: Yalin Li <yall@microsoft.com> Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: Chris Hamons <chris.hamons@microsoft.com> Co-authored-by: pavelprystinka <30868871+pavelprystinka@users.noreply.github.com> Co-authored-by: Timothee Guerin <tiguerin@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com>

* Mnash 5154 skeleton operations (#1011) * create shell resource operations objects * added trailing newline * Revert "added trailing newline" This reverts commit a24d17d. * update launch settings to add a compute option vs modifying * updates after adding dummy constructor * updates after merge * updates to generated code * address pr comments * update after redoing npm install * update launchsettings * update samples list * revert unintended change * update ordering for launch settings * add resource container shell to mgmt generation (#1025) * add resource container shell to mgmt generation * Address review comments * Renaming Azure.ResourceManager.Compute to Azure.ResourceManager.Sample (#1034) * Update code to support adding and parsing provider name (#1032) * WIP: Update code for provider name * Add operationsGroupMappings example * Only Write out if has field * WIP: update operations config * Update readme * Wip: update compute * WIP: off by one * Remove Synapse * Remove more tests * Remove all mgmt test * Update OutputLibrary.cs * remove imds for now * Update Operations * Tenant id (#1037) * WIP: tenant id * WIP: rebase * Rebase * WIP * WIP: tenant deco * NIT * NIT * WIP: Update * NIT newline * Updates * WIP: updates * Updates * NIT * Enable OperationGroup get associated resource name from one property (#1049) * WIP: update (#1052) * WIP: update * Updates * Fix bad merge * White space * Update config * Mergev3tomgmt (#1062) * Generate public client constructors and options (#1046) Generate public client constructors and options * Make client options class partial (#1055) * Disable buffering for stream responses (#1060) * updates after merge * duplicate end file * regen after merge Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> * merge feature/v3 into feature/mgmt-track2 (#1072) * Generate public client constructors and options (#1046) Generate public client constructors and options * Make client options class partial (#1055) * Disable buffering for stream responses (#1060) * Add Url Encoded Body support (#1042) - Fixes: #986 * Fix LRO create request from relative path on Unix (#1059) * Remove automated buffering logic (#1064) * Add System.Text.Json converter to models (#1063) Fixes: #947 * Fix feature/v3 integration with azure-sdk-for-net (#1065) - Autorest core 3.0.6372 and above crash due to directive ordering bug Tim is digging into now - New shared code does not compile cleanly with azure-sdk-for-net rules * Hide paging classes (#1066) * Add help content (#1067) * Add help content * update after merge Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: Chris Hamons <chris.hamons@microsoft.com> Co-authored-by: pavelprystinka <30868871+pavelprystinka@users.noreply.github.com> Co-authored-by: Timothee Guerin <tiguerin@microsoft.com> * Support generating empty data and data serialization file (#1074) * Add compute to test projects * Support generating empty [Resource]Data.cs and [Resource]Data.Serialization.cs * Upload compute codegen result * Remove codegen result * Resolve merge conflicts * Resolve reference errors * Refactor code * Regenerate Azure.ResourceManager.Sample * Regenerate Azure.Management.Storage * Update all other codegen files when running Generate.ps1 * Re-run Generate.ps1 * Remove the stale compute project * Decorate schema * Change ResourceData to inherit from ObjectType * Regenerate Azure.Management.Storage * Regenerate Azure.ResourceManager.Sample * Correct the Resource name in [Resource]Container.cs and [Resource]Operation.cs * Regenerate Azure.Management.Storage * Regenerate Azure.ResourceManager.Sample * Cleanup comments * Re-run Generate.ps1 * Address review comments * Run Generate.ps1 * regen * add files Co-authored-by: YalinLi0312 <yall@microsoft.com> * [Mgmt Track 2] 5156 generate empty resource autorest change (#1076) * Empty Resource Code Change * CI fix * Empty Resource Sample Update * Rename arm to mgmt as ARM is ingored * Updating storage sample * Updated resource to be in the Generated folder * Updates after merge * regenerate with feature/v3 changes * WIP: First cust parent algo * Update OutputLibrary.cs * WIP * WIP: * WIP * WIP * WIP * WIP: Updates * WIP * WIP: * WIP * WIP * WIP * WIP * WIP: update configs * WIP: update test * WIP * Update [Resource]Data to inherit the exact matching base class (#1095) * Add Azure.ResourceManager.Core to package reference group * Override inheritance in [Resource]Data * Regenerate Azure.Resourcemanager.Sample * Regenerate Azure.Management.Storage * Update Azure.Core and Azure.ResourceManager.Core version * Rebuild model inheritance * Correct the properties to generate * Update ResourceDataWriter and its serialization writer * Regenerate Azure.ResourceManager.Sample * Update Azure.resourceManager.Core version * Regenerate Azure.Management.Storage * Run Generate.ps1 * Address review comments * Run Generate.ps1 * initial changes to compile * finish merge * initial mgmt fork * Updates test * more changes to mgmt fork * updates after merge * remove unnecessary Arm configuration checks * missed a merge conflict to enable the inheritance code * auto-generate after merge and changes * address review comments * Updates * Update * WIP * Merge * Update * Updates * Updates * Update DataPlaneResponseHeaderGroupWriter.cs * Update DataPlaneLongRunningOperationWriter.cs * Update DataPlaneLongRunningOperationMethod.cs * address review comments * add resource rename test Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com> Co-authored-by: Allen Zhang <allenzhang@live.com> Co-authored-by: Yalin Li <yall@microsoft.com> Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: Chris Hamons <chris.hamons@microsoft.com> Co-authored-by: pavelprystinka <30868871+pavelprystinka@users.noreply.github.com> Co-authored-by: Timothee Guerin <tiguerin@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com>

* Mnash 5154 skeleton operations (#1011) * create shell resource operations objects * added trailing newline * Revert "added trailing newline" This reverts commit a24d17d. * update launch settings to add a compute option vs modifying * updates after adding dummy constructor * updates after merge * updates to generated code * address pr comments * update after redoing npm install * update launchsettings * update samples list * revert unintended change * update ordering for launch settings * add resource container shell to mgmt generation (#1025) * add resource container shell to mgmt generation * Address review comments * Renaming Azure.ResourceManager.Compute to Azure.ResourceManager.Sample (#1034) * Update code to support adding and parsing provider name (#1032) * WIP: Update code for provider name * Add operationsGroupMappings example * Only Write out if has field * WIP: update operations config * Update readme * Wip: update compute * WIP: off by one * Remove Synapse * Remove more tests * Remove all mgmt test * Update OutputLibrary.cs * remove imds for now * Update Operations * Tenant id (#1037) * WIP: tenant id * WIP: rebase * Rebase * WIP * WIP: tenant deco * NIT * NIT * WIP: Update * NIT newline * Updates * WIP: updates * Updates * NIT * Enable OperationGroup get associated resource name from one property (#1049) * WIP: update (#1052) * WIP: update * Updates * Fix bad merge * White space * Update config * Mergev3tomgmt (#1062) * Generate public client constructors and options (#1046) Generate public client constructors and options * Make client options class partial (#1055) * Disable buffering for stream responses (#1060) * updates after merge * duplicate end file * regen after merge Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> * merge feature/v3 into feature/mgmt-track2 (#1072) * Generate public client constructors and options (#1046) Generate public client constructors and options * Make client options class partial (#1055) * Disable buffering for stream responses (#1060) * Add Url Encoded Body support (#1042) - Fixes: #986 * Fix LRO create request from relative path on Unix (#1059) * Remove automated buffering logic (#1064) * Add System.Text.Json converter to models (#1063) Fixes: #947 * Fix feature/v3 integration with azure-sdk-for-net (#1065) - Autorest core 3.0.6372 and above crash due to directive ordering bug Tim is digging into now - New shared code does not compile cleanly with azure-sdk-for-net rules * Hide paging classes (#1066) * Add help content (#1067) * Add help content * update after merge Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: Chris Hamons <chris.hamons@microsoft.com> Co-authored-by: pavelprystinka <30868871+pavelprystinka@users.noreply.github.com> Co-authored-by: Timothee Guerin <tiguerin@microsoft.com> * Support generating empty data and data serialization file (#1074) * Add compute to test projects * Support generating empty [Resource]Data.cs and [Resource]Data.Serialization.cs * Upload compute codegen result * Remove codegen result * Resolve merge conflicts * Resolve reference errors * Refactor code * Regenerate Azure.ResourceManager.Sample * Regenerate Azure.Management.Storage * Update all other codegen files when running Generate.ps1 * Re-run Generate.ps1 * Remove the stale compute project * Decorate schema * Change ResourceData to inherit from ObjectType * Regenerate Azure.Management.Storage * Regenerate Azure.ResourceManager.Sample * Correct the Resource name in [Resource]Container.cs and [Resource]Operation.cs * Regenerate Azure.Management.Storage * Regenerate Azure.ResourceManager.Sample * Cleanup comments * Re-run Generate.ps1 * Address review comments * Run Generate.ps1 * regen * add files Co-authored-by: YalinLi0312 <yall@microsoft.com> * GenCode changes * Generated files with ListAvailableLocations * [Mgmt Track 2] 5156 generate empty resource autorest change (#1076) * Empty Resource Code Change * CI fix * Empty Resource Sample Update * Rename arm to mgmt as ARM is ingored * Updating storage sample * Updated resource to be in the Generated folder * Updates after merge * NuGet Packages added * First iteration * Create ResourceOperationsTests.cs * Add ResourceType property * ResourceType * regenerate with feature/v3 changes * wip changes * update to handle overrides * Update Azure.ResourceManager.Core Version * CancellationToken in Get() * Azure.ResourceManager.Core version * Update Azure.ResourceManager.Core version * Style corrections in ResourceOperation Writer * Update OutputLibrary.cs * Temporarily remove Test Case * Test cases for *Operations types * Test files re-generated * revert merge * manual updates after merge * fix issue with merge * regen after merge * move inheritance chooser * regen after merge * regen after merge * regen after merge * Fixing comments * Re-generate Azure.ResourceManager.Sample * Re-run Generate.ps1 * Default constructor for TestProjectTests * Missing using statement * Addressing pakrym comments * Re-generated files up to date Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com> Co-authored-by: Allen Zhang <allenzhang@live.com> Co-authored-by: bquantump <53361486+bquantump@users.noreply.github.com> Co-authored-by: Yalin Li <yall@microsoft.com> Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: Chris Hamons <chris.hamons@microsoft.com> Co-authored-by: pavelprystinka <30868871+pavelprystinka@users.noreply.github.com> Co-authored-by: Timothee Guerin <tiguerin@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com>

WIP: Update code for provider name

69f1197

bquantump requested review from pakrym and ShivangiReja February 16, 2021 17:26

bquantump requested a review from chamons as a code owner February 16, 2021 17:26

bquantump requested review from m-nash and allenjzhang February 16, 2021 17:26

pakrym reviewed Feb 16, 2021

View reviewed changes

src/AutoRest.CSharp/AutoRest/Plugins/Configuration.cs Outdated Show resolved Hide resolved

m-nash requested changes Feb 16, 2021

View reviewed changes

bquantump added 5 commits February 16, 2021 11:27

Add operationsGroupMappings example

37b3555

WIP: NIT

90b6abc

Whitespace

0f8ac3d

wip: add example

3566a51

WIP: update storage

787a061

ShivangiReja reviewed Feb 16, 2021

View reviewed changes

src/AutoRest.CSharp/AutoRest/Communication/StandaloneGeneratorRunner.cs Outdated Show resolved Hide resolved

bquantump added 7 commits February 16, 2021 12:54

WIP: update storage

49c205d

WIP: test false

e352518

Write out json

a0e4b39

Update storage

4409f1c

WIP: remove exception for now

33d5d82

NIT

73c765c

NIT:

3d4b191

m-nash requested changes Feb 17, 2021

View reviewed changes

src/AutoRest.CSharp/Output/Models/Types/OutputLibrary.cs Outdated Show resolved Hide resolved

src/AutoRest.CSharp/Output/Models/Types/OutputLibrary.cs Outdated Show resolved Hide resolved

bquantump added 10 commits February 17, 2021 16:30

WIP: updates

7e5cca1

Update readme

a90573a

Merge branch 'mgmt-track2' into stevens_5393_providername

f99cf54

Wip: update compute

75fa054

Update config

43ade56

Merge branch 'feature/mgmt-track2' of https://github.com/Azure/autore…

22fac3a

…st.csharp into stevens_5393_providername

WIP: off by one

2b803f8

Remove Synapse

5619216

Remove more tests

341c2d4

Remove all mgmt test

bbca758

bquantump requested a review from m-nash February 18, 2021 01:18

bquantump added 3 commits February 17, 2021 18:23

Update OutputLibrary.cs

b04a653

Updates

0094d37

remove imds for now

526fbbc

This was referenced Feb 18, 2021

Stevens 5446 tenantid #1036

Closed

Tenant id #1037

Merged

Update Operations

9aebfe6

bquantump added 5 commits February 18, 2021 10:07

Update OutputLibrary.cs

87cfa94

Update OutputLibrary.cs

b16c97d

Update OutputLibrary.cs

b56ad45

Update OutputLibrary.cs

c1b2e98

Update OutputLibrary.cs

16b7ba4

m-nash approved these changes Feb 18, 2021

View reviewed changes

bquantump merged commit 94d4455 into Azure:feature/mgmt-track2 Feb 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update code to support adding and parsing provider name #1032

Update code to support adding and parsing provider name #1032

bquantump commented Feb 16, 2021 •

edited

Loading

bquantump commented Feb 16, 2021

bquantump commented Feb 16, 2021

bquantump commented Feb 16, 2021

pakrym commented Feb 16, 2021

bquantump commented Feb 16, 2021

pakrym commented Feb 16, 2021

pakrym Feb 16, 2021

bquantump commented Feb 16, 2021

pakrym commented Feb 16, 2021

bquantump commented Feb 18, 2021

pakrym commented Feb 18, 2021

Update code to support adding and parsing provider name #1032

Update code to support adding and parsing provider name #1032

Conversation

bquantump commented Feb 16, 2021 • edited Loading

bquantump commented Feb 16, 2021

bquantump commented Feb 16, 2021

bquantump commented Feb 16, 2021

pakrym commented Feb 16, 2021

bquantump commented Feb 16, 2021

pakrym commented Feb 16, 2021

pakrym Feb 16, 2021

Choose a reason for hiding this comment

bquantump commented Feb 16, 2021

pakrym commented Feb 16, 2021

bquantump commented Feb 18, 2021

pakrym commented Feb 18, 2021

bquantump commented Feb 16, 2021 •

edited

Loading