5400 list available locations #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create shell resource operations objects * added trailing newline * Revert "added trailing newline" This reverts commit a24d17d. * update launch settings to add a compute option vs modifying * updates after adding dummy constructor * updates after merge * updates to generated code * address pr comments * update after redoing npm install * update launchsettings * update samples list * revert unintended change * update ordering for launch settings
* add resource container shell to mgmt generation * Address review comments
* WIP: Update code for provider name * Add operationsGroupMappings example * Only Write out if has field * WIP: update operations config * Update readme * Wip: update compute * WIP: off by one * Remove Synapse * Remove more tests * Remove all mgmt test * Update OutputLibrary.cs * remove imds for now * Update Operations
* WIP: tenant id * WIP: rebase * Rebase * WIP * WIP: tenant deco * NIT * NIT * WIP: Update * NIT newline * Updates * WIP: updates * Updates * NIT
…into feature/mgmt-track2
* WIP: update * Updates * Fix bad merge * White space * Update config
* Generate public client constructors and options (Azure#1046) Generate public client constructors and options * Make client options class partial (Azure#1055) * Disable buffering for stream responses (Azure#1060) * updates after merge * duplicate end file * regen after merge Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com>
* Generate public client constructors and options (Azure#1046) Generate public client constructors and options * Make client options class partial (Azure#1055) * Disable buffering for stream responses (Azure#1060) * Add Url Encoded Body support (Azure#1042) - Fixes: Azure#986 * Fix LRO create request from relative path on Unix (Azure#1059) * Remove automated buffering logic (Azure#1064) * Add System.Text.Json converter to models (Azure#1063) Fixes: Azure#947 * Fix feature/v3 integration with azure-sdk-for-net (Azure#1065) - Autorest core 3.0.6372 and above crash due to directive ordering bug Tim is digging into now - New shared code does not compile cleanly with azure-sdk-for-net rules * Hide paging classes (Azure#1066) * Add help content (Azure#1067) * Add help content * update after merge Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: Chris Hamons <chris.hamons@microsoft.com> Co-authored-by: pavelprystinka <30868871+pavelprystinka@users.noreply.github.com> Co-authored-by: Timothee Guerin <tiguerin@microsoft.com>
* Add compute to test projects * Support generating empty [Resource]Data.cs and [Resource]Data.Serialization.cs * Upload compute codegen result * Remove codegen result * Resolve merge conflicts * Resolve reference errors * Refactor code * Regenerate Azure.ResourceManager.Sample * Regenerate Azure.Management.Storage * Update all other codegen files when running Generate.ps1 * Re-run Generate.ps1 * Remove the stale compute project * Decorate schema * Change ResourceData to inherit from ObjectType * Regenerate Azure.Management.Storage * Regenerate Azure.ResourceManager.Sample * Correct the Resource name in [Resource]Container.cs and [Resource]Operation.cs * Regenerate Azure.Management.Storage * Regenerate Azure.ResourceManager.Sample * Cleanup comments * Re-run Generate.ps1 * Address review comments * Run Generate.ps1 * regen * add files Co-authored-by: YalinLi0312 <yall@microsoft.com>
* Empty Resource Code Change * CI fix * Empty Resource Sample Update * Rename arm to mgmt as ARM is ingored * Updating storage sample * Updated resource to be in the Generated folder
JonathanCrd
requested review from
chamons,
pakrym and
ShivangiReja
as code owners
chamons
previously requested changes
Apr 6, 2021
m-nash
requested changes
Apr 6, 2021
samples/Azure.Management.Storage/Generated/BlobContainerOperations.cs
Outdated
Show resolved
Hide resolved
test/AutoRest.TestServer.Tests/Management/TenantOnly/ResourceOperationsTests.cs
Outdated
Show resolved
Hide resolved
…-ListAvailableLocations
…-ListAvailableLocations
…-ListAvailableLocations
pakrym
reviewed
Apr 8, 2021
|
/azp run autorest.csharp - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JonathanCrd
dismissed
chamons’s stale review
Comments have been addressed. No conflicts to solve and the PR has a description.
|
@JonathanCrd @m-nash - I would have really preferred to review this before it went it, and 17 hours ago was literally end of my day yesterday. Please don't dismiss my reviews without giving me time to respond. |
|
I mentioned this in Teams, but for visibility here there are merge conflicts incorrectly resolved, and Azure.Core.Experimental references were re-added. |
chamons
added a commit
to chamons/autorest.csharp
that referenced
this pull request
Apr 9, 2021
chamons
added a commit
that referenced
this pull request
Apr 9, 2021
- Resolve merge issue from #1126 - Fix random build failure due to duplicate names in tests (LLC and Data test duplicates).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO item 5400.
ListAvailableLocationsmethod added to [Resource]Operations objects.Tests in
TentantOnlyare being added as well.