Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sample-gen by default when generating sdk code (mgmt) #3673

Merged
merged 9 commits into from
Sep 7, 2023

Conversation

RodgeFu
Copy link
Member

@RodgeFu RodgeFu commented Aug 18, 2023

Fixes #3472

Description

  1. also generate sample code when using /t:GenerateCode
  2. Add /t:GenerateSamples for generating sample

SDK part change can be found at Azure/azure-sdk-for-net#38277

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@RodgeFu RodgeFu merged commit 4d25396 into Azure:feature/v3 Sep 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the sample generation process for mgmt. sdk
2 participants