-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include sample-gen by default when generating sdk code (mgmt) #38277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodgeFu
requested review from
archerzz,
ArcturusZhang and
ArthurMa1978
as code owners
August 18, 2023 06:32
6 tasks
API change check APIView has identified API level changes in this PR and created following API reviews. |
ArthurMa1978
approved these changes
Sep 7, 2023
@@ -11,6 +11,9 @@ namespace: Azure.ResourceManager.PrivateDns | |||
require: https://github.com/Azure/azure-rest-api-specs/blob/6b08774c89877269e73e11ac3ecbd1bd4e14f5a0/specification/privatedns/resource-manager/readme.md | |||
output-folder: $(this-folder)/Generated | |||
clear-output-folder: true | |||
sample-gen: | |||
output-folder: $(this-folder)/../samples/Generated | |||
clear-output-folder: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sample: false
yaotongms
pushed a commit
to yaotongms/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2023
…38277) * update autorest.md to include sample-gen config and delete autorest.tests.md * update more config * update config of hardwaresecuritymodule * fix blueprint sample config * update to include skip sample config * temp remove samplegen config for services using batch config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Azure/autorest.csharp#3472
Update the configuration part for enabling sample-gen by default when generating sdk code. Change in autorest.csharp part can be found at Azure/autorest.csharp#3673
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.