Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sample-gen by default when generating sdk code (mgmt) #38277

Merged
merged 9 commits into from
Sep 8, 2023

Conversation

RodgeFu
Copy link
Member

@RodgeFu RodgeFu commented Aug 18, 2023

Fixes Azure/autorest.csharp#3472

Update the configuration part for enabling sample-gen by default when generating sdk code. Change in autorest.csharp part can be found at Azure/autorest.csharp#3673

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 18, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.HardwareSecurityModules

@RodgeFu RodgeFu enabled auto-merge (squash) September 8, 2023 22:57
@RodgeFu RodgeFu merged commit ddbc54d into Azure:main Sep 8, 2023
510 checks passed
@@ -11,6 +11,9 @@ namespace: Azure.ResourceManager.PrivateDns
require: https://github.com/Azure/azure-rest-api-specs/blob/6b08774c89877269e73e11ac3ecbd1bd4e14f5a0/specification/privatedns/resource-manager/readme.md
output-folder: $(this-folder)/Generated
clear-output-folder: true
sample-gen:
output-folder: $(this-folder)/../samples/Generated
clear-output-folder: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample: false

yaotongms pushed a commit to yaotongms/azure-sdk-for-net that referenced this pull request Oct 12, 2023
…38277)

* update autorest.md to include sample-gen config and delete autorest.tests.md

* update more config

* update config of hardwaresecuritymodule

* fix blueprint sample config

* update to include skip sample config

* temp remove samplegen config for services using batch config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the sample generation process for mgmt. sdk
4 participants