do not run commands split on spaces #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
changed the title
…into output_errors * 'autorestv3' of https://github.com/Azure/autorest.python: Docs (#853)
prepare.py
Outdated
|
|
||
| python_run(venv_context, "pip", "install -r {}".format(_ROOT_DIR / 'dev_requirements.txt')) | ||
| python_run(venv_context, "pip", ["install", "-r", "{}".format(_ROOT_DIR / 'dev_requirements.txt')]) |
There was a problem hiding this comment.
Do you actually need to do a format here?(same in install.py)
There was a problem hiding this comment.
i can also use. a str cast. need to sinceit's a Path object, not a string. Might as well changeitto astr cast forreadibility
timotheeguerin
approved these changes
Jan 11, 2021
lmazuel
reviewed
Jan 11, 2021
lmazuel
approved these changes
Jan 11, 2021
iscai-msft
added a commit
that referenced
this pull request
Jan 19, 2021
…into paging_separate_operations * 'autorestv3' of https://github.com/Azure/autorest.python: bump m4 version and prepare for release (#866) fix links (#863) do not run commands split on spaces (#861) Docs (#853)
iscai-msft
added a commit
that referenced
this pull request
Mar 5, 2021
…into multiapi_diff_signatures * 'autorestv3' of https://github.com/Azure/autorest.python: (25 commits) Add help-content (#898) Update package.json Update ChangeLog.md Fix: Loading 'python' nested config (#897) skip tests (#891) fix debugging (#890) add invoke to client (#873) regen samples (#881) Update package.json bump autorest core version (#880) make m4 version a min version Update ChangeLog.md catch up with tests (#879) Increase m4 (#877) add new xml tests (#878) Catch deserialize error (#870) regen and move code model specific args to metadata.json (#867) bump m4 version and prepare for release (#866) fix links (#863) do not run commands split on spaces (#861) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@seankane-msft had an issue running autorest on his local machine, and this was down to the fact that he has a space in his root directory, so this line failed, as we were splitting up the root directory based off of space. Made this PR to fix that mistake