Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Loading 'python' nested config #897

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Feb 26, 2021

So the issue seems to have appear in release 5.0.0-preview.4 when m4 was updated. The change in m4 was the addition of prechecker which changed the pipeline loading order and broke this hack.

Change here is to forget about loading the python: nested configuration before modelerfour(This shouldn't be expected anyway) but just loading it before all the other plugins so it is available.

# This will work:
python: 
  output-folder: ./my-python-override

# But here modelerfour won't be able to use that  some-m4-config value
python: 
  modelerfour: 
    some-m4-config: foo

To achieve #2, you should be doing:

```yaml $(python)
modelerfour: 
  some-m4-config: foo
```

Using python: is meant to pass configuration only for the python plugin not if --python has been passed

@iscai-msft iscai-msft merged commit f6f36ba into autorestv3 Mar 1, 2021
@iscai-msft iscai-msft deleted the fix/python-nested-config branch March 1, 2021 23:33
iscai-msft added a commit that referenced this pull request Mar 5, 2021
…into multiapi_diff_signatures

* 'autorestv3' of https://github.com/Azure/autorest.python: (25 commits)
  Add help-content (#898)
  Update package.json
  Update ChangeLog.md
  Fix: Loading 'python' nested config (#897)
  skip tests (#891)
  fix debugging (#890)
  add invoke to client (#873)
  regen samples (#881)
  Update package.json
  bump autorest core version (#880)
  make m4 version a min version
  Update ChangeLog.md
  catch up with tests (#879)
  Increase m4 (#877)
  add new xml tests (#878)
  Catch deserialize error (#870)
  regen and move code model specific args to metadata.json (#867)
  bump m4 version and prepare for release (#866)
  fix links (#863)
  do not run commands split on spaces (#861)
  ...
iscai-msft added a commit that referenced this pull request Mar 23, 2021
…into prepare_request

* 'autorestv3' of https://github.com/Azure/autorest.python:
  remove output folder if generation went bad
  Add help-content (#898)
  Update package.json
  Update ChangeLog.md
  Fix: Loading 'python' nested config (#897)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants