EventHub - cli extension #37

v-Ajnava · 2018-01-17T18:43:46Z

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Have you run ./scripts/ci/test_static.sh locally? (pip install pylint flake8 required)
Have you run python scripts/ci/test_integration.py -q locally?

…into EHmasterExt

derekbekoe · 2018-01-18T18:17:08Z

.github/CODEOWNERS

@@ -3,3 +3,5 @@
 /src/index.json @derekbekoe

 /src/image-copy/ @tamirkamara
+
+/src/eventhubs/ @tamirkamara


Wrong CODEOWNER here

derekbekoe

A few things but looks good overall.

derekbekoe · 2018-01-18T18:36:04Z

src/eventhubs/setup.py

+    author_email='v-ajnava@microsoft.com',
+    url='https://github.com/Azure/azure-cli-extensions',
+    classifiers=CLASSIFIERS,
+    packages=find_packages(),


Ignore the tests here as well like in the SB extension.

derekbekoe · 2018-01-18T18:39:23Z

src/eventhubs/azext_eventhub/_params.py

+# pylint: disable=line-too-long
+def load_arguments_namespace(self, _):
+    with self.argument_context('eventhubs namespace exists') as c:
+        c.argument('namespace_name', options_list=['--name'], help='name of the Namespace')


Like in SB extension, add -n as short option.

derekbekoe · 2018-01-18T18:40:46Z

src/eventhubs/azext_eventhub/_params.py

+    with self.argument_context('eventhubs eventhub create') as c:
+        c.argument('resource_group_name', arg_type=resource_group_name_type)
+        c.argument('namespace_name', options_list=['--namespace-name'], help='name of the Namespace')
+        c.argument('event_hub_name', options_list=['--name', '-n'], help='Name of Evnethub')


Typo 'Evnethub'

Also, this doesn't seem to show up in help for az eventhubs eventhub create -h

derekbekoe · 2018-01-18T18:43:58Z

src/eventhubs/azext_eventhub/tests/test_eventhub_commands.py

+# Licensed under the MIT License. See License.txt in the project root for license information.
+# --------------------------------------------------------------------------------------------
+
+# AZURE CLI EventHub - NAMESAPCE TEST DEFINITIONS


nit: Typo 'NAMESAPCE'

derekbekoe · 2018-01-18T18:53:05Z

az eventhubs eventhub show shows a stacktrace if the eventhub doesn't exist.
Up to you if you want to address this also.

# az eventhubs eventhub show -g debekoe1 --namespace-name debekoe1n1 --name debekoe1eh1
Operation returned an invalid status code 'Not Found'
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/knack/cli.py", line 194, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 319, in execute
    six.reraise(*sys.exc_info())
  File "/usr/local/lib/python3.6/site-packages/six.py", line 693, in reraise
    raise value
  File "/usr/local/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 292, in execute
    result = cmd(params)
  File "/usr/local/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 169, in __call__
    return super(AzCliCommand, self).__call__(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/knack/commands.py", line 109, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/azure/cli/core/__init__.py", line 337, in default_command_handler
    result = op(**command_args)
  File "/root/.azure/cliextensions/eventhubs/azext_eventhub/eventhub/operations/event_hubs_operations.py", line 288, in get
    raise models.ErrorResponseException(self._deserialize, response)
azext_eventhub.eventhub.models.error_response.ErrorResponseException: Operation returned an invalid status code 'Not Found'

…into EHmasterExt # Conflicts: # .github/CODEOWNERS

v-Ajnava · 2018-01-19T17:39:15Z

@derekbekoe have added exception handler, please review and let me your comments

derekbekoe

Please try out the commands yourself.
Some commands clearly haven't been executed otherwise the errors would be found.

derekbekoe · 2018-01-19T18:15:48Z

src/eventhubs/azext_eventhub/_exception_handler.py

+    else:
+        import sys
+        from six import reraise
+        reraise(*sys.exc_info())


We expect an empty result on show commands, lot an exception to be raised.
See https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/util.py#L36-L40
Can you just use that method directly?

added method with ErrorResponseException, that method supports clouderror exception

derekbekoe · 2018-01-19T18:16:33Z

src/eventhubs/azext_eventhub/_help.py

+    examples:
+        - name: Create a new namespace.
+          text: az eventhubs namespace create --resource-group myresourcegroup --name mynamespace --location westus
+           --tags tag1=value1 tag2=value2 --sku-name Standard --sku-tier Standard' --is-auto-inflate-enabled False --maximum-throughput-units 30


There is an extra quote in Standard'. This should be removed.

derekbekoe · 2018-01-19T18:17:41Z

src/eventhubs/azext_eventhub/_help.py

+    short-summary: Creates a Geo Recovery - Alias for the give Namespace
+    examples:
+        - name: Creats Geo Recovery configuration - Alias for the give Namespace
+          text: az eventhubs georecovery-alias create  --resource-group myresourcegroup --namespace-name primarynamespace --alias myaliasname --partner-namespace recourcearmid


Typo in 'recourcearmid'

derekbekoe · 2018-01-19T18:20:05Z

src/eventhubs/azext_eventhub/_params.py

+    with self.argument_context('eventhubs eventhub create') as c:
+        c.argument('message_retention_in_days', options_list=['--message-retention-in-days'], type=int, help='Number of days to retain the events for this Event Hub, value should be 1 to 7 days')
+        c.argument('partition_count', options_list=['--partition-count'], type=int, help='Number of partitions created for the Event Hub, allowed values are from 1 to 32 partitions.')
+        c.argument('status', options_list=['--status'], arg_type=get_enum_type(['Active', 'Disabled', 'Restoring', 'SendDisabled', 'ReceiveDisabled', 'Creating', 'Deleting', 'Renaming', 'Unknown']))


Need 'help' for this param.

derekbekoe · 2018-01-19T18:21:06Z

src/eventhubs/azext_eventhub/_params.py

+    with self.argument_context('eventhubs eventhub') as c:
+        c.argument('event_hub_name', options_list=['--name', '-n'], help='Name of Eventhub')
+
+    with self.argument_context('eventhubs eventhub create') as c:


Need to add an entry for --capture-size-limit-bytes

renamed --capture-size-bytes to --capture-size-limit-bytes

derekbekoe · 2018-01-19T18:23:02Z

src/eventhubs/azext_eventhub/_params.py

+            c.argument('event_hub_name', options_list=['--event-hub-name'], help='name of the EventHub')
+
+    with self.argument_context('eventhubs eventhub authorizationrule create') as c:
+        c.argument('accessrights', options_list=['--access-rights'], help='AuthorizationRule rights of type list, allowed values are Send, Listen or Manage')


Why not use get_enum_type() here also since you know the allowed values?
Can a user enter values outside this range?

used get_enum_type()

I don't see the use of get_enum_type()?

derekbekoe · 2018-01-19T18:28:57Z

src/eventhubs/azext_eventhub/custom.py

+        cmd_result = client.get(resource_group_name, namespace_name)
+
+    if resource_group_name and not namespace_name:
+        cmd_result = client.list_by_resource_group(resource_group_name, namespace_name)


If namespace_name is not set, how can you pass it?
The SDK method doesn't even take that argument.
https://github.com/Azure/azure-sdk-for-python/blob/master/azure-mgmt-eventhub/azure/mgmt/eventhub/operations/namespaces_operations.py#L167

derekbekoe · 2018-01-19T18:33:43Z

src/eventhubs/azext_eventhub/custom.py

+def cli_namespace_list(client, resource_group_name=None, namespace_name=None):
+    cmd_result = None
+    if resource_group_name and namespace_name:
+        cmd_result = client.get(resource_group_name, namespace_name)


Remove this.
There is already a show command for namespaces.
This is not needed.
You can actually remove the namespace_name argument.

derekbekoe · 2018-01-19T18:34:22Z

src/eventhubs/azext_eventhub/custom.py

+        cmd_result = client.list_by_resource_group(resource_group_name, namespace_name)
+
+    if not resource_group_name and not namespace_name:
+        cmd_result = client.list(resource_group_name, namespace_name)


It takes no arguments.
https://github.com/Azure/azure-sdk-for-python/blob/master/azure-mgmt-eventhub/azure/mgmt/eventhub/operations/namespaces_operations.py#L103

derekbekoe · 2018-01-19T18:35:07Z

src/eventhubs/azext_eventhub/custom.py

+        cmd_result = client.list(resource_group_name, namespace_name)
+
+    if not cmd_result:
+        raise CLIError('--resource-group name required when namespace name is provided')


Remove this since namespace_name would be removed anyway.

derekbekoe

Add help for:
az eventhubs eventhub authorizationrule -h
az eventhubs eventhub authorizationrule keys -h
az eventhubs namespace authorizationrule -h
az eventhubs namespace authorizationrule keys -h

az eventhubs georecovery-alias -h Throws an exception.

Also, see my other comments below.

derekbekoe · 2018-01-23T01:29:21Z

src/eventhubs/azext_eventhub/custom.py

+                                                                                        capacity), is_auto_inflate_enabled, maximum_throughput_units))
+
+
+def cli_namespace_list(client, resource_group_name=None, namespace_name=None):


You're not using namespace_name in this method so it should be removed.

Also, you can then just have:

if resource_group_name: return client.list_by_resource_group(...) return client.list()

derekbekoe · 2018-01-23T01:31:11Z

src/eventhubs/azext_eventhub/_help.py

+    type: command
+    short-summary: List the ComsumerGroup by Eventhub
+    examples:
+        - name: Shows the ComsumerGroup by Eventhub.


Typo 'ComsumerGroup'

derekbekoe · 2018-01-23T01:31:21Z

src/eventhubs/azext_eventhub/_help.py

+
+helps['eventhubs consumergroup list'] = """
+    type: command
+    short-summary: List the ComsumerGroup by Eventhub


Typo 'ComsumerGroup'

derekbekoe · 2018-01-25T00:00:47Z

There is no help for:
az eventhubs georecovery-alias authorizationrule -h
az eventhubs georecovery-alias authorizationrule keys -h

derekbekoe · 2018-01-25T00:04:44Z

src/eventhubs/azext_eventhub/_params.py

+            c.argument('event_hub_name', options_list=['--event-hub-name'], help='name of the EventHub')
+
+    with self.argument_context('eventhubs eventhub authorizationrule create') as c:
+        c.argument('accessrights', options_list=['--access-rights'], help='AuthorizationRule rights of type list, allowed values are Send, Listen or Manage')


I don't see the use of get_enum_type()?

derekbekoe · 2018-01-25T00:07:16Z

src/eventhubs/azext_eventhub/custom.py

+    if resource_group_name:
+        cmd_result = client.list_by_resource_group(resource_group_name)
+
+    return cmd_result


Surely you still need the client.list() for when resource_group_name is not specified.

v-Ajnava · 2018-01-25T00:53:53Z

@derekbekoe , added the help for georecovery-alias authorizationrule and keys. added get_enum_type() to eventhub --access-rights

derekbekoe · 2018-01-25T01:01:29Z

src/eventhubs/azext_eventhub/_params.py

@@ -67,7 +67,7 @@ def load_arguments_eventhub(self, _):
            c.argument('event_hub_name', options_list=['--event-hub-name'], help='name of the EventHub')

    with self.argument_context('eventhubs eventhub authorizationrule create') as c:
-        c.argument('accessrights', options_list=['--access-rights'], help='AuthorizationRule rights of type list, allowed values are Send, Listen or Manage')
+        c.argument('accessrights', options_list=['--access-rights'], arg_type=get_enum_type(['Send', 'Listen', 'Manage']), help='AuthorizationRule rights of type list, allowed values are Send, Listen or Manage')


Please now remove , allowed values are Send, Listen or Manage') otherwise it will appear twice.

my bad. corrected the help text.

derekbekoe · 2018-01-25T23:24:28Z

src/eventhubs/azext_eventhub/custom.py

+    if not resource_group_name:
+        cmd_result = client.list()
+
+    return cmd_result


This can really just be:

def cli_namespace_list(client, resource_group_name=None): if resource_group_name: return client.list_by_resource_group(resource_group_name) return client.list()

Up to you if you want to make this change though.

* NFSAAS-2102 update to R3.5 (#29) * Nfsaas 2102 update to r3 5 (#30) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * Nfsaas 2102 update to r3 5 (#31) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#32) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#33) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#34) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#35) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#36) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#37) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#38) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#39) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#40) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Merge azure master back to fork. (#41) * Add new version of aks-preview in index.json (#634) * Azure Event Grid 0.4.1 (#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (#641) * [storage-preview] release azcopy 10.0.9 (#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (#642) * App Insights control plane (#600) * Remove 'preview' from Dev Spaces (#638) * Update PULL_REQUEST_TEMPLATE.md (#645) Refer to azdev. * setting default vm size for windows (#637) * SQL: make "up" command work end to end (#644) * Update requirements.txt Bump for Jinja security vulnerability

* NFSAAS-2102 update to R3.5 (Azure#29) * Nfsaas 2102 update to r3 5 (Azure#30) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * Nfsaas 2102 update to r3 5 (Azure#31) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#32) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#33) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#34) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#35) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#36) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#37) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#38) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#39) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#40) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Merge azure master back to fork. (Azure#41) * Add new version of aks-preview in index.json (Azure#634) * Azure Event Grid 0.4.1 (Azure#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (Azure#641) * [storage-preview] release azcopy 10.0.9 (Azure#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (Azure#642) * App Insights control plane (Azure#600) * Remove 'preview' from Dev Spaces (Azure#638) * Update PULL_REQUEST_TEMPLATE.md (Azure#645) Refer to azdev. * setting default vm size for windows (Azure#637) * SQL: make "up" command work end to end (Azure#644) * Update requirements.txt Bump for Jinja security vulnerability

* [image-copy] update to version 0.2.0 * [image-copy] update index for version 0.2.0 * switch to 2019-04-01 api version and enable windows agent pool (#612) * fixing az support for agent pools and mc * vendor in 2019-04-01 SDK * enableing windows profile * merge the latest official SDK * add secure prompt for windows admin password * fixing warnings * Policies should be global, remove location parameter and default it (#620) * bug fixes: missing service principal and network profile parameter validation (#626) * Pin max CLI version. (#630) * Update front door index to 0.1.5 (#632) * Fixes #629. (#631) * Update index.json. (#640) * Add new version of aks-preview in index.json (#634) * Azure Event Grid 0.4.1 (#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (#641) * [storage-preview] release azcopy 10.0.9 (#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (#642) * App Insights control plane (#600) * Remove 'preview' from Dev Spaces (#638) * Update PULL_REQUEST_TEMPLATE.md (#645) Refer to azdev. * setting default vm size for windows (#637) * SQL: make "up" command work end to end (#644) * Update requirements.txt Bump for Jinja security vulnerability * Update to RP standard release 3.5 (#29) (#627) * NFSAAS-2102 update to R3.5 (#29) * Nfsaas 2102 update to r3 5 (#30) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * Nfsaas 2102 update to r3 5 (#31) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#32) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#33) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#34) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#35) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#36) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#37) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#38) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#39) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#40) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Merge azure master back to fork. (#41) * Add new version of aks-preview in index.json (#634) * Azure Event Grid 0.4.1 (#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (#641) * [storage-preview] release azcopy 10.0.9 (#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (#642) * App Insights control plane (#600) * Remove 'preview' from Dev Spaces (#638) * Update PULL_REQUEST_TEMPLATE.md (#645) Refer to azdev. * setting default vm size for windows (#637) * SQL: make "up" command work end to end (#644) * Update requirements.txt Bump for Jinja security vulnerability * Update readme to reflect the latest SQL DB status * SQL up: update a typo * Update index.json for backwards compatability for Dev Spaces (#648) * update index.json for backwards compatability * fix maxCliVersion for dev-spaces-preview * revert dev-spaces minCliCoreVersion * update metadata for dev-spaces and dev-spaces-preview * update metadata for dev-spaces and dev-spaces-preview * sync workspaces * 0.5.0 release for Azure DevOps (#653) * [AKS]customizing node resource group (#636) * customizing node resource group * make 2.0 and 3.0 python work * add index * Onboard Azure Machine Learning Service CLI (#655) * [storage-preview] pulish 0.2.5 (#657) * [AKS] Add Azure policy addon (#651) * Add the Azure Policy Addon Support * Add azure-policy addon * Allow azure-policy addon in create * Update the index * Add the missing parameter description * 0.6.0 release for Azure DevOps (#660) * Upgrade AppConfig extension version from 0.4.0 to 0.5.0 (#661) * Upgrade AppConfig extension verstion from 0.4.0 to 0.5.0 * format downloadUrl * update wheel version to 0.30.0 * Update service principal secret for windows nodes (#662) * Release storage-preview 0.2.5 (#663) * Remove extra + (#664) * 0.7.0 release for Azure DevOps (#666) * 0.7.0 release for Azure DevOps * update sha * fix * remove botservice from index.json (#667) * [image-copy] fix temp_rg default valuet

* Merge k8s-extension/public into k8s-extension/private * Update the version * Fix testing concurrency

* Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model * Stage Public Version of k8s-extension 0.2.0 for official release (#15) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model Co-authored-by: action@github.com <Action - Fork Sync> * Remove custom pipelines file * Update extension description, remove private const * Update pipeline file * Disable refs docs * Update to include better create warning logs and remove update context (#20) * Update to include better create warning logs and remove update context * Remove help text for update * Fix spelling error * Update message * Fix k8s-extension conflict with private version * Fix style errors * Fix filename * add customization for microsoft.azureml.kubernetes (#23) * add customization for microsoft.azureml.kubernetes * Update release history Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Add E2E Testing from Separate branch into internal code (#26) * Add internal e2e testing * Change to testing folder * Inference CLI validation for Scoring FE (#24) * cli validation starter * added the call to the fe validation function * nodeport validation not required * test fix Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * legal warning added (#27) * Remove deprecated method logger.warn * Update k8s-custom-pipelines.yml for Azure Pipelines * Update k8s-custom-pipelines.yml for Azure Pipelines * Add Azure Defender to E2E testing (#28) * Add azure defender testing to e2e * Remove the debug flag * Add configuration testing * Fix pipeline failures * Make test script more intuitive * Remove parameter from testing * Fix wrong location for k8s config whl * Fix pip upgrade issue * Fix pip install upgrade issue * Fix pip install issue * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Provider registration case insensitive * do not validate against scoring fe if inference is not enabled. (#33) * do not validate against scoring fe if inference is not enabled. * add inference enabled scenario * refine * increase sleeping time * fix Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add OSM as Public Preview Extension (#34) * Add OSM as public preview extension * Add osm testing * Add release train to tests * Fix failing osm test * Upgrade pip in integration testing * Remove ununsed import * Fix release train check in update * Parallelize E2E Testing (#36) * Add OSM as public preview extension * Add osm testing * Update test logic to parallelize * Fix test success checking * Parallelize extension testing * Better error checking logic * Fix azureml deletion * Fix private build (#40) * change amlk8s to amlarc (#42) Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Servicebus client model changes (#44) * Servicebus client model changes * Fix testing script * Update history file and pipeline * Update min cli core version for track 2 updates * Read SSL cert and key from files (#38) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Upgrade release version * Liakaz/inference read ssl from file (#47) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments * fixed decode error * renamed the experimental param Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix style issues (#51) * Fixed scoring fe related extension param names (#49) * fixed scoring fe related extension params * bug fix and style fixes * variable rename * fixed the error type * set cluster to prod by default * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#53) removed release-train logic * Add Custom Delete Logic for Partners (#54) * Add custom delete logic * Fix failing unit tests * Add warning message when deleting amlarc extension (#55) * add warning message * fix indentation * Update release version * Remove Pyhelm from OSM customization (#58) * Fix OSM pyhelm bug * Debug bootstrap error * Update release message * Remove pyhelm dependency * Update tests to only check extensionconfig creation (#61) * Update tests to only check extensionconfig creation * Single set of CRUD for AzureML * Debug logs for connectedk8s * Increase open service mesh version number * Update k8s-extension Models to Track2 (#64) * Update k8s-extension models to track2 * Add debug for failed cleanup * Increase version number * Exit 0 on failed cleanup * Fix identity in wrong place in model (#66) * Readd osm-arc distro validation (#62) * Add distro validation for osm-arc removed release-train logic * Readd osm_arc distro validation * Fix style * Rm space * Edit test * Fixed tests and error logic * Remove dependency * Add delete method Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Don't Send Identity Headers If In DF (#67) * Don't send identity for clusters in dogfood * Add location to model for identity * Add identity validation to testing * Use default extension with identity instead of Cassandra specific (#69) * Remove the identity check for now * Add -t for clusterType parameter (#71) * Adding a flag for AKS to AMLARC migration and set up corresponding FE… (#65) * Adding a flag for AKS to AMLARC migration and set up corresponding FE helm values * Remove one extra line * Adding Scoring FE IS_AKS_MIGRATION check logic for helm values Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * remove version requirement and auto upgrade minor version check (#72) * Custom User Confirmation for Partners (#70) * Custom user confirmation * Check for disable confirm prompty for confirmation * Add yes to delete command * Code cleanup and style fixes (#73) * Enabled identity by default (#74) * Increase version * Fix df check and add unit test (#77) * Bump extension version * Pin helm version * Extensions GA changes into Public Branch (#79) * Add openservicemesh back * OpenServiceMesh import * Update osm with new extension model * Add back private file * Add Azure ML to list of private extensions (#16) * Update k8s-custom-pipelines.yml * Add Microsoft.PolicyInsights extension (#17) * Add Policy extension * Update comment * Update args * Fix linting errors Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add HISTORY_private file for private preview * Change versioning scheme * Update the code for supporting both extensions at once * Fix style issue * Remove old consts file * change the resource tag from managed_by:amlk8s to created_by:amlk8s-e… (#22) * change the resource tag from managed_by:amlk8s to created_by:amlk8s-extension * remove the lock when creating resources * fix lint * update version and HISTORY_private.rst * change error message Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Update the beta version with upstream * Update the private history file * Add upgrade pip to pipeline * Move pip install within virtualenv * Merge in k8s-extension/public (0.3.1) (#32) * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Update private release Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Release Version 0.4.0-b1 (#37) * Merge k8s-extension/public into k8s-extension/private * Update the version * Fix testing concurrency * K8s extension/private 0.4.0b2 (#41) * Fix private build (#40) * Update version * Upgrade to v0.5.2 * Fix policy bug * Increase private version * Update consts_private.py * Increase private version * Increase version with public * Add flux to private version * Update models for 2021-05-01-preview * Add async models to version * Add no wait to delete and create * support managed cluster * Bump version * Pin helm version * Add cmd to delete call * Add force deletion * add dapr extension (#78) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Fix failing integration tests * Adding the GA changes for private branch * Fix confirm prompt * Fix update E2E tests Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> * Remove unneeded files * Fix configuration settings in update * Only provide confirmation when specifying settings * Fix style issues Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Lia Kazakova <58274127+liakaz@users.noreply.github.com> Co-authored-by: Niranjan Shankar <nshankar@microsoft.com> Co-authored-by: jingyizhu99 <83610845+jingyizhu99@users.noreply.github.com> Co-authored-by: Harry Yang <huaimingyang@hotmail.com> Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Thomas Stringer <thomas@trstringer.com> Co-authored-by: NarayanThiru <nanthi@microsoft.com> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01>

* Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model * Stage Public Version of k8s-extension 0.2.0 for official release (#15) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model Co-authored-by: action@github.com <Action - Fork Sync> * Remove custom pipelines file * Update extension description, remove private const * Update pipeline file * Disable refs docs * Update to include better create warning logs and remove update context (#20) * Update to include better create warning logs and remove update context * Remove help text for update * Fix spelling error * Update message * Fix k8s-extension conflict with private version * Fix style errors * Fix filename * add customization for microsoft.azureml.kubernetes (#23) * add customization for microsoft.azureml.kubernetes * Update release history Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Add E2E Testing from Separate branch into internal code (#26) * Add internal e2e testing * Change to testing folder * Inference CLI validation for Scoring FE (#24) * cli validation starter * added the call to the fe validation function * nodeport validation not required * test fix Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * legal warning added (#27) * Remove deprecated method logger.warn * Update k8s-custom-pipelines.yml for Azure Pipelines * Update k8s-custom-pipelines.yml for Azure Pipelines * Add Azure Defender to E2E testing (#28) * Add azure defender testing to e2e * Remove the debug flag * Add configuration testing * Fix pipeline failures * Make test script more intuitive * Remove parameter from testing * Fix wrong location for k8s config whl * Fix pip upgrade issue * Fix pip install upgrade issue * Fix pip install issue * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Provider registration case insensitive * do not validate against scoring fe if inference is not enabled. (#33) * do not validate against scoring fe if inference is not enabled. * add inference enabled scenario * refine * increase sleeping time * fix Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add OSM as Public Preview Extension (#34) * Add OSM as public preview extension * Add osm testing * Add release train to tests * Fix failing osm test * Upgrade pip in integration testing * Remove ununsed import * Fix release train check in update * Parallelize E2E Testing (#36) * Add OSM as public preview extension * Add osm testing * Update test logic to parallelize * Fix test success checking * Parallelize extension testing * Better error checking logic * Fix azureml deletion * Fix private build (#40) * change amlk8s to amlarc (#42) Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Servicebus client model changes (#44) * Servicebus client model changes * Fix testing script * Update history file and pipeline * Update min cli core version for track 2 updates * Read SSL cert and key from files (#38) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Upgrade release version * Liakaz/inference read ssl from file (#47) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments * fixed decode error * renamed the experimental param Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix style issues (#51) * Fixed scoring fe related extension param names (#49) * fixed scoring fe related extension params * bug fix and style fixes * variable rename * fixed the error type * set cluster to prod by default * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#53) removed release-train logic * Add Custom Delete Logic for Partners (#54) * Add custom delete logic * Fix failing unit tests * Add warning message when deleting amlarc extension (#55) * add warning message * fix indentation * Update release version * Remove Pyhelm from OSM customization (#58) * Fix OSM pyhelm bug * Debug bootstrap error * Update release message * Remove pyhelm dependency * Update tests to only check extensionconfig creation (#61) * Update tests to only check extensionconfig creation * Single set of CRUD for AzureML * Debug logs for connectedk8s * Increase open service mesh version number * Update k8s-extension Models to Track2 (#64) * Update k8s-extension models to track2 * Add debug for failed cleanup * Increase version number * Exit 0 on failed cleanup * Fix identity in wrong place in model (#66) * Readd osm-arc distro validation (#62) * Add distro validation for osm-arc removed release-train logic * Readd osm_arc distro validation * Fix style * Rm space * Edit test * Fixed tests and error logic * Remove dependency * Add delete method Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Don't Send Identity Headers If In DF (#67) * Don't send identity for clusters in dogfood * Add location to model for identity * Add identity validation to testing * Use default extension with identity instead of Cassandra specific (#69) * Remove the identity check for now * Add -t for clusterType parameter (#71) * Adding a flag for AKS to AMLARC migration and set up corresponding FE… (#65) * Adding a flag for AKS to AMLARC migration and set up corresponding FE helm values * Remove one extra line * Adding Scoring FE IS_AKS_MIGRATION check logic for helm values Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * remove version requirement and auto upgrade minor version check (#72) * Custom User Confirmation for Partners (#70) * Custom user confirmation * Check for disable confirm prompty for confirmation * Add yes to delete command * Code cleanup and style fixes (#73) * Enabled identity by default (#74) * Increase version * Fix df check and add unit test (#77) * Bump extension version * Pin helm version * Extensions GA changes into Public Branch (#79) * Add openservicemesh back * OpenServiceMesh import * Update osm with new extension model * Add back private file * Add Azure ML to list of private extensions (#16) * Update k8s-custom-pipelines.yml * Add Microsoft.PolicyInsights extension (#17) * Add Policy extension * Update comment * Update args * Fix linting errors Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add HISTORY_private file for private preview * Change versioning scheme * Update the code for supporting both extensions at once * Fix style issue * Remove old consts file * change the resource tag from managed_by:amlk8s to created_by:amlk8s-e… (#22) * change the resource tag from managed_by:amlk8s to created_by:amlk8s-extension * remove the lock when creating resources * fix lint * update version and HISTORY_private.rst * change error message Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Update the beta version with upstream * Update the private history file * Add upgrade pip to pipeline * Move pip install within virtualenv * Merge in k8s-extension/public (0.3.1) (#32) * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Update private release Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Release Version 0.4.0-b1 (#37) * Merge k8s-extension/public into k8s-extension/private * Update the version * Fix testing concurrency * K8s extension/private 0.4.0b2 (#41) * Fix private build (#40) * Update version * Upgrade to v0.5.2 * Fix policy bug * Increase private version * Update consts_private.py * Increase private version * Increase version with public * Add flux to private version * Update models for 2021-05-01-preview * Add async models to version * Add no wait to delete and create * support managed cluster * Bump version * Pin helm version * Add cmd to delete call * Add force deletion * add dapr extension (#78) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Fix failing integration tests * Adding the GA changes for private branch * Fix confirm prompt * Fix update E2E tests Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> * Fix configuration settings in update * Only provide confirmation when specifying settings * Fix style issues * Cassandra tests with update (#81) * Add Microsoft.PolicyInsights extension for public preview (#83) * Add Azure Policy * Remove custom configuration and update tests * Yuyu3/fix upgrade public (#85) * populate configuration protected settings for azureml bump version && add log fetch connection string only if configuration protected settings are set update ssl key * bump the version * reverse changes on version and HISTORY.rst * inferenceLoadBalancerHA Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Remove Parallel Powershell Jobs (#82) * Unparallelize tests * Moved location of pipeline file * Remove the parallel invoke expression calls * Add templates to testing * Remove policy update test from extension E2E (#88) * feIsNodePort, feIsInternalLoadBalancer (#87) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix history file * remove unneeded files Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Lia Kazakova <58274127+liakaz@users.noreply.github.com> Co-authored-by: Niranjan Shankar <nshankar@microsoft.com> Co-authored-by: jingyizhu99 <83610845+jingyizhu99@users.noreply.github.com> Co-authored-by: Harry Yang <huaimingyang@hotmail.com> Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Thomas Stringer <thomas@trstringer.com> Co-authored-by: NarayanThiru <nanthi@microsoft.com> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01>

…tting Clusters from RPs (#4202) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model * Stage Public Version of k8s-extension 0.2.0 for official release (#15) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model Co-authored-by: action@github.com <Action - Fork Sync> * Remove custom pipelines file * Update extension description, remove private const * Update pipeline file * Disable refs docs * Update to include better create warning logs and remove update context (#20) * Update to include better create warning logs and remove update context * Remove help text for update * Fix spelling error * Update message * Fix k8s-extension conflict with private version * Fix style errors * Fix filename * add customization for microsoft.azureml.kubernetes (#23) * add customization for microsoft.azureml.kubernetes * Update release history Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Add E2E Testing from Separate branch into internal code (#26) * Add internal e2e testing * Change to testing folder * Inference CLI validation for Scoring FE (#24) * cli validation starter * added the call to the fe validation function * nodeport validation not required * test fix Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * legal warning added (#27) * Remove deprecated method logger.warn * Update k8s-custom-pipelines.yml for Azure Pipelines * Update k8s-custom-pipelines.yml for Azure Pipelines * Add Azure Defender to E2E testing (#28) * Add azure defender testing to e2e * Remove the debug flag * Add configuration testing * Fix pipeline failures * Make test script more intuitive * Remove parameter from testing * Fix wrong location for k8s config whl * Fix pip upgrade issue * Fix pip install upgrade issue * Fix pip install issue * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Provider registration case insensitive * do not validate against scoring fe if inference is not enabled. (#33) * do not validate against scoring fe if inference is not enabled. * add inference enabled scenario * refine * increase sleeping time * fix Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add OSM as Public Preview Extension (#34) * Add OSM as public preview extension * Add osm testing * Add release train to tests * Fix failing osm test * Upgrade pip in integration testing * Remove ununsed import * Fix release train check in update * Parallelize E2E Testing (#36) * Add OSM as public preview extension * Add osm testing * Update test logic to parallelize * Fix test success checking * Parallelize extension testing * Better error checking logic * Fix azureml deletion * Fix private build (#40) * change amlk8s to amlarc (#42) Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Servicebus client model changes (#44) * Servicebus client model changes * Fix testing script * Update history file and pipeline * Update min cli core version for track 2 updates * Read SSL cert and key from files (#38) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Upgrade release version * Liakaz/inference read ssl from file (#47) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments * fixed decode error * renamed the experimental param Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix style issues (#51) * Fixed scoring fe related extension param names (#49) * fixed scoring fe related extension params * bug fix and style fixes * variable rename * fixed the error type * set cluster to prod by default * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#53) removed release-train logic * Add Custom Delete Logic for Partners (#54) * Add custom delete logic * Fix failing unit tests * Add warning message when deleting amlarc extension (#55) * add warning message * fix indentation * Update release version * Remove Pyhelm from OSM customization (#58) * Fix OSM pyhelm bug * Debug bootstrap error * Update release message * Remove pyhelm dependency * Update tests to only check extensionconfig creation (#61) * Update tests to only check extensionconfig creation * Single set of CRUD for AzureML * Debug logs for connectedk8s * Increase open service mesh version number * Update k8s-extension Models to Track2 (#64) * Update k8s-extension models to track2 * Add debug for failed cleanup * Increase version number * Exit 0 on failed cleanup * Fix identity in wrong place in model (#66) * Readd osm-arc distro validation (#62) * Add distro validation for osm-arc removed release-train logic * Readd osm_arc distro validation * Fix style * Rm space * Edit test * Fixed tests and error logic * Remove dependency * Add delete method Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Don't Send Identity Headers If In DF (#67) * Don't send identity for clusters in dogfood * Add location to model for identity * Add identity validation to testing * Use default extension with identity instead of Cassandra specific (#69) * Remove the identity check for now * Add -t for clusterType parameter (#71) * Adding a flag for AKS to AMLARC migration and set up corresponding FE… (#65) * Adding a flag for AKS to AMLARC migration and set up corresponding FE helm values * Remove one extra line * Adding Scoring FE IS_AKS_MIGRATION check logic for helm values Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * remove version requirement and auto upgrade minor version check (#72) * Custom User Confirmation for Partners (#70) * Custom user confirmation * Check for disable confirm prompty for confirmation * Add yes to delete command * Code cleanup and style fixes (#73) * Enabled identity by default (#74) * Increase version * Fix df check and add unit test (#77) * Bump extension version * Pin helm version * Extensions GA changes into Public Branch (#79) * Add openservicemesh back * OpenServiceMesh import * Update osm with new extension model * Add back private file * Add Azure ML to list of private extensions (#16) * Update k8s-custom-pipelines.yml * Add Microsoft.PolicyInsights extension (#17) * Add Policy extension * Update comment * Update args * Fix linting errors Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add HISTORY_private file for private preview * Change versioning scheme * Update the code for supporting both extensions at once * Fix style issue * Remove old consts file * change the resource tag from managed_by:amlk8s to created_by:amlk8s-e… (#22) * change the resource tag from managed_by:amlk8s to created_by:amlk8s-extension * remove the lock when creating resources * fix lint * update version and HISTORY_private.rst * change error message Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Update the beta version with upstream * Update the private history file * Add upgrade pip to pipeline * Move pip install within virtualenv * Merge in k8s-extension/public (0.3.1) (#32) * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Update private release Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Release Version 0.4.0-b1 (#37) * Merge k8s-extension/public into k8s-extension/private * Update the version * Fix testing concurrency * K8s extension/private 0.4.0b2 (#41) * Fix private build (#40) * Update version * Upgrade to v0.5.2 * Fix policy bug * Increase private version * Update consts_private.py * Increase private version * Increase version with public * Add flux to private version * Update models for 2021-05-01-preview * Add async models to version * Add no wait to delete and create * support managed cluster * Bump version * Pin helm version * Add cmd to delete call * Add force deletion * add dapr extension (#78) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Fix failing integration tests * Adding the GA changes for private branch * Fix confirm prompt * Fix update E2E tests Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> * Fix configuration settings in update * Only provide confirmation when specifying settings * Fix style issues * Cassandra tests with update (#81) * Add Microsoft.PolicyInsights extension for public preview (#83) * Add Azure Policy * Remove custom configuration and update tests * Yuyu3/fix upgrade public (#85) * populate configuration protected settings for azureml bump version && add log fetch connection string only if configuration protected settings are set update ssl key * bump the version * reverse changes on version and HISTORY.rst * inferenceLoadBalancerHA Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Remove Parallel Powershell Jobs (#82) * Unparallelize tests * Moved location of pipeline file * Remove the parallel invoke expression calls * Add templates to testing * Remove policy update test from extension E2E (#88) * feIsNodePort, feIsInternalLoadBalancer (#87) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix history file * Add one more prompt for amlarc extension update (#94) * Add one more prompt for amlarc extension update * fix pylint issue * fix pylint issue * fix pylint issue * fix pylint issue Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> * Update Identity Creation for Appliance to Latest Version (#95) * Update appliance API to latest version for identity * Create a utils file with get parent_api_version * Fix style errors * Bump version * Remove unneeded files * Remove additional entry from history Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Lia Kazakova <58274127+liakaz@users.noreply.github.com> Co-authored-by: Niranjan Shankar <nshankar@microsoft.com> Co-authored-by: jingyizhu99 <83610845+jingyizhu99@users.noreply.github.com> Co-authored-by: Harry Yang <huaimingyang@hotmail.com> Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Thomas Stringer <thomas@trstringer.com> Co-authored-by: NarayanThiru <nanthi@microsoft.com> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> Co-authored-by: youhuatuyh <87928654+youhuatuyh@users.noreply.github.com> Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com>

…ft.ResourceConnector (#4221) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model * Stage Public Version of k8s-extension 0.2.0 for official release (#15) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model Co-authored-by: action@github.com <Action - Fork Sync> * Remove custom pipelines file * Update extension description, remove private const * Update pipeline file * Disable refs docs * Update to include better create warning logs and remove update context (#20) * Update to include better create warning logs and remove update context * Remove help text for update * Fix spelling error * Update message * Fix k8s-extension conflict with private version * Fix style errors * Fix filename * add customization for microsoft.azureml.kubernetes (#23) * add customization for microsoft.azureml.kubernetes * Update release history Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Add E2E Testing from Separate branch into internal code (#26) * Add internal e2e testing * Change to testing folder * Inference CLI validation for Scoring FE (#24) * cli validation starter * added the call to the fe validation function * nodeport validation not required * test fix Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * legal warning added (#27) * Remove deprecated method logger.warn * Update k8s-custom-pipelines.yml for Azure Pipelines * Update k8s-custom-pipelines.yml for Azure Pipelines * Add Azure Defender to E2E testing (#28) * Add azure defender testing to e2e * Remove the debug flag * Add configuration testing * Fix pipeline failures * Make test script more intuitive * Remove parameter from testing * Fix wrong location for k8s config whl * Fix pip upgrade issue * Fix pip install upgrade issue * Fix pip install issue * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Provider registration case insensitive * do not validate against scoring fe if inference is not enabled. (#33) * do not validate against scoring fe if inference is not enabled. * add inference enabled scenario * refine * increase sleeping time * fix Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add OSM as Public Preview Extension (#34) * Add OSM as public preview extension * Add osm testing * Add release train to tests * Fix failing osm test * Upgrade pip in integration testing * Remove ununsed import * Fix release train check in update * Parallelize E2E Testing (#36) * Add OSM as public preview extension * Add osm testing * Update test logic to parallelize * Fix test success checking * Parallelize extension testing * Better error checking logic * Fix azureml deletion * Fix private build (#40) * change amlk8s to amlarc (#42) Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Servicebus client model changes (#44) * Servicebus client model changes * Fix testing script * Update history file and pipeline * Update min cli core version for track 2 updates * Read SSL cert and key from files (#38) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Upgrade release version * Liakaz/inference read ssl from file (#47) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments * fixed decode error * renamed the experimental param Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix style issues (#51) * Fixed scoring fe related extension param names (#49) * fixed scoring fe related extension params * bug fix and style fixes * variable rename * fixed the error type * set cluster to prod by default * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#53) removed release-train logic * Add Custom Delete Logic for Partners (#54) * Add custom delete logic * Fix failing unit tests * Add warning message when deleting amlarc extension (#55) * add warning message * fix indentation * Update release version * Remove Pyhelm from OSM customization (#58) * Fix OSM pyhelm bug * Debug bootstrap error * Update release message * Remove pyhelm dependency * Update tests to only check extensionconfig creation (#61) * Update tests to only check extensionconfig creation * Single set of CRUD for AzureML * Debug logs for connectedk8s * Increase open service mesh version number * Update k8s-extension Models to Track2 (#64) * Update k8s-extension models to track2 * Add debug for failed cleanup * Increase version number * Exit 0 on failed cleanup * Fix identity in wrong place in model (#66) * Readd osm-arc distro validation (#62) * Add distro validation for osm-arc removed release-train logic * Readd osm_arc distro validation * Fix style * Rm space * Edit test * Fixed tests and error logic * Remove dependency * Add delete method Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Don't Send Identity Headers If In DF (#67) * Don't send identity for clusters in dogfood * Add location to model for identity * Add identity validation to testing * Use default extension with identity instead of Cassandra specific (#69) * Remove the identity check for now * Add -t for clusterType parameter (#71) * Adding a flag for AKS to AMLARC migration and set up corresponding FE… (#65) * Adding a flag for AKS to AMLARC migration and set up corresponding FE helm values * Remove one extra line * Adding Scoring FE IS_AKS_MIGRATION check logic for helm values Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * remove version requirement and auto upgrade minor version check (#72) * Custom User Confirmation for Partners (#70) * Custom user confirmation * Check for disable confirm prompty for confirmation * Add yes to delete command * Code cleanup and style fixes (#73) * Enabled identity by default (#74) * Increase version * Fix df check and add unit test (#77) * Bump extension version * Pin helm version * Extensions GA changes into Public Branch (#79) * Add openservicemesh back * OpenServiceMesh import * Update osm with new extension model * Add back private file * Add Azure ML to list of private extensions (#16) * Update k8s-custom-pipelines.yml * Add Microsoft.PolicyInsights extension (#17) * Add Policy extension * Update comment * Update args * Fix linting errors Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add HISTORY_private file for private preview * Change versioning scheme * Update the code for supporting both extensions at once * Fix style issue * Remove old consts file * change the resource tag from managed_by:amlk8s to created_by:amlk8s-e… (#22) * change the resource tag from managed_by:amlk8s to created_by:amlk8s-extension * remove the lock when creating resources * fix lint * update version and HISTORY_private.rst * change error message Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Update the beta version with upstream * Update the private history file * Add upgrade pip to pipeline * Move pip install within virtualenv * Merge in k8s-extension/public (0.3.1) (#32) * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Update private release Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Release Version 0.4.0-b1 (#37) * Merge k8s-extension/public into k8s-extension/private * Update the version * Fix testing concurrency * K8s extension/private 0.4.0b2 (#41) * Fix private build (#40) * Update version * Upgrade to v0.5.2 * Fix policy bug * Increase private version * Update consts_private.py * Increase private version * Increase version with public * Add flux to private version * Update models for 2021-05-01-preview * Add async models to version * Add no wait to delete and create * support managed cluster * Bump version * Pin helm version * Add cmd to delete call * Add force deletion * add dapr extension (#78) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Fix failing integration tests * Adding the GA changes for private branch * Fix confirm prompt * Fix update E2E tests Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> * Fix configuration settings in update * Only provide confirmation when specifying settings * Fix style issues * Cassandra tests with update (#81) * Add Microsoft.PolicyInsights extension for public preview (#83) * Add Azure Policy * Remove custom configuration and update tests * Yuyu3/fix upgrade public (#85) * populate configuration protected settings for azureml bump version && add log fetch connection string only if configuration protected settings are set update ssl key * bump the version * reverse changes on version and HISTORY.rst * inferenceLoadBalancerHA Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Remove Parallel Powershell Jobs (#82) * Unparallelize tests * Moved location of pipeline file * Remove the parallel invoke expression calls * Add templates to testing * Remove policy update test from extension E2E (#88) * feIsNodePort, feIsInternalLoadBalancer (#87) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix history file * Add one more prompt for amlarc extension update (#94) * Add one more prompt for amlarc extension update * fix pylint issue * fix pylint issue * fix pylint issue * fix pylint issue Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> * Update Identity Creation for Appliance to Latest Version (#95) * Update appliance API to latest version for identity * Create a utils file with get parent_api_version * Fix style errors * Bump version * Remove additional entry from history * Do not create identity with appliances (#97) * Bump version * Remove unneeded files Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Lia Kazakova <58274127+liakaz@users.noreply.github.com> Co-authored-by: Niranjan Shankar <nshankar@microsoft.com> Co-authored-by: jingyizhu99 <83610845+jingyizhu99@users.noreply.github.com> Co-authored-by: Harry Yang <huaimingyang@hotmail.com> Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Thomas Stringer <thomas@trstringer.com> Co-authored-by: NarayanThiru <nanthi@microsoft.com> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> Co-authored-by: youhuatuyh <87928654+youhuatuyh@users.noreply.github.com> Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com>

…4286) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model * Stage Public Version of k8s-extension 0.2.0 for official release (#15) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model Co-authored-by: action@github.com <Action - Fork Sync> * Remove custom pipelines file * Update extension description, remove private const * Update pipeline file * Disable refs docs * Update to include better create warning logs and remove update context (#20) * Update to include better create warning logs and remove update context * Remove help text for update * Fix spelling error * Update message * Fix k8s-extension conflict with private version * Fix style errors * Fix filename * add customization for microsoft.azureml.kubernetes (#23) * add customization for microsoft.azureml.kubernetes * Update release history Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Add E2E Testing from Separate branch into internal code (#26) * Add internal e2e testing * Change to testing folder * Inference CLI validation for Scoring FE (#24) * cli validation starter * added the call to the fe validation function * nodeport validation not required * test fix Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * legal warning added (#27) * Remove deprecated method logger.warn * Update k8s-custom-pipelines.yml for Azure Pipelines * Update k8s-custom-pipelines.yml for Azure Pipelines * Add Azure Defender to E2E testing (#28) * Add azure defender testing to e2e * Remove the debug flag * Add configuration testing * Fix pipeline failures * Make test script more intuitive * Remove parameter from testing * Fix wrong location for k8s config whl * Fix pip upgrade issue * Fix pip install upgrade issue * Fix pip install issue * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Provider registration case insensitive * do not validate against scoring fe if inference is not enabled. (#33) * do not validate against scoring fe if inference is not enabled. * add inference enabled scenario * refine * increase sleeping time * fix Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add OSM as Public Preview Extension (#34) * Add OSM as public preview extension * Add osm testing * Add release train to tests * Fix failing osm test * Upgrade pip in integration testing * Remove ununsed import * Fix release train check in update * Parallelize E2E Testing (#36) * Add OSM as public preview extension * Add osm testing * Update test logic to parallelize * Fix test success checking * Parallelize extension testing * Better error checking logic * Fix azureml deletion * Fix private build (#40) * change amlk8s to amlarc (#42) Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Servicebus client model changes (#44) * Servicebus client model changes * Fix testing script * Update history file and pipeline * Update min cli core version for track 2 updates * Read SSL cert and key from files (#38) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Upgrade release version * Liakaz/inference read ssl from file (#47) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments * fixed decode error * renamed the experimental param Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix style issues (#51) * Fixed scoring fe related extension param names (#49) * fixed scoring fe related extension params * bug fix and style fixes * variable rename * fixed the error type * set cluster to prod by default * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#53) removed release-train logic * Add Custom Delete Logic for Partners (#54) * Add custom delete logic * Fix failing unit tests * Add warning message when deleting amlarc extension (#55) * add warning message * fix indentation * Update release version * Remove Pyhelm from OSM customization (#58) * Fix OSM pyhelm bug * Debug bootstrap error * Update release message * Remove pyhelm dependency * Update tests to only check extensionconfig creation (#61) * Update tests to only check extensionconfig creation * Single set of CRUD for AzureML * Debug logs for connectedk8s * Increase open service mesh version number * Update k8s-extension Models to Track2 (#64) * Update k8s-extension models to track2 * Add debug for failed cleanup * Increase version number * Exit 0 on failed cleanup * Fix identity in wrong place in model (#66) * Readd osm-arc distro validation (#62) * Add distro validation for osm-arc removed release-train logic * Readd osm_arc distro validation * Fix style * Rm space * Edit test * Fixed tests and error logic * Remove dependency * Add delete method Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Don't Send Identity Headers If In DF (#67) * Don't send identity for clusters in dogfood * Add location to model for identity * Add identity validation to testing * Use default extension with identity instead of Cassandra specific (#69) * Remove the identity check for now * Add -t for clusterType parameter (#71) * Adding a flag for AKS to AMLARC migration and set up corresponding FE… (#65) * Adding a flag for AKS to AMLARC migration and set up corresponding FE helm values * Remove one extra line * Adding Scoring FE IS_AKS_MIGRATION check logic for helm values Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * remove version requirement and auto upgrade minor version check (#72) * Custom User Confirmation for Partners (#70) * Custom user confirmation * Check for disable confirm prompty for confirmation * Add yes to delete command * Code cleanup and style fixes (#73) * Enabled identity by default (#74) * Increase version * Fix df check and add unit test (#77) * Bump extension version * Pin helm version * Extensions GA changes into Public Branch (#79) * Add openservicemesh back * OpenServiceMesh import * Update osm with new extension model * Add back private file * Add Azure ML to list of private extensions (#16) * Update k8s-custom-pipelines.yml * Add Microsoft.PolicyInsights extension (#17) * Add Policy extension * Update comment * Update args * Fix linting errors Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add HISTORY_private file for private preview * Change versioning scheme * Update the code for supporting both extensions at once * Fix style issue * Remove old consts file * change the resource tag from managed_by:amlk8s to created_by:amlk8s-e… (#22) * change the resource tag from managed_by:amlk8s to created_by:amlk8s-extension * remove the lock when creating resources * fix lint * update version and HISTORY_private.rst * change error message Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Update the beta version with upstream * Update the private history file * Add upgrade pip to pipeline * Move pip install within virtualenv * Merge in k8s-extension/public (0.3.1) (#32) * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Update private release Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Release Version 0.4.0-b1 (#37) * Merge k8s-extension/public into k8s-extension/private * Update the version * Fix testing concurrency * K8s extension/private 0.4.0b2 (#41) * Fix private build (#40) * Update version * Upgrade to v0.5.2 * Fix policy bug * Increase private version * Update consts_private.py * Increase private version * Increase version with public * Add flux to private version * Update models for 2021-05-01-preview * Add async models to version * Add no wait to delete and create * support managed cluster * Bump version * Pin helm version * Add cmd to delete call * Add force deletion * add dapr extension (#78) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Fix failing integration tests * Adding the GA changes for private branch * Fix confirm prompt * Fix update E2E tests Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> * Fix configuration settings in update * Only provide confirmation when specifying settings * Fix style issues * Cassandra tests with update (#81) * Add Microsoft.PolicyInsights extension for public preview (#83) * Add Azure Policy * Remove custom configuration and update tests * Yuyu3/fix upgrade public (#85) * populate configuration protected settings for azureml bump version && add log fetch connection string only if configuration protected settings are set update ssl key * bump the version * reverse changes on version and HISTORY.rst * inferenceLoadBalancerHA Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Remove Parallel Powershell Jobs (#82) * Unparallelize tests * Moved location of pipeline file * Remove the parallel invoke expression calls * Add templates to testing * Remove policy update test from extension E2E (#88) * feIsNodePort, feIsInternalLoadBalancer (#87) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix history file * Add one more prompt for amlarc extension update (#94) * Add one more prompt for amlarc extension update * fix pylint issue * fix pylint issue * fix pylint issue * fix pylint issue Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> * Update Identity Creation for Appliance to Latest Version (#95) * Update appliance API to latest version for identity * Create a utils file with get parent_api_version * Fix style errors * Bump version * Remove additional entry from history * Do not create identity with appliances (#97) * Bump version * support sslSecret (#99) * support sslSecret * fix * fix error message Co-authored-by: Jun Min <mijun@microsoft.com> * Bump version to 1.0.4 * Remove unneeded files Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Lia Kazakova <58274127+liakaz@users.noreply.github.com> Co-authored-by: Niranjan Shankar <nshankar@microsoft.com> Co-authored-by: jingyizhu99 <83610845+jingyizhu99@users.noreply.github.com> Co-authored-by: Harry Yang <huaimingyang@hotmail.com> Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Thomas Stringer <thomas@trstringer.com> Co-authored-by: NarayanThiru <nanthi@microsoft.com> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> Co-authored-by: youhuatuyh <87928654+youhuatuyh@users.noreply.github.com> Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> Co-authored-by: Jun <mjaow0128@gmail.com> Co-authored-by: Jun Min <mijun@microsoft.com>

) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model * Stage Public Version of k8s-extension 0.2.0 for official release (#15) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model Co-authored-by: action@github.com <Action - Fork Sync> * Remove custom pipelines file * Update extension description, remove private const * Update pipeline file * Disable refs docs * Update to include better create warning logs and remove update context (#20) * Update to include better create warning logs and remove update context * Remove help text for update * Fix spelling error * Update message * Fix k8s-extension conflict with private version * Fix style errors * Fix filename * add customization for microsoft.azureml.kubernetes (#23) * add customization for microsoft.azureml.kubernetes * Update release history Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Add E2E Testing from Separate branch into internal code (#26) * Add internal e2e testing * Change to testing folder * Inference CLI validation for Scoring FE (#24) * cli validation starter * added the call to the fe validation function * nodeport validation not required * test fix Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * legal warning added (#27) * Remove deprecated method logger.warn * Update k8s-custom-pipelines.yml for Azure Pipelines * Update k8s-custom-pipelines.yml for Azure Pipelines * Add Azure Defender to E2E testing (#28) * Add azure defender testing to e2e * Remove the debug flag * Add configuration testing * Fix pipeline failures * Make test script more intuitive * Remove parameter from testing * Fix wrong location for k8s config whl * Fix pip upgrade issue * Fix pip install upgrade issue * Fix pip install issue * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Provider registration case insensitive * do not validate against scoring fe if inference is not enabled. (#33) * do not validate against scoring fe if inference is not enabled. * add inference enabled scenario * refine * increase sleeping time * fix Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add OSM as Public Preview Extension (#34) * Add OSM as public preview extension * Add osm testing * Add release train to tests * Fix failing osm test * Upgrade pip in integration testing * Remove ununsed import * Fix release train check in update * Parallelize E2E Testing (#36) * Add OSM as public preview extension * Add osm testing * Update test logic to parallelize * Fix test success checking * Parallelize extension testing * Better error checking logic * Fix azureml deletion * Fix private build (#40) * change amlk8s to amlarc (#42) Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Servicebus client model changes (#44) * Servicebus client model changes * Fix testing script * Update history file and pipeline * Update min cli core version for track 2 updates * Read SSL cert and key from files (#38) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Upgrade release version * Liakaz/inference read ssl from file (#47) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments * fixed decode error * renamed the experimental param Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix style issues (#51) * Fixed scoring fe related extension param names (#49) * fixed scoring fe related extension params * bug fix and style fixes * variable rename * fixed the error type * set cluster to prod by default * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#53) removed release-train logic * Add Custom Delete Logic for Partners (#54) * Add custom delete logic * Fix failing unit tests * Add warning message when deleting amlarc extension (#55) * add warning message * fix indentation * Update release version * Remove Pyhelm from OSM customization (#58) * Fix OSM pyhelm bug * Debug bootstrap error * Update release message * Remove pyhelm dependency * Update tests to only check extensionconfig creation (#61) * Update tests to only check extensionconfig creation * Single set of CRUD for AzureML * Debug logs for connectedk8s * Increase open service mesh version number * Update k8s-extension Models to Track2 (#64) * Update k8s-extension models to track2 * Add debug for failed cleanup * Increase version number * Exit 0 on failed cleanup * Fix identity in wrong place in model (#66) * Readd osm-arc distro validation (#62) * Add distro validation for osm-arc removed release-train logic * Readd osm_arc distro validation * Fix style * Rm space * Edit test * Fixed tests and error logic * Remove dependency * Add delete method Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Don't Send Identity Headers If In DF (#67) * Don't send identity for clusters in dogfood * Add location to model for identity * Add identity validation to testing * Use default extension with identity instead of Cassandra specific (#69) * Remove the identity check for now * Add -t for clusterType parameter (#71) * Adding a flag for AKS to AMLARC migration and set up corresponding FE… (#65) * Adding a flag for AKS to AMLARC migration and set up corresponding FE helm values * Remove one extra line * Adding Scoring FE IS_AKS_MIGRATION check logic for helm values Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * remove version requirement and auto upgrade minor version check (#72) * Custom User Confirmation for Partners (#70) * Custom user confirmation * Check for disable confirm prompty for confirmation * Add yes to delete command * Code cleanup and style fixes (#73) * Enabled identity by default (#74) * Increase version * Fix df check and add unit test (#77) * Bump extension version * Pin helm version * Extensions GA changes into Public Branch (#79) * Add openservicemesh back * OpenServiceMesh import * Update osm with new extension model * Add back private file * Add Azure ML to list of private extensions (#16) * Update k8s-custom-pipelines.yml * Add Microsoft.PolicyInsights extension (#17) * Add Policy extension * Update comment * Update args * Fix linting errors Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add HISTORY_private file for private preview * Change versioning scheme * Update the code for supporting both extensions at once * Fix style issue * Remove old consts file * change the resource tag from managed_by:amlk8s to created_by:amlk8s-e… (#22) * change the resource tag from managed_by:amlk8s to created_by:amlk8s-extension * remove the lock when creating resources * fix lint * update version and HISTORY_private.rst * change error message Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Update the beta version with upstream * Update the private history file * Add upgrade pip to pipeline * Move pip install within virtualenv * Merge in k8s-extension/public (0.3.1) (#32) * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Update private release Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Release Version 0.4.0-b1 (#37) * Merge k8s-extension/public into k8s-extension/private * Update the version * Fix testing concurrency * K8s extension/private 0.4.0b2 (#41) * Fix private build (#40) * Update version * Upgrade to v0.5.2 * Fix policy bug * Increase private version * Update consts_private.py * Increase private version * Increase version with public * Add flux to private version * Update models for 2021-05-01-preview * Add async models to version * Add no wait to delete and create * support managed cluster * Bump version * Pin helm version * Add cmd to delete call * Add force deletion * add dapr extension (#78) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Fix failing integration tests * Adding the GA changes for private branch * Fix confirm prompt * Fix update E2E tests Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> * Fix configuration settings in update * Only provide confirmation when specifying settings * Fix style issues * Cassandra tests with update (#81) * Add Microsoft.PolicyInsights extension for public preview (#83) * Add Azure Policy * Remove custom configuration and update tests * Yuyu3/fix upgrade public (#85) * populate configuration protected settings for azureml bump version && add log fetch connection string only if configuration protected settings are set update ssl key * bump the version * reverse changes on version and HISTORY.rst * inferenceLoadBalancerHA Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Remove Parallel Powershell Jobs (#82) * Unparallelize tests * Moved location of pipeline file * Remove the parallel invoke expression calls * Add templates to testing * Remove policy update test from extension E2E (#88) * feIsNodePort, feIsInternalLoadBalancer (#87) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix history file * Add one more prompt for amlarc extension update (#94) * Add one more prompt for amlarc extension update * fix pylint issue * fix pylint issue * fix pylint issue * fix pylint issue Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> * Update Identity Creation for Appliance to Latest Version (#95) * Update appliance API to latest version for identity * Create a utils file with get parent_api_version * Fix style errors * Bump version * Remove additional entry from history * Do not create identity with appliances (#97) * Bump version * support sslSecret (#99) * support sslSecret * fix * fix error message Co-authored-by: Jun Min <mijun@microsoft.com> * Bump version to 1.0.4 * Increase OSM verison to valid version (#104) * remove inference private review warning message (#102) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Update unit testing from osm to dapr (#106) * osm-ext: enable system identities (#105) * remove inference private review warning message (#109) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Build Extension in Template (#110) * Build extension using a template * Update build template in run test * Fix private build issues (#112) * Upgrade vendored_sdks to 2022-03-01 (#113) * Upgrade vendored_sdks to 2022-03-01 * Update recordings file * Bump version and changelog * Remove unneeded files Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Lia Kazakova <58274127+liakaz@users.noreply.github.com> Co-authored-by: Niranjan Shankar <nshankar@microsoft.com> Co-authored-by: jingyizhu99 <83610845+jingyizhu99@users.noreply.github.com> Co-authored-by: Harry Yang <huaimingyang@hotmail.com> Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Thomas Stringer <thomas@trstringer.com> Co-authored-by: NarayanThiru <nanthi@microsoft.com> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> Co-authored-by: youhuatuyh <87928654+youhuatuyh@users.noreply.github.com> Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> Co-authored-by: Jun <mjaow0128@gmail.com> Co-authored-by: Jun Min <mijun@microsoft.com> Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>

* Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model * Stage Public Version of k8s-extension 0.2.0 for official release (#15) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model Co-authored-by: action@github.com <Action - Fork Sync> * Remove custom pipelines file * Update extension description, remove private const * Update pipeline file * Disable refs docs * Update to include better create warning logs and remove update context (#20) * Update to include better create warning logs and remove update context * Remove help text for update * Fix spelling error * Update message * Fix k8s-extension conflict with private version * Fix style errors * Fix filename * add customization for microsoft.azureml.kubernetes (#23) * add customization for microsoft.azureml.kubernetes * Update release history Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Add E2E Testing from Separate branch into internal code (#26) * Add internal e2e testing * Change to testing folder * Inference CLI validation for Scoring FE (#24) * cli validation starter * added the call to the fe validation function * nodeport validation not required * test fix Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * legal warning added (#27) * Remove deprecated method logger.warn * Update k8s-custom-pipelines.yml for Azure Pipelines * Update k8s-custom-pipelines.yml for Azure Pipelines * Add Azure Defender to E2E testing (#28) * Add azure defender testing to e2e * Remove the debug flag * Add configuration testing * Fix pipeline failures * Make test script more intuitive * Remove parameter from testing * Fix wrong location for k8s config whl * Fix pip upgrade issue * Fix pip install upgrade issue * Fix pip install issue * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Provider registration case insensitive * do not validate against scoring fe if inference is not enabled. (#33) * do not validate against scoring fe if inference is not enabled. * add inference enabled scenario * refine * increase sleeping time * fix Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add OSM as Public Preview Extension (#34) * Add OSM as public preview extension * Add osm testing * Add release train to tests * Fix failing osm test * Upgrade pip in integration testing * Remove ununsed import * Fix release train check in update * Parallelize E2E Testing (#36) * Add OSM as public preview extension * Add osm testing * Update test logic to parallelize * Fix test success checking * Parallelize extension testing * Better error checking logic * Fix azureml deletion * Fix private build (#40) * change amlk8s to amlarc (#42) Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Servicebus client model changes (#44) * Servicebus client model changes * Fix testing script * Update history file and pipeline * Update min cli core version for track 2 updates * Read SSL cert and key from files (#38) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Upgrade release version * Liakaz/inference read ssl from file (#47) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments * fixed decode error * renamed the experimental param Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix style issues (#51) * Fixed scoring fe related extension param names (#49) * fixed scoring fe related extension params * bug fix and style fixes * variable rename * fixed the error type * set cluster to prod by default * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#53) removed release-train logic * Add Custom Delete Logic for Partners (#54) * Add custom delete logic * Fix failing unit tests * Add warning message when deleting amlarc extension (#55) * add warning message * fix indentation * Update release version * Remove Pyhelm from OSM customization (#58) * Fix OSM pyhelm bug * Debug bootstrap error * Update release message * Remove pyhelm dependency * Update tests to only check extensionconfig creation (#61) * Update tests to only check extensionconfig creation * Single set of CRUD for AzureML * Debug logs for connectedk8s * Increase open service mesh version number * Update k8s-extension Models to Track2 (#64) * Update k8s-extension models to track2 * Add debug for failed cleanup * Increase version number * Exit 0 on failed cleanup * Fix identity in wrong place in model (#66) * Readd osm-arc distro validation (#62) * Add distro validation for osm-arc removed release-train logic * Readd osm_arc distro validation * Fix style * Rm space * Edit test * Fixed tests and error logic * Remove dependency * Add delete method Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Don't Send Identity Headers If In DF (#67) * Don't send identity for clusters in dogfood * Add location to model for identity * Add identity validation to testing * Use default extension with identity instead of Cassandra specific (#69) * Remove the identity check for now * Add -t for clusterType parameter (#71) * Adding a flag for AKS to AMLARC migration and set up corresponding FE… (#65) * Adding a flag for AKS to AMLARC migration and set up corresponding FE helm values * Remove one extra line * Adding Scoring FE IS_AKS_MIGRATION check logic for helm values Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * remove version requirement and auto upgrade minor version check (#72) * Custom User Confirmation for Partners (#70) * Custom user confirmation * Check for disable confirm prompty for confirmation * Add yes to delete command * Code cleanup and style fixes (#73) * Enabled identity by default (#74) * Increase version * Fix df check and add unit test (#77) * Bump extension version * Pin helm version * Extensions GA changes into Public Branch (#79) * Add openservicemesh back * OpenServiceMesh import * Update osm with new extension model * Add back private file * Add Azure ML to list of private extensions (#16) * Update k8s-custom-pipelines.yml * Add Microsoft.PolicyInsights extension (#17) * Add Policy extension * Update comment * Update args * Fix linting errors Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add HISTORY_private file for private preview * Change versioning scheme * Update the code for supporting both extensions at once * Fix style issue * Remove old consts file * change the resource tag from managed_by:amlk8s to created_by:amlk8s-e… (#22) * change the resource tag from managed_by:amlk8s to created_by:amlk8s-extension * remove the lock when creating resources * fix lint * update version and HISTORY_private.rst * change error message Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Update the beta version with upstream * Update the private history file * Add upgrade pip to pipeline * Move pip install within virtualenv * Merge in k8s-extension/public (0.3.1) (#32) * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Update private release Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Release Version 0.4.0-b1 (#37) * Merge k8s-extension/public into k8s-extension/private * Update the version * Fix testing concurrency * K8s extension/private 0.4.0b2 (#41) * Fix private build (#40) * Update version * Upgrade to v0.5.2 * Fix policy bug * Increase private version * Update consts_private.py * Increase private version * Increase version with public * Add flux to private version * Update models for 2021-05-01-preview * Add async models to version * Add no wait to delete and create * support managed cluster * Bump version * Pin helm version * Add cmd to delete call * Add force deletion * add dapr extension (#78) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Fix failing integration tests * Adding the GA changes for private branch * Fix confirm prompt * Fix update E2E tests Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> * Fix configuration settings in update * Only provide confirmation when specifying settings * Fix style issues * Cassandra tests with update (#81) * Add Microsoft.PolicyInsights extension for public preview (#83) * Add Azure Policy * Remove custom configuration and update tests * Yuyu3/fix upgrade public (#85) * populate configuration protected settings for azureml bump version && add log fetch connection string only if configuration protected settings are set update ssl key * bump the version * reverse changes on version and HISTORY.rst * inferenceLoadBalancerHA Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Remove Parallel Powershell Jobs (#82) * Unparallelize tests * Moved location of pipeline file * Remove the parallel invoke expression calls * Add templates to testing * Remove policy update test from extension E2E (#88) * feIsNodePort, feIsInternalLoadBalancer (#87) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix history file * Add one more prompt for amlarc extension update (#94) * Add one more prompt for amlarc extension update * fix pylint issue * fix pylint issue * fix pylint issue * fix pylint issue Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> * Update Identity Creation for Appliance to Latest Version (#95) * Update appliance API to latest version for identity * Create a utils file with get parent_api_version * Fix style errors * Bump version * Remove additional entry from history * Do not create identity with appliances (#97) * Bump version * support sslSecret (#99) * support sslSecret * fix * fix error message Co-authored-by: Jun Min <mijun@microsoft.com> * Bump version to 1.0.4 * Increase OSM verison to valid version (#104) * remove inference private review warning message (#102) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Update unit testing from osm to dapr (#106) * osm-ext: enable system identities (#105) * remove inference private review warning message (#109) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Build Extension in Template (#110) * Build extension using a template * Update build template in run test * Fix private build issues (#112) * Upgrade vendored_sdks to 2022-03-01 (#113) * Upgrade vendored_sdks to 2022-03-01 * Update recordings file * Bump version and changelog * Update AzureMLKubernetes install parameters on inferenceRouterServiceType and internalLoadBalancerProvider (#114) * Add one more prompt for amlarc extension update * fix pylint issue * fix pylint issue * fix pylint issue * fix pylint issue * merge from AzureArcForKubernetes/azure-cli-extensions * Update AzureMLKubernetes install parameters on inferenceRouterServiceType and internalLoadBalancerProvider * update error message * update error message * fix pipeline failures * fix test failure Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Change extension validation logic osm-arc (#116) * added default identity support for microsoft.azurebackup.backupagent (#115) * Change extension validation logic osm-arc Signed-off-by: nshankar13 <nshankar@microsoft.com> Co-authored-by: sangitaray2021 <82883570+sangitaray2021@users.noreply.github.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * [k8s-extension] Add Managed Identity Auth support for ContainerInsights Extension (#118) * container insights aad auth support * container insights aad auth support * container insights aad auth support * handle useAADAuth setting * handle useAADAuth setting * delete dcr-a if its exists incase of MSI auth * fix formatting * fix formatting * fix formatting * fix formatting Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * fix install issue on aks (#119) * fix install issue on aks * Removing checking distribution Co-authored-by: youhuatu <youhuatu@outlook.com> * [k8s-extension] Bring back containerInsights solution addition in msi mode (#120) * bring back containerinsights solution in dcr mode * bring back containerinsights solution in dcr mode * Bump release version * Remove backup agent from mapping * Fix history file * clusterip (#121) * clusterip * fix pr test Co-authored-by: Jun Min <mijun@microsoft.com> * No default values for the patch scenario with extension (#122) * Bump version to 1.2.1 * Rename inferenceLoadBalancerHA (#123) * Rename inferenceLoadBalancerHA Rename inferenceLoadBalancerHA to inferenceRouterHA and unify related logic * Update AzureMLKubernetes.py * Remove unused comments to trigger pipeline * Update AzureMLKubernetes.py * Yuyu3/remove relay (#124) * remove relay * disable service bus by default, disable relay if target cluster is managed clusters. * move nginx ingress logic * remove service bus in tests * update HISTORY * If no default values provided for update, assign an empty dict. * set original_extension_config_settings to empty dict if it is None. * bump version to 1.2.2 Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Update test documentation for partners (#132) * remove warning message (#129) Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Use cluster scale to control clusterPurpose and inferenceRouterHA (#130) * Use cluster scale to control clusterPurpose and inferenceRouterHA * Update AzureMLKubernetes.py To solve transient gate error * Update AzureMLKubernetes.py * Update AzureMLKubernetes.py * Update AzureMLKubernetes.py Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix warning message returned on PATCH (#133) * Do not invoke 'create_or_update' if resource is already exists. (#135) * init * update HISTORY * do not populate clusterPurpose if infrenceRouterHA is not set. * use correct exception type. * use correct exception type. * fix lint * use correct exception type. Co-authored-by: Yue Yu <yuyu3@microsoft.com> * [k8s-extension] ContainerInsights Extension Managed Identity Auth Onboarding updates (#137) * bring back containerinsights solution in dcr mode * bring back containerinsights solution in dcr mode * update to stream group and DCR API version * Only test k8s-extension * [k8s-extension] ContainerInsights Extension Managed Identity Auth Onboarding related bug fixes (#141) * fix bugs * fix indent issues * remove get workspace key for msi auth * fix pr feedback * Fix osm-arc installation non-connected clusters Signed-off-by: nshankar13 <nshankar@microsoft.com> * k8s-extension azuredefender namespace to mdc (#152) Co-authored-by: Bsingh16 <33008256+bavneetsingh16@users.noreply.github.com> * change codeowners for k8s extension & configuration (#150) * change codeowners for k8s extension & configuration * change code owners Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> * bump k8s-extension version to 1.2.5 * delete testing files Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Lia Kazakova <58274127+liakaz@users.noreply.github.com> Co-authored-by: Niranjan Shankar <nshankar@microsoft.com> Co-authored-by: jingyizhu99 <83610845+jingyizhu99@users.noreply.github.com> Co-authored-by: Harry Yang <huaimingyang@hotmail.com> Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Thomas Stringer <thomas@trstringer.com> Co-authored-by: NarayanThiru <nanthi@microsoft.com> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> Co-authored-by: youhuatuyh <87928654+youhuatuyh@users.noreply.github.com> Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> Co-authored-by: Jun <mjaow0128@gmail.com> Co-authored-by: Jun Min <mijun@microsoft.com> Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> Co-authored-by: sangitaray2021 <82883570+sangitaray2021@users.noreply.github.com> Co-authored-by: Ganga Mahesh Siddem <gangams@microsoft.com> Co-authored-by: WangDian <wangdian82@gmail.com> Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Niv Ben Shabat <70891304+nishabat@users.noreply.github.com>

* Sundry fixes for CNF quickstart * merge add-aosm-ext in (Azure#37) * markups

* removed deploy with sdk * added artifact list * push example cnf bicep * Add temporary build workflow for AOSM extension (#4) * Add temporary build workflow for AOSM extension * Add Releaser to maintain a release with the latest build in a consistent place * added output dir; fixing getchartmappingschema * Add empty init files to inner modules so setuptools recognises them as modules * Use latest RG model to remove unnecessary dependency on version * Use latest deployment model to remove unnecessary dependency on version * fixed parameter mappings + copied needed files to output folder * jinja2 and find value paths * fixed typos + self.aritfacts only has unique artifacts * use regex instead of string to find deploy params * delete accidentaly commited input.json * fixed deploy params; added indent to mapping file * Update readme with install/bug reporting instructions * Adjust headers so rendered readme looks nicer * renamed values.nondef + added cli errors * Split help command example lines * Clarify that bug process is internal * fixed parameter vals not updating * delete unuseed temoplate and update jinja2 templates * Update README.md * Update README.md * added docstrings; added basic error catching with file handling * small refactor of generate nfd * fixed j2 template captions; added create_nfd to cnf; edited error messages; added deleting existing folder to custom.py * fixed file not found erroe * Refactor commands to az aosm nfd|nsd build (#10) * Refactor commands to az aosm nfd|nsd build * setup.py version * Version was wrong * remove publish option from build * lint * wrong params * fixed most style errors; ran static checks and azdev style * pre merge commit * more style changes; renamed vnfbicepnfd to vnfnfd * Update readme with workflow * added configfile validation * added temp dir to vnf; renamed shared constants * sunny markups * removed create_nfd_folder; added schema prefix to constant * added deploymentparams to constants.py * added error catching for get chart name and version * added meaningful logs; prevent auto overwriting input.json * edited vnf schema to have accepted types * added templates to setup.py * added location from input file not resourceGroup().location * added path_to_mappings to input.json; added logic to take mappings from file outside of helm package * renamed non_def_values to mappings_path * Pk5/add nsd cli (#15) * First working version of the CLI NSD create * Fully working version of the NSD CLI * minor change to nsd_generate * Sunny's refactor * First round of cleanup * Secound Round of cleanup * fix the 2023 api NSDV * description updates * deleted comment * Fix SNS creation * Fix SNS creation try 2 * markups * delete unnecessary file * Testing markups * Fix the SNS attempt 3 * minor fixes * Fix config validation * fix CNF depends on * initial commit; ran python static checks fmt (except on vendored sdks), fixed styling on _configuration.py * Name uploaded VHD correctly * Self review markups * broken config generation code * fixed up configuration.py * fixed cnf generator styling * fixed styling for cnf generator * fixed up nfd generator base and deploy with arm * fixed styling for artifact.py * fixed styling for atrifact manifest .py * Code review markups * fixed more linting * first attempt at regex * Sunny/choose deploy parameters (#23) * choose-deploy-parameters * optioned deployParameters for CNF * lint * lint2 * docs * docs * lint * 9.82 score * Fix bugs * more useful debug logs * Fix bugs and logging * lint * markups * Fix for oras target string with erroneous spaces * fixed regex; tested on existing charts and sas charts; committing to not lose prints for testing * changed regex constants + tidied * fixed blankspace * markups * initial commit * tidied code and added comments * add multi nf config * Add style and lint check * added logic for handling deployparams within lists * one line fix from review * removing print statement * added new test file and one unit test * added workflow for unit tests in pipeline + set up rough structure of unit testing * instantiated cnf class; added fake invalid helm package; added new files to use for testing * Nsd for cnfs (#33) * NSD building for CNFs * linting * Add Publish command to the CNF azure CLI (#24) * Working publish * Fix the artifact upload * Working image copy * minor fix * Minor fixes * sunny merge add-aosm-extension into patryk's branch (#25) * Sunny/choose deploy parameters (#23) * choose-deploy-parameters * optioned deployParameters for CNF * lint * lint2 * docs * docs * lint * 9.82 score * Fix bugs * more useful debug logs * Fix bugs and logging * lint * markups * comment out breaking line * minor TODOs * deleted comment * fix bring your own parameters * Markups * Fix the helm upload * Minor markups * Change error message --------- Co-authored-by: sunnycarter <36891339+sunnycarter@users.noreply.github.com> Co-authored-by: Sunny Carter <sunny.carter@metaswitch.com> * Expose NFD version and managed identities (#34) * NFDV version exposed as a CGV on an SNS * Managed identities support on NFs * Fix identiy, fix API versions * history --------- Co-authored-by: Jamie Parsons <jamie.parsons@metaswitch.com> Co-authored-by: Sunny Carter <sunny.carter@metaswitch.com> * Add a first VNF test * achurchard/style fixes (#35) Fix style issues raised by `azdev style` * Add CNF UTs that will fail at the moment * Actually include all files. * Always run tests * Add another test that won't pass yet * remove github pipeline tests - they should run in Azure * Sundry fixes for CNF quickstart (#38) * Sundry fixes for CNF quickstart * merge add-aosm-ext in (#37) * markups * NSD UTs * Update read me. * Improve path handling, other small refactorings (#39) # Main changes ## Make methods relying on self._tmp_dir private - `self._tmp_dir` is only available in the context of calling `generate_nfd()`, so methods relying on `self._tmp_dir` should be private ## Use pathlib.Path rather than os file operations - Provides clearer and stronger typing than passing `str`s around - Adds some handy utility functions ## Variable renaming for clarity - E.g. consistently use 'directory' / 'dir' (rather than mix with 'folder') - Obvs somewhat subjective, but as someone new to most of this code, the changes made sense to me ## Add nfd_bicep_path as abstract property on NFDGenerator - We rely on it when calling the concrete implementations - Also use ABC rather than raise NotImplementedError ## Miscellaneous style updates to keep `azdev style aosm` happy - isort - black * Fix Artifact upload on Windows (#40) * Black * Mark ups * Sunny/fix artifact upload windows (#41) * Fix Artifact upload on Windows * mypy fixups * mypy fixes * linting * mypy * mypy for _configuration.py * mypy for vnf_nfd_generator.py * mypy appeasement * python-static-checks fmt * az style happy * lint * mypy cnf_nfd_generator * copyright * more lint * Remove windows oras workaround now 0.0.18 oras out * history --------- Co-authored-by: Jamie Parsons <jamie.parsons@metaswitch.com> * Fix VNFD build (#42) * Multiple instances of the same NF * fix vnf deploy schema types (#44) * Tidy up * Mypy and docs * history.rst * Update README with logging info (#43) * Update README with logging info * Update docs * self markups * Take oras 0.1.19 to fix Windows artifact upload (#46) * Rename a few things * DRY the deploy_nfd_from_bicep code * Make conditional statements clearer * black * Update custom.py to use new nfd deploy method * Black with text processing * Create new nfRET class * Mypy passing * UTs passing * Dry the deploy_nfd_from_bicep() code (#48) - Removed duplicated code in the deploy_vnfd_from_bicep() and deploy_cnfd_from_bicep() methods - Moved variables onto the class instance and stopped passing them around in the method signatures - Also made the deployer class a dataclass for cleaner __init__ - Made parameters a property of the class, and moved the logic for getting/generating them into that property method - Improved the typing - Included adding enums for SkipSteps and DeployableResourceTypes - Added the new skip step logic for image uploads - Added a new skip step type of IMAGE_UPLOAD Testing: - No MyPy errors - Live tests for VNFS+NSD, CNFs, including all --skip options * Unit tests added * Versions are wrong in NSD template comments * Self review markups * Remove wrong comments * Code review markups * Extra markups * Fix mypy * Pk5/add integration tests (#51) * Somewhat working example * Cleanups * Update recording * fix minor linting error * More markups * Update output in tests * Pk5/minor integration tests changes (#52) * Modify changelog and rename tests * Delete recording file * Update recordings * Update developer docs * Remove credentials * Fix linting * cheeky extra change * Remove credentials from the integration test recordings (#54) * Modify changelog and rename tests * Delete recording file * Fix the credentials issue in the integration tests * Update CHANGELOG * Markups * Fix typo * Minor markups * Make cleaning up resources more robust and remove the VHD external reference * Markups * Remove the integration test from the repo (#56) * prerequisite docker for cnf * Fix bicep render on Windows (#57) * Fixes for Windows (#58) * Fix bicep render on Windows * Fixes for Windows * python-static-checks ran * ADO-880627: Use docker-less ACR login For running in environments without docker, such as CI pipelines. This affects uploading Helm charts for CNFs - the ACR login now fetches an access token, which is used to login to the Helm registry and upload the chart. * docker is not required any more * Remove pre-release build and lint files from release branch (#63) * Release markups - release branch (#65) * Markups from release comments * history * markups and fixes * README changes * linting fixes * Fix integration tests (#67) * Fix integration tests * Update src/aosm/development.md Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Update src/aosm/azext_aosm/tests/latest/test_aosm_cnf_publish_and_delete.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Update src/aosm/azext_aosm/tests/latest/test_aosm_cnf_publish_and_delete.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Markup changes --------- Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> Co-authored-by: Sunny Carter <sunny.carter@metaswitch.com> * Add aosm to service_name.json * move artifact upload to before nfd/nsd deploy (#62) * move artifact upload to before nfd/nsd deploy * markups * check in new test recording * non-working attempt to use token creds * Check for Azure features on deploy and delete (#71) * WIP: Check for features on deploy and delete * linting * Anand has confirmed names of flags * Update test recording as now has calls to Features API * Update src/aosm/azext_aosm/custom.py Co-authored-by: jamiedparsons <111778988+jamiedparsons@users.noreply.github.com> * docstring markups --------- Co-authored-by: jamiedparsons <111778988+jamiedparsons@users.noreply.github.com> * code working * Fix generate-config * Fix tests * lint * linting * Jl/nfdv proxy (#73) * added publisher scope to input file; changed to proxy nsdv * fixed get request on proxy nfdv (should be overwritten when autogenerated again) * small print bug fix --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Code review mark ups * Linting and fix UTs * aosm codeowner * Update HISTORY.rst * Normalise aosm version to 1.0.0b1 for release * update hashes in recording * Temporary test revert of "aosm codeowner" This reverts commit 479ba54. * Fix license header formatting * Revert "Temporary test revert of "aosm codeowner"" This reverts commit 0e4d0e7. * Remove nonexistent entry from codeowners * Fix source_local_docker_image defaults to placeholder text (#79) * temp fix for bug * minor formatting * refactor + change validation ordering to mimic previous behaviour * add docstring --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * renamed nsdg to nsd * Helptext + a little bit of validation * Fixed up validation * Return True if _all_ required artifact manifests exist, not just the last one checked. * Code markups + linting. * Docs: CNF publish options and permissions (#91) * Requirement for docker again * revert bad markup (#94) * Move live tests to swedensouth * Actually move to uaenorth * Don't log out ACR passwords when artifact commands fail (#97) * Don't log out passwords when artifact commands fail * Don't log out passwords when artifact commands fail part 2 * Comment to explain dropping the original exception * Fix cnf image take 2 (#101) * Fix CNF image copy to work cross subscription * Cross subscription works for image copy. Still test same subscription * lint * Error message * oops, code paste error * markups * appease mypy * Default RG and ACR Values with Publisher Name (#103) * added default rg and acr values for nf + nsd; added blob_url default for vnf * added bug fix to close Paulo's bug * change error message back --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Fix unauthorized error bug * Add spacing * fix unexpected symbol when parsing lists (#107) * Validation requirements on helm names (#109) * Validation requirements on helm names * lint * markups * lint * Fix error parsing * Lower case acr names (#112) * Lower case ACR names and fix interactive mode for lists * lint * remove duplicate else branch * always allow azureDeployLocation to be configurable * Add new optional VHD parameters * Make VNF publish and delete a live test only * Validate VHD parameters in build UT * Markups from the CLI team * mark-ups * remove azureDeployLocation as a configurable vhd parameter * add explanitory comments * Updates for 2023-09-01 API (#84) * Regen Python SDK from 2023-09-01 API - also uses latest AutoRest client - fix for HybridNetworkManagementClient init signature (swap order of subscription_id and credential parameters) * Update CLI extension code to use new SDK * added SAMI to publisher pre deploy * Update bicep templates to use 2023-09-01 * Update NF templates * Update metaschema * Add Allow-Publisher to required feature flags * Use secure objects for deployment parameters * Correctly get array item types in CNF deployment parameter schemas * Revert master .flake8 config * Fix double space in user output. Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> * Remove delete message to be consistent with other CLI extensions * Move "Deleted <resource>" messages to logger.info(). * Remove Blob_SAS_URL Option from ArmTemplate in input file (#119) * moved blob url to vhd config only; untested * stopped error in post innit before validate * changed ordering of inputs so that blob and filepath are next to each other; helptext for filepath different for each option * Markups from sunny * appease mypy --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Sunny Carter <sunny.carter@metaswitch.com> --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Jacob Darby <jdarby@microsoft.com> Co-authored-by: Chaos <chaosultima@outlook.com> Co-authored-by: Chaos Chhapi <chaos.chhapi@metaswitch.com> Co-authored-by: jordlay <72226943+jordlay@users.noreply.github.com> Co-authored-by: patrykkulik-microsoft <116072282+patrykkulik-microsoft@users.noreply.github.com> Co-authored-by: Jacob <53872686+jddarby@users.noreply.github.com> Co-authored-by: Jamie Parsons <jamie.parsons@metaswitch.com> Co-authored-by: jamiedparsons <111778988+jamiedparsons@users.noreply.github.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> Co-authored-by: William Bradley <wbradley@microsoft.com> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

Ajit Maruti Navasare (MINDTREE LIMITED) added 3 commits January 17, 2018 10:42

EventHub - cli extension

31d7745

fixed lint errors

53a0b6e

Merge branch 'master' of https://github.com/Azure/azure-cli-extensions …

2e5c6db

…into EHmasterExt

derekbekoe reviewed Jan 18, 2018

View reviewed changes

derekbekoe suggested changes Jan 18, 2018

View reviewed changes

Ajit Maruti Navasare (MINDTREE LIMITED) added 4 commits January 18, 2018 14:35

Review Comments

02f4384

Merge branch 'master' of https://github.com/Azure/azure-cli-extensions …

5f0b7e3

…into EHmasterExt # Conflicts: # .github/CODEOWNERS

fixed lint errors and test recordings

372ed52

exception handler

961f094

derekbekoe suggested changes Jan 19, 2018

View reviewed changes

Ajit Maruti Navasare (MINDTREE LIMITED) added 2 commits January 19, 2018 15:55

Review Comments

14c391f

lint fixes

a73583c

derekbekoe suggested changes Jan 23, 2018

View reviewed changes

Review Comments for Adding Help sub groups and exception fix

53cd73d

derekbekoe suggested changes Jan 25, 2018

View reviewed changes

added help for geodr authorule and keys

f96b09e

derekbekoe reviewed Jan 25, 2018

View reviewed changes

corrected access rights help text

8899fb6

derekbekoe approved these changes Jan 25, 2018

View reviewed changes

Merge branch 'master' into EHmasterExt

f39644c

derekbekoe merged commit e8200a5 into Azure:master Jan 25, 2018

ZeroMagic pushed a commit to ZeroMagic/azure-cli-extensions that referenced this pull request Oct 6, 2021

Release Version 0.4.0-b1 (Azure#37)

4b33818

* Merge k8s-extension/public into k8s-extension/private * Update the version * Fix testing concurrency

yuwzho pushed a commit to ninpan-ms/azure-cli-extensions that referenced this pull request Dec 16, 2021

add build pool size parameter (Azure#37)

7600a38

wangzelin007 pushed a commit to wangzelin007/azure-cli-extensions that referenced this pull request Jul 11, 2023

Sundry fixes for CNF quickstart (Azure#38)

0f86392

* Sundry fixes for CNF quickstart * merge add-aosm-ext in (Azure#37) * markups

		capacity), is_auto_inflate_enabled, maximum_throughput_units))


		def cli_namespace_list(client, resource_group_name=None, namespace_name=None):

EventHub - cli extension #37

EventHub - cli extension #37

Conversation

v-Ajnava commented Jan 17, 2018

General Guidelines

Choose a reason for hiding this comment

derekbekoe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekbekoe commented Jan 18, 2018

v-Ajnava commented Jan 19, 2018

derekbekoe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekbekoe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekbekoe commented Jan 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

v-Ajnava commented Jan 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment