-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aks-preview]: fix python3-only super() syntax #641
Conversation
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
e7644fa
to
fdb6f6f
Compare
* Add new version of aks-preview in index.json (Azure#634) * Azure Event Grid 0.4.1 (Azure#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (Azure#641) * [storage-preview] release azcopy 10.0.9 (Azure#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (Azure#642) * App Insights control plane (Azure#600) * Remove 'preview' from Dev Spaces (Azure#638) * Update PULL_REQUEST_TEMPLATE.md (Azure#645) Refer to azdev. * setting default vm size for windows (Azure#637) * SQL: make "up" command work end to end (Azure#644) * Update requirements.txt Bump for Jinja security vulnerability
* NFSAAS-2102 update to R3.5 (#29) * Nfsaas 2102 update to r3 5 (#30) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * Nfsaas 2102 update to r3 5 (#31) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#32) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#33) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#34) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#35) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#36) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#37) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#38) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#39) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#40) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Merge azure master back to fork. (#41) * Add new version of aks-preview in index.json (#634) * Azure Event Grid 0.4.1 (#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (#641) * [storage-preview] release azcopy 10.0.9 (#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (#642) * App Insights control plane (#600) * Remove 'preview' from Dev Spaces (#638) * Update PULL_REQUEST_TEMPLATE.md (#645) Refer to azdev. * setting default vm size for windows (#637) * SQL: make "up" command work end to end (#644) * Update requirements.txt Bump for Jinja security vulnerability
@mboersma, seems like it will block customer which is using python 3.7 super(type, obj): obj must be an instance or subtype of type |
@zqingqing1 in python 3, We use the two-argument |
I don't know why, but looks like old syntax is not compatible with python 3. This should work.
|
I don't know why either, but I agree that should work. :-) |
* NFSAAS-2102 update to R3.5 (Azure#29) * Nfsaas 2102 update to r3 5 (Azure#30) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * Nfsaas 2102 update to r3 5 (Azure#31) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#32) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#33) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#34) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#35) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#36) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#37) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#38) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#39) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#40) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Merge azure master back to fork. (Azure#41) * Add new version of aks-preview in index.json (Azure#634) * Azure Event Grid 0.4.1 (Azure#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (Azure#641) * [storage-preview] release azcopy 10.0.9 (Azure#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (Azure#642) * App Insights control plane (Azure#600) * Remove 'preview' from Dev Spaces (Azure#638) * Update PULL_REQUEST_TEMPLATE.md (Azure#645) Refer to azdev. * setting default vm size for windows (Azure#637) * SQL: make "up" command work end to end (Azure#644) * Update requirements.txt Bump for Jinja security vulnerability
* [image-copy] update to version 0.2.0 * [image-copy] update index for version 0.2.0 * switch to 2019-04-01 api version and enable windows agent pool (#612) * fixing az support for agent pools and mc * vendor in 2019-04-01 SDK * enableing windows profile * merge the latest official SDK * add secure prompt for windows admin password * fixing warnings * Policies should be global, remove location parameter and default it (#620) * bug fixes: missing service principal and network profile parameter validation (#626) * Pin max CLI version. (#630) * Update front door index to 0.1.5 (#632) * Fixes #629. (#631) * Update index.json. (#640) * Add new version of aks-preview in index.json (#634) * Azure Event Grid 0.4.1 (#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (#641) * [storage-preview] release azcopy 10.0.9 (#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (#642) * App Insights control plane (#600) * Remove 'preview' from Dev Spaces (#638) * Update PULL_REQUEST_TEMPLATE.md (#645) Refer to azdev. * setting default vm size for windows (#637) * SQL: make "up" command work end to end (#644) * Update requirements.txt Bump for Jinja security vulnerability * Update to RP standard release 3.5 (#29) (#627) * NFSAAS-2102 update to R3.5 (#29) * Nfsaas 2102 update to r3 5 (#30) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * Nfsaas 2102 update to r3 5 (#31) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#32) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#33) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#34) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#35) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#36) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#37) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#38) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#39) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (#40) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Merge azure master back to fork. (#41) * Add new version of aks-preview in index.json (#634) * Azure Event Grid 0.4.1 (#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (#641) * [storage-preview] release azcopy 10.0.9 (#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (#642) * App Insights control plane (#600) * Remove 'preview' from Dev Spaces (#638) * Update PULL_REQUEST_TEMPLATE.md (#645) Refer to azdev. * setting default vm size for windows (#637) * SQL: make "up" command work end to end (#644) * Update requirements.txt Bump for Jinja security vulnerability * Update readme to reflect the latest SQL DB status * SQL up: update a typo * Update index.json for backwards compatability for Dev Spaces (#648) * update index.json for backwards compatability * fix maxCliVersion for dev-spaces-preview * revert dev-spaces minCliCoreVersion * update metadata for dev-spaces and dev-spaces-preview * update metadata for dev-spaces and dev-spaces-preview * sync workspaces * 0.5.0 release for Azure DevOps (#653) * [AKS]customizing node resource group (#636) * customizing node resource group * make 2.0 and 3.0 python work * add index * Onboard Azure Machine Learning Service CLI (#655) * [storage-preview] pulish 0.2.5 (#657) * [AKS] Add Azure policy addon (#651) * Add the Azure Policy Addon Support * Add azure-policy addon * Allow azure-policy addon in create * Update the index * Add the missing parameter description * 0.6.0 release for Azure DevOps (#660) * Upgrade AppConfig extension version from 0.4.0 to 0.5.0 (#661) * Upgrade AppConfig extension verstion from 0.4.0 to 0.5.0 * format downloadUrl * update wheel version to 0.30.0 * Update service principal secret for windows nodes (#662) * Release storage-preview 0.2.5 (#663) * Remove extra + (#664) * 0.7.0 release for Azure DevOps (#666) * 0.7.0 release for Azure DevOps * update sha * fix * remove botservice from index.json (#667) * [image-copy] fix temp_rg default valuet
Restores the old, Python2-compatible syntax for calling
super()
.Fixes Azure/AKS#908
cc: @zqingqing1 @xizhamsft
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
./scripts/ci/test_static.sh
locally? (pip install pylint flake8
required)python scripts/ci/test_index.py -q
locally?For new extensions: