-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable allow_reuse_address
(SO_REUSEADDR
) on Windows
#10955
Conversation
Try to test CI, will close and re-open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for testing.
I can't cancel my approval now, which can be done before the permission change. Please don't merge before a real approval. |
I think we don't need to support multiple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test how to revoke approval.
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -395,16 +395,21 @@ def _get_platform_info(): | |||
return platform_name.lower(), release.lower() | |||
|
|||
|
|||
def _is_wsl(platform_name, release): | |||
def is_wsl(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why the original _is_wsl() is ignoring the passed in perameter platform_name, release
and calls _get_platform_info() to overwrite them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be some forgotten logic.
az login
hangsallow_reuse_address
(SO_REUSEADDR
) on Windows
@welersonlisboa, this PR is not relevant to #26180. |
Fix #10578:
az login
hangs when more than one instances ofaz login
are launched at the same time on Windows or WSLThe root cause is that
HTTPServer
can't detect port is in-use on Windows.To repro, launch
az login
but do not continue in the browser. Then runaz login
from another terminal and continue with the login. One of theaz
instance will get stuck.This PR disables
HTTPServer.allow_reuse_address
so that the correct routine is resumed.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.