Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set SO_REUSEADDR on Windows #551

Merged
merged 2 commits into from
Jun 29, 2012
Merged

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Jun 28, 2012

Windows interprets REUSEADDR differently, allowing simultaneous instances.

EDIT: SO_EXCLUSIVEADDR is an alternative, but it seems like doing nothing is actually the best choice.

closes #550

@alekstorm
Copy link
Contributor

Checking sys.platform == 'win32' excludes some Windows versions. Try os.name == 'nt' instead.

@minrk
Copy link
Contributor Author

minrk commented Jun 28, 2012

done.

bdarnell added a commit that referenced this pull request Jun 29, 2012
Don't set SO_REUSEADDR on Windows
@bdarnell bdarnell merged commit cfd7a96 into tornadoweb:master Jun 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: SO_REUSEADDR allows listening on occupied port
3 participants