{ARM} Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01 #14344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhoxing-ms
requested review from
arrownj,
bgklein,
bim-msft,
fengzhou-msft,
haroldrandom,
jaredmoo,
jiasli,
jsntcy,
Juliehzl,
mmyyrroonn,
qianwens,
qwordy,
samkreter and
v-Ajnava
as code owners
|
add to S173 |
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
from
80a33c2
to
ec4016c
Compare
zhoxing-ms
changed the title
bim-msft
approved these changes
Jul 16, 2020
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
3 times, most recently
from
ca579f1
to
ebcd759
Compare
zhoxing-ms
changed the title
fengzhou-msft
approved these changes
Jul 21, 2020
| @@ -5973,12 +5984,16 @@ def create_vpn_connection(cmd, resource_group_name, connection_name, vnet_gatewa | |||
| deployment_name = 'vpn_connection_deploy_' + random_string(32) | |||
| client = get_mgmt_service_client(cmd.cli_ctx, ResourceType.MGMT_RESOURCE_RESOURCES).deployments | |||
| properties = DeploymentProperties(template=template, parameters=parameters, mode='incremental') | |||
| deployment = Deployment(properties=properties) | |||
There was a problem hiding this comment.
Is it a breaking change?
There was a problem hiding this comment.
Yes, it is a breaking change of SDK, and we did made some compatibility logic to ensure that the CLI will not be broken
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
2 times, most recently
from
3f167be
to
aac6ad8
Compare
2 tasks
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
4 times, most recently
from
47b21b8
to
2374d54
Compare
zhoxing-ms
commented
Jul 24, 2020
Comment on lines
436
to
472
| def _deploy_arm_template_at_subscription_scope(cli_ctx, | ||
| def _deploy_arm_template_at_subscription_scope(cmd, | ||
| template_file=None, template_uri=None, parameters=None, | ||
| deployment_name=None, deployment_location=None, validate_only=False, | ||
| no_wait=False, no_prompt=False): | ||
| deployment_properties = _prepare_deployment_properties_unmodified(cli_ctx=cli_ctx, template_file=template_file, | ||
| deployment_properties = _prepare_deployment_properties_unmodified(cli_ctx=cmd.cli_ctx, template_file=template_file, | ||
| template_uri=template_uri, parameters=parameters, | ||
| mode='Incremental', | ||
| no_prompt=no_prompt) | ||
|
|
||
| mgmt_client = _get_deployment_management_client(cli_ctx, plug_pipeline=(template_uri is None)) | ||
| mgmt_client = _get_deployment_management_client(cmd.cli_ctx, plug_pipeline=(template_uri is None)) | ||
|
|
||
| validation_result = mgmt_client.validate_at_subscription_scope(deployment_name=deployment_name, properties=deployment_properties, location=deployment_location) | ||
| if cmd.supported_api_version(min_api='2019-10-01'): | ||
| Deployment = cmd.get_models('Deployment') | ||
| deployment = Deployment(properties=deployment_properties, location=deployment_location) | ||
| validation_poller = mgmt_client.validate_at_subscription_scope(deployment_name, deployment) | ||
| validation_result = LongRunningOperation(cmd.cli_ctx)(validation_poller) | ||
| else: | ||
| validation_result = mgmt_client.validate_at_subscription_scope(deployment_name, deployment_properties, deployment_location) | ||
|
|
||
| if validation_result and validation_result.error: | ||
| err_message = _build_preflight_error_message(validation_result.error) | ||
| raise CLIError(err_message) | ||
| if validate_only: | ||
| return validation_result | ||
|
|
||
| return sdk_no_wait(no_wait, mgmt_client.create_or_update_at_subscription_scope, | ||
| deployment_name, deployment_properties, deployment_location) | ||
| if cmd.supported_api_version(min_api='2019-10-01'): | ||
| return sdk_no_wait(no_wait, mgmt_client.create_or_update_at_subscription_scope, deployment_name, deployment) | ||
| return sdk_no_wait(no_wait, mgmt_client.create_or_update_at_subscription_scope, deployment_name, | ||
| deployment_properties, deployment_location) |
There was a problem hiding this comment.
Compatibility logic for breaking change from SDK
haroldrandom
approved these changes
Jul 24, 2020
mmyyrroonn
approved these changes
Jul 24, 2020
Juliehzl
approved these changes
Jul 24, 2020
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
6 times, most recently
from
d7b4f58
to
515ac0d
Compare
v-Ajnava
approved these changes
Jul 27, 2020
arrownj
approved these changes
Jul 27, 2020
|
@samkreter Could you please help to review this PR for your part~ |
jiasli
approved these changes
Jul 27, 2020
jsntcy
reviewed
Jul 27, 2020
| @@ -1,4 +1,4 @@ | |||
| #Wed Jul 22 11:25:50 Pacific Daylight Time 2020 | |||
| #Fri Jul 24 17:56:48 China Standard Time 2020 | |||
There was a problem hiding this comment.
Does this comments affect test result? #Closed
There was a problem hiding this comment.
This is automatically generated and should not affect the test results #Closed
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
2 times, most recently
from
b5dde9b
to
3f120b8
Compare
zhoxing-ms
force-pushed
the
mgmt-resource-bump-api-version
branch
from
3f120b8
to
a043ea6
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01
For PR: #13429 #14241
At the same time, some compatibility logic was made for the breaking change of SDK to ensure that breaking will not be produced on the CLI side, such as: click
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.