Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM] az tag support for -id parameter #13429

Closed
wants to merge 31 commits into from

Conversation

Grayer123
Copy link
Contributor

Description

We are working on expanding our tags related cli cmdlets, to be more specific, adding the following cmdlets:

  • Gets the entire set of tags on a resource, resource group or subscription. (later more proxy resources will be supported)
  • Creates or updates the entire set of tags on a resource, resource group or subscription.
  • Selectively updates the set of tags on a resource, resource group or subscription.
  • Deletes the entire set of tags on a resource, resource group or subscription.

At this stage, we are just supporting –-resourceid for all cmdlets, and they will look like as following:(supporting both --resourceid and -id)

  • az tag list –-resourceid {resourceId}
  • az tag create –-resourceid {resourceId} –-tags {tags_list}
  • az tag update –-resourceid {resourceId} –-operation {patch_operation} –-tags {tags_list} (the operations include merge, replace and delete)
  • az tag delete –-resourceid {resourceId}
    We have the same design in the PowerShell cmdlet, please see this powershell design pr for more details.

Testing Guide

  • Add test cases for subscription, resource group, and tracked resources for all added tags cmdlets.

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented May 11, 2020

add to S170

@yonzhan yonzhan modified the milestones: S170, S171 May 31, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented May 31, 2020

add to S171

@Juliehzl
Copy link
Contributor

Juliehzl commented Jun 2, 2020

@Grayer123 Can you take a look for test failures?

@zhoxing-ms
Copy link
Contributor

@Grayer123 Could you add some examples in help for the new feature?

@Grayer123
Copy link
Contributor Author

Hi @Juliehzl, @zhoxing-ms, I am still waiting for the new python sdk to be released. I have followed up a few times, and it seems the sdk team is having some issue with the "subscription_id", and trying to resolve it. I will look into the test failures and add examples when the new sdk is ready, as some of the test failures would be fixed along the way.

@Grayer123 Grayer123 changed the title Cmdlets changes for 2019-10-01 tags related api changes [ARM] Tags support for resourceid Jun 12, 2020
@Grayer123 Grayer123 changed the title [ARM] Tags support for resourceid [ARM] az tag support for -id parameter Jun 12, 2020
@yonzhan yonzhan modified the milestones: S171, S172 Jun 20, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 20, 2020

add to S172

@zhoxing-ms
Copy link
Contributor

Replaced by #14558, so I close it first~

@zhoxing-ms zhoxing-ms closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants